DsnParser::getDsnParts() - Code Metrics - Inspection of "Remove PHP 7 specific from scrutinizer" - meanbee/libmageconf - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 7a093e...068245 )

by Nick

created 2016-09-16 10:22 UTC

DsnParser::getDsnParts() A

↳ Parent: DsnParser

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
c	0
b	0
f	0
rs	9.4285
cc	2
eloc	11
nc	2
nop	0

<?php

namespace Meanbee\LibMageConf\Util;

class DsnParser
{
    /**
     * @param $dsnString
     */
    public function __construct($dsnString)
    {
        $this->dsn = $dsnString;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @return string
     */
    public function getPort()
    {
        return $this->getDsnParts()['port'];
    }

    /**
     * @return string
     */
    public function getHost()
    {
        return $this->getDsnParts()['host'];
    }

    /**
     * @return array
     */
    protected function getDsnParts()
    {
        $colonPosition = strrpos($this->dsn, ':');

        if ($colonPosition === false) {
            $host = $this->dsn;
            $port = '';
        } else {
            $host = substr($this->dsn, 0, $colonPosition);
            $port = substr($this->dsn, $colonPosition + 1);
        }

        return [
            'host' => $host,
            'port' => $port
        ];
    }
}

1			<?php
2
3			namespace Meanbee\LibMageConf\Util;
4
5			class DsnParser
6			{
7			/**
8			* @param $dsnString
9			*/
10			public function __construct($dsnString)
11			{
12			$this->dsn = $dsnString;
			0 ignored issues – show Bug introduced 2016-09-16 10:27 UTC by Report Bug Copy Issue Report The property `dsn` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
13			}
14
15			/**
16			* @return string
17			*/
18			public function getPort()
19			{
20			return $this->getDsnParts()['port'];
21			}
22
23			/**
24			* @return string
25			*/
26			public function getHost()
27			{
28			return $this->getDsnParts()['host'];
29			}
30
31			/**
32			* @return array
33			*/
34			protected function getDsnParts()
35			{
36			$colonPosition = strrpos($this->dsn, ':');
37
38			if ($colonPosition === false) {
39			$host = $this->dsn;
40			$port = '';
41			} else {
42			$host = substr($this->dsn, 0, $colonPosition);
43			$port = substr($this->dsn, $colonPosition + 1);
44			}
45
46			return [
47			'host' => $host,
48			'port' => $port
49			];
50			}
51			}

meanbee / libmageconf

Push — master ( 7a093e...068245 )

DsnParser::getDsnParts() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like