DiceGenerator::getDiceForPart() - Code Metrics - Inspection of "tidy up dice generator" - meadsteve/DiceApi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6bb539...9dcb59 )

by Steve

created 2015-11-25 15:09 UTC

DiceGenerator::getDiceForPart() B

↳ Parent: DiceGenerator

Complexity

Conditions	6
Paths	4

Size

Total Lines	18
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	18
rs	8.8571
cc	6
eloc	12
nc	4
nop	1

<?php

namespace MeadSteve\DiceApi\Dice;

use MeadSteve\DiceApi\BasicDice;
use MeadSteve\DiceApi\Dice;


class DiceGenerator
{
    public function diceFromUrlString($urlString)
    {
        $parts = explode("/", $urlString);
        $diceSets = array_map([$this, 'getDiceForPart'], $parts);
        return $this->flattenDiceSets($diceSets);
    }

    /**
     * @param string $part
     * @return Dice[]
     */
    private function getDiceForPart($part)
    {
        $newDice = [];
        $data = [];
        $valid = preg_match("/(?P<count>[0-9]+)?d(?P<size>[0-9]+)/i", $part, $data);
        if ($valid) {
            if ((strlen($data["size"]) > 4) || ($data["size"] > 9000)) {
                throw new UncreatableDiceException("Only dice with a power level less than 9000 can be created.");
            }
            if (!$data["count"]) {
                $data["count"] = 1;
            }
            for ($i = 0; $i < $data["count"]; $i++) {
                $newDice[] = $this->newDiceOfSize($data["size"]);
            }
        }
        return $newDice;
    }

    /**
     * @param $size
     * @return Dice
     */
    private function newDiceOfSize($size)
    {
        if ($size == 0) {
            return new ZeropointDice();
        }
        return new BasicDice($size);
    }

    /**
     * @param array[]
     * @return array
     */
    private function flattenDiceSets($diceSets)
    {
        $dice = [];
        foreach ($diceSets as $set) {
            $dice = array_merge($dice, $set);
        }
        return $dice;
    }
}


1			<?php
2
3			namespace MeadSteve\DiceApi\Dice;
4
5			use MeadSteve\DiceApi\BasicDice;
6			use MeadSteve\DiceApi\Dice;
7
8
9			class DiceGenerator
10			{
11			public function diceFromUrlString($urlString)
12			{
13			$parts = explode("/", $urlString);
14			$diceSets = array_map([$this, 'getDiceForPart'], $parts);
15			return $this->flattenDiceSets($diceSets);
16			}
17
18			/**
19			* @param string $part
20			* @return Dice[]
21			*/
22			private function getDiceForPart($part)
23			{
24			$newDice = [];
25			$data = [];
26			$valid = preg_match("/(?P<count>[0-9]+)?d(?P<size>[0-9]+)/i", $part, $data);
27			if ($valid) {
28			if ((strlen($data["size"]) > 4) \|\| ($data["size"] > 9000)) {
29			throw new UncreatableDiceException("Only dice with a power level less than 9000 can be created.");
30			}
31			if (!$data["count"]) {
32			$data["count"] = 1;
33			}
34			for ($i = 0; $i < $data["count"]; $i++) {
35			$newDice[] = $this->newDiceOfSize($data["size"]);
36			}
37			}
38			return $newDice;
39			}
40
41			/**
42			* @param $size
43			* @return Dice
44			*/
45			private function newDiceOfSize($size)
46			{
47			if ($size == 0) {
48			return new ZeropointDice();
49			}
50			return new BasicDice($size);
51			}
52
53			/**
54			* @param array[]
55			* @return array
56			*/
57			private function flattenDiceSets($diceSets)
58			{
59			$dice = [];
60			foreach ($diceSets as $set) {
61			$dice = array_merge($dice, $set);
62			}
63			return $dice;
64			}
65			}
66

meadsteve / DiceApi

Push — master ( 6bb539...9dcb59 )

DiceGenerator::getDiceForPart() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like