Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
13 | class DiceFactoryCollectionSpec extends ObjectBehavior |
||
14 | { |
||
15 | function let(DiceFactory $factoryOne, DiceFactory $factoryTwo) |
||
19 | |||
20 | function it_is_initializable() |
||
24 | |||
25 | View Code Duplication | function it_doesnt_handle_types_not_handled_by_its_factories(DiceFactory $factoryOne, DiceFactory $factoryTwo) |
|
32 | |||
33 | View Code Duplication | function it_handles_types_if_one_factory_does(DiceFactory $factoryOne, DiceFactory $factoryTwo) |
|
40 | |||
41 | function it_delegates_construction_to_its_factories(DiceFactory $factoryOne, DiceFactory $factoryTwo) |
||
51 | |||
52 | function it_throws_an_exception_if_asked_to_build_dice_it_cant(DiceFactory $factoryOne, DiceFactory $factoryTwo) |
||
60 | } |
||
61 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.