DiceFactoryCollection::buildDice() - Code Metrics - Inspection of "pull out dice factory logic in to a collection" - meadsteve/DiceApi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bf0f99...8e98a1 )

by Steve

created 2016-12-19 09:40 UTC

DiceFactoryCollection::buildDice() A

↳ Parent: DiceFactoryCollection

Complexity

Conditions	3
Paths	3

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
c	0
b	0
f	0
rs	9.6666
cc	3
eloc	5
nc	3
nop	2

<?php

namespace MeadSteve\DiceApi\Dice\Factories;

use MeadSteve\DiceApi\Dice;
use MeadSteve\DiceApi\Dice\UncreatableDiceException;

class DiceFactoryCollection implements DiceFactory
{
    /**
     * @var DiceFactory[]
     */
    private $factories;

    public function __construct(array $factories)
    {
        $this->factories = $factories;
    }

    public function handlesType(string $type): bool
    {
        foreach ($this->factories as $factory) {
            if ($factory->handlesType($type)) {
                return true;
            }
        }
        return false;
    }

    /**
     * @param string $type
     * @param int $number
     * @return Dice[]
     */
    public function buildDice(string $type, int $number): array
    {
        foreach ($this->factories as $factory) {
            if ($factory->handlesType($type)) {
                return $factory->buildDice($type, $number);
            }
        }
        throw new UncreatableDiceException("No idea how to make a d{$type}");
    }
}


1			<?php
2
3			namespace MeadSteve\DiceApi\Dice\Factories;
4
5			use MeadSteve\DiceApi\Dice;
6			use MeadSteve\DiceApi\Dice\UncreatableDiceException;
7
8			class DiceFactoryCollection implements DiceFactory
9			{
10			/**
11			* @var DiceFactory[]
12			*/
13			private $factories;
14
15			public function __construct(array $factories)
16			{
17			$this->factories = $factories;
18			}
19
20			public function handlesType(string $type): bool
21			{
22			foreach ($this->factories as $factory) {
23			if ($factory->handlesType($type)) {
24			return true;
25			}
26			}
27			return false;
28			}
29
30			/**
31			* @param string $type
32			* @param int $number
33			* @return Dice[]
34			*/
35			public function buildDice(string $type, int $number): array
36			{
37			foreach ($this->factories as $factory) {
38			if ($factory->handlesType($type)) {
39			return $factory->buildDice($type, $number);
40			}
41			}
42			throw new UncreatableDiceException("No idea how to make a d{$type}");
43			}
44			}
45

meadsteve / DiceApi

Push — master ( bf0f99...8e98a1 )

DiceFactoryCollection::buildDice() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like