DiceGenerator::getDiceForPart() - Code Metrics - Inspection of "filter empty parts out of dice stings in generator" - meadsteve/DiceApi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 90b7b2...d5b357 )

by Steve

created 2015-11-25 15:43 UTC

DiceGenerator::getDiceForPart() A

↳ Parent: DiceGenerator

Complexity

Conditions	4
Paths	3

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	12
rs	9.2
cc	4
eloc	8
nc	3
nop	1

<?php

namespace MeadSteve\DiceApi\Dice;

use MeadSteve\DiceApi\BasicDice;
use MeadSteve\DiceApi\Dice;

class DiceGenerator
{
    public function diceFromUrlString($urlString)
    {
        $parts = explode("/", $urlString);
        $parts = array_filter($parts, function($part) {return $part !== "";});
        $diceSets = array_map([$this, 'getDiceForPart'], $parts);
        return $this->flattenDiceSets($diceSets);
    }

    /**
     * @param string $part
     * @return Dice[]
     */
    private function getDiceForPart($part)
    {
        $newDice = [];
        $data = $this->parseDiceString($part);
        if ((strlen($data["size"]) > 4) || ($data["size"] > 9000)) {
            throw new UncreatableDiceException("Only dice with a power level less than 9000 can be created.");
        }
        for ($i = 0; $i < $data["count"]; $i++) {
            $newDice[] = $this->newDiceOfSize($data["size"]);
        }
        return $newDice;
    }

    /**
     * @param $size
     * @return Dice
     */
    private function newDiceOfSize($size)
    {
        if ($size == 0) {
            return new ZeropointDice();
        }
        return new BasicDice($size);
    }

    /**
     * @param array[]
     * @return array
     */
    private function flattenDiceSets($diceSets)
    {
        $dice = [];
        foreach ($diceSets as $set) {
            $dice = array_merge($dice, $set);
        }
        return $dice;
    }

    /**
     * @param string $part
     * @return array
     */
    private function parseDiceString($part)
    {
        $data = [];
        $valid = preg_match("/(?P<count>[0-9]+)?d(?P<size>[0-9]+)/i", $part, $data);
        if (!$valid) {
            throw new UncreatableDiceException("Problem creating dice from incorrectly formated data: " + $part);
        }
        if (!$data["count"]) {
            $data["count"] = 1;
        }
        return $data;

    }
}


1			<?php
2
3			namespace MeadSteve\DiceApi\Dice;
4
5			use MeadSteve\DiceApi\BasicDice;
6			use MeadSteve\DiceApi\Dice;
7
8			class DiceGenerator
9			{
10			public function diceFromUrlString($urlString)
11			{
12			$parts = explode("/", $urlString);
13			$parts = array_filter($parts, function($part) {return $part !== "";});
14			$diceSets = array_map([$this, 'getDiceForPart'], $parts);
15			return $this->flattenDiceSets($diceSets);
16			}
17
18			/**
19			* @param string $part
20			* @return Dice[]
21			*/
22			private function getDiceForPart($part)
23			{
24			$newDice = [];
25			$data = $this->parseDiceString($part);
26			if ((strlen($data["size"]) > 4) \|\| ($data["size"] > 9000)) {
27			throw new UncreatableDiceException("Only dice with a power level less than 9000 can be created.");
28			}
29			for ($i = 0; $i < $data["count"]; $i++) {
30			$newDice[] = $this->newDiceOfSize($data["size"]);
31			}
32			return $newDice;
33			}
34
35			/**
36			* @param $size
37			* @return Dice
38			*/
39			private function newDiceOfSize($size)
40			{
41			if ($size == 0) {
42			return new ZeropointDice();
43			}
44			return new BasicDice($size);
45			}
46
47			/**
48			* @param array[]
49			* @return array
50			*/
51			private function flattenDiceSets($diceSets)
52			{
53			$dice = [];
54			foreach ($diceSets as $set) {
55			$dice = array_merge($dice, $set);
56			}
57			return $dice;
58			}
59
60			/**
61			* @param string $part
62			* @return array
63			*/
64			private function parseDiceString($part)
65			{
66			$data = [];
67			$valid = preg_match("/(?P<count>[0-9]+)?d(?P<size>[0-9]+)/i", $part, $data);
68			if (!$valid) {
69			throw new UncreatableDiceException("Problem creating dice from incorrectly formated data: " + $part);
70			}
71			if (!$data["count"]) {
72			$data["count"] = 1;
73			}
74			return $data;
75
76			}
77			}
78

meadsteve / DiceApi

Push — master ( 90b7b2...d5b357 )

DiceGenerator::getDiceForPart() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like