PhpBinaryReader\Type\Single::read()

Complexity

Conditions	5
Paths	5

Size

Total Lines	22
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	14
CRAP Score	5

Importance

Changes	1
Bugs	0	Features	1

<?php
    public function read(BinaryReader &$br, $length = null)
    {
        if (!$br->canReadBytes(4)) {
            throw new \OutOfBoundsException('Cannot read 4-bytes floating-point, it exceeds the boundary of the file');
        }

        $segment = $br->readFromHandle(4);

        if ($br->getCurrentBit() !== 0) {
            $data = unpack('N', $segment)[1];
            $data = $this->bitReader($br, $data);

            $endian = $br->getMachineByteOrder() === $br->getEndian() ? 'N' : 'V';

The strict comparison === seems to always evaluate to false as the types of $br->getMachineByteOrder() (integer) and $br->getEndian() (string) can never be identical. Maybe you want to use a loose comparison == instead?

            $segment = pack($endian, $data);
        } elseif ($br->getMachineByteOrder() !== $br->getEndian()) {

The strict comparison !== seems to always evaluate to true as the types of $br->getMachineByteOrder() (integer) and $br->getEndian() (string) can never be identical. Maybe you want to use a loose comparison != instead?

            $segment = pack('N', unpack('V', $segment)[1]);
        }

        $value = unpack('f', $segment)[1];

        return $value;
    }