PhpBinaryReader\Type\Single

Complexity

Total Complexity

6

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
B	read()	0	22	5
A	bitReader()	0	8	1

<?php

namespace PhpBinaryReader\Type;

use PhpBinaryReader\BinaryReader;

class Single implements TypeInterface
{
    /**
     * Returns a 4-bytes floating-point
     *
     * @param \PhpBinaryReader\BinaryReader $br
     * @param null $length
     *
     * @return float
     * @throws \OutOfBoundsException
     */
    public function read(BinaryReader &$br, $length = null)
    {
        if (!$br->canReadBytes(4)) {
            throw new \OutOfBoundsException('Cannot read 4-bytes floating-point, it exceeds the boundary of the file');
        }

        $segment = $br->readFromHandle(4);

        if ($br->getCurrentBit() !== 0) {
            $data = unpack('N', $segment)[1];
            $data = $this->bitReader($br, $data);

            $endian = $br->getMachineByteOrder() === $br->getEndian() ? 'N' : 'V';

The strict comparison === seems to always evaluate to false as the types of $br->getMachineByteOrder() (integer) and $br->getEndian() (string) can never be identical. Maybe you want to use a loose comparison == instead?

            $segment = pack($endian, $data);
        } elseif ($br->getMachineByteOrder() !== $br->getEndian()) {

The strict comparison !== seems to always evaluate to true as the types of $br->getMachineByteOrder() (integer) and $br->getEndian() (string) can never be identical. Maybe you want to use a loose comparison != instead?

            $segment = pack('N', unpack('V', $segment)[1]);
        }

        $value = unpack('f', $segment)[1];

        return $value;
    }

    /**
     * @param \PhpBinaryReader\BinaryReader $br
     * @param int $data
     *
     * @return int
     */
    private function bitReader(BinaryReader $br, $data)
    {
        $mask = 0x7FFFFFFF >> ($br->getCurrentBit() - 1);
        $value = (($data >> (8 - $br->getCurrentBit())) & $mask) | ($br->getNextByte() << (24 + $br->getCurrentBit()));
        $br->setNextByte($data & 0xFF);

        return $value;
    }
}