ScopeController::actionDelete() - Code Metrics - Inspection of "update readme" - mdeschamps-ibitux/yii2-oauth2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/mysqlSupport ( 574cbc...a33411 )

by Maxime

created 2018-07-09 08:56 UTC

ScopeController::actionDelete() A

↳ Parent: ScopeController

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
c	0
b	0
f	0
rs	9.6333
cc	3
nc	3
nop	1

<?php
/**
 * ScopeController.php
 *
 * PHP version 5.6+
 *
 * @author Philippe Gaultier <[email protected]>
 * @copyright 2010-2017 Philippe Gaultier
 * @license http://www.sweelix.net/license license
 * @version 1.2.0
 * @link http://www.sweelix.net
 * @package sweelix\oauth2\server\commands
 */

namespace sweelix\oauth2\server\commands;

use yii\console\Controller;
use Yii;
use yii\console\ExitCode;

/**
 * Manage oauth scopes
 *
 * @author Philippe Gaultier <[email protected]>
 * @copyright 2010-2017 Philippe Gaultier
 * @license http://www.sweelix.net/license license
 * @version 1.2.0
 * @link http://www.sweelix.net
 * @package sweelix\oauth2\server\commands
 * @since 1.0.0
 */
class ScopeController extends Controller
{

    public $isDefault = false;
    public $definition;

    /**
     * @inheritdoc
     */
    public function options($actionID)
    {
        return [
            // 'id',
            'isDefault',
            'definition',
        ];
    }

    /**
     * Create new Oauth scope
     * @param $id
     * @return int
     * @throws \yii\base\InvalidConfigException
     * @throws \yii\base\UnknownClassException
     * @since 1.0.0
     */
    public function actionCreate($id)
    {
        $scope = Yii::createObject('sweelix\oauth2\server\interfaces\ScopeModelInterface');
        /* @var \sweelix\oauth2\server\interfaces\ScopeModelInterface $scope */
        $scope->id = $id;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $scope->isDefault = (bool)$this->isDefault;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $scope->definition = $this->definition;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        if ($scope->save() === true) {
            $this->stdout('Scope created :' . "\n");
            $this->stdout(' - id: ' . $scope->id . "\n");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $this->stdout(' - isDefault: ' . ($scope->isDefault ? 'Yes' : 'No') . "\n");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $this->stdout(' - definition: ' . $scope->definition . "\n");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            return ExitCode::OK;
        } else {
            $this->stdout('Scope cannot be created.' . "\n");
            return ExitCode::UNSPECIFIED_ERROR;
        }
    }

    /**
     * Update Oauth Scope
     * @param $id
     * @return int
     * @throws \yii\base\InvalidConfigException
     * @throws \yii\base\UnknownClassException
     */
    public function actionUpdate($id)
    {
        $scope = Yii::createObject('sweelix\oauth2\server\interfaces\ScopeModelInterface');
        $scopeClass = get_class($scope);
        /* @var \sweelix\oauth2\server\interfaces\ScopeModelInterface $scope */
        $scope = $scopeClass::findOne($id);
        if ($scope !== null) {
            $scope->isDefault = $this->isDefault;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $scope->definition = $this->definition;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            if ($scope->save() === true) {
                $this->stdout('Scope updated :' . "\n");
                $this->stdout(' - id: ' . $scope->id . "\n");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                $this->stdout(' - isDefault: ' . ($scope->isDefault ? 'Yes' : 'No') . "\n");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                $this->stdout(' - definition: ' . $scope->definition . "\n");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                return ExitCode::OK;
            } else {
                $this->stdout('Scope ' . $id . ' cannot be updated' . "\n");
                return ExitCode::UNSPECIFIED_ERROR;
            }
        } else {
            $this->stdout('Scope ' . $id . ' does not exist' . "\n");
            return ExitCode::UNSPECIFIED_ERROR;
        }
    }

    /**
     * Delete Oauth Scope
     * @param $id
     * @return int
     * @throws \yii\base\InvalidConfigException
     * @throws \yii\base\UnknownClassException
     */
    public function actionDelete($id)
    {
        $scope = Yii::createObject('sweelix\oauth2\server\interfaces\ScopeModelInterface');
        $scopeClass = get_class($scope);
        /* @var \sweelix\oauth2\server\interfaces\ScopeModelInterface $scope */
        $scope = $scopeClass::findOne($id);
        if ($scope !== null) {
            if ($scope->delete() === true) {
                $this->stdout('Scope ' . $id . ' deleted' . "\n");
                return ExitCode::OK;
            } else {
                $this->stdout('Scope ' . $id . ' cannot be deleted' . "\n");
                return ExitCode::UNSPECIFIED_ERROR;
            }
        } else {
            $this->stdout('Scope ' . $id . ' does not exist' . "\n");
            return ExitCode::UNSPECIFIED_ERROR;
        }
    }
}

1			<?php
2			/**
3			* ScopeController.php
4			*
5			* PHP version 5.6+
6			*
7			* @author Philippe Gaultier <[email protected]>
8			* @copyright 2010-2017 Philippe Gaultier
9			* @license http://www.sweelix.net/license license
10			* @version 1.2.0
11			* @link http://www.sweelix.net
12			* @package sweelix\oauth2\server\commands
13			*/
14
15			namespace sweelix\oauth2\server\commands;
16
17			use yii\console\Controller;
18			use Yii;
19			use yii\console\ExitCode;
20
21			/**
22			* Manage oauth scopes
23			*
24			* @author Philippe Gaultier <[email protected]>
25			* @copyright 2010-2017 Philippe Gaultier
26			* @license http://www.sweelix.net/license license
27			* @version 1.2.0
28			* @link http://www.sweelix.net
29			* @package sweelix\oauth2\server\commands
30			* @since 1.0.0
31			*/
32			class ScopeController extends Controller
33			{
34
35			public $isDefault = false;
36			public $definition;
37
38			/**
39			* @inheritdoc
40			*/
41			public function options($actionID)
42			{
43			return [
44			// 'id',
45			'isDefault',
46			'definition',
47			];
48			}
49
50			/**
51			* Create new Oauth scope
52			* @param $id
53			* @return int
54			* @throws \yii\base\InvalidConfigException
55			* @throws \yii\base\UnknownClassException
56			* @since 1.0.0
57			*/
58			public function actionCreate($id)
59			{
60			$scope = Yii::createObject('sweelix\oauth2\server\interfaces\ScopeModelInterface');
61			/* @var \sweelix\oauth2\server\interfaces\ScopeModelInterface $scope */
62			$scope->id = $id;
			0 ignored issues – show Bug introduced 2018-06-26 13:45 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `sweelix\oauth2\server\in...ces\ScopeModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
63			$scope->isDefault = (bool)$this->isDefault;
			0 ignored issues – show Bug introduced 2018-06-26 13:45 UTC by Report Bug Copy Issue Report Accessing `isDefault` on the interface `sweelix\oauth2\server\in...ces\ScopeModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
64			$scope->definition = $this->definition;
			0 ignored issues – show Bug introduced 2018-06-26 13:45 UTC by Report Bug Copy Issue Report Accessing `definition` on the interface `sweelix\oauth2\server\in...ces\ScopeModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
65			if ($scope->save() === true) {
66			$this->stdout('Scope created :' . "\n");
67			$this->stdout(' - id: ' . $scope->id . "\n");
			0 ignored issues – show Bug introduced 2018-06-26 13:45 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `sweelix\oauth2\server\in...ces\ScopeModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
68			$this->stdout(' - isDefault: ' . ($scope->isDefault ? 'Yes' : 'No') . "\n");
			0 ignored issues – show Bug introduced 2018-06-26 13:45 UTC by Report Bug Copy Issue Report Accessing `isDefault` on the interface `sweelix\oauth2\server\in...ces\ScopeModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
69			$this->stdout(' - definition: ' . $scope->definition . "\n");
			0 ignored issues – show Bug introduced 2018-06-26 13:45 UTC by Report Bug Copy Issue Report Accessing `definition` on the interface `sweelix\oauth2\server\in...ces\ScopeModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
70			return ExitCode::OK;
71			} else {
72			$this->stdout('Scope cannot be created.' . "\n");
73			return ExitCode::UNSPECIFIED_ERROR;
74			}
75			}
76
77			/**
78			* Update Oauth Scope
79			* @param $id
80			* @return int
81			* @throws \yii\base\InvalidConfigException
82			* @throws \yii\base\UnknownClassException
83			*/
84			public function actionUpdate($id)
85			{
86			$scope = Yii::createObject('sweelix\oauth2\server\interfaces\ScopeModelInterface');
87			$scopeClass = get_class($scope);
88			/* @var \sweelix\oauth2\server\interfaces\ScopeModelInterface $scope */
89			$scope = $scopeClass::findOne($id);
90			if ($scope !== null) {
91			$scope->isDefault = $this->isDefault;
			0 ignored issues – show Bug introduced 2018-07-09 09:34 UTC by Report Bug Copy Issue Report Accessing `isDefault` on the interface `sweelix\oauth2\server\in...ces\ScopeModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
92			$scope->definition = $this->definition;
			0 ignored issues – show Bug introduced 2018-07-09 09:34 UTC by Report Bug Copy Issue Report Accessing `definition` on the interface `sweelix\oauth2\server\in...ces\ScopeModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
93			if ($scope->save() === true) {
94			$this->stdout('Scope updated :' . "\n");
95			$this->stdout(' - id: ' . $scope->id . "\n");
			0 ignored issues – show Bug introduced 2018-07-09 09:34 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `sweelix\oauth2\server\in...ces\ScopeModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
96			$this->stdout(' - isDefault: ' . ($scope->isDefault ? 'Yes' : 'No') . "\n");
			0 ignored issues – show Bug introduced 2018-07-09 09:34 UTC by Report Bug Copy Issue Report Accessing `isDefault` on the interface `sweelix\oauth2\server\in...ces\ScopeModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
97			$this->stdout(' - definition: ' . $scope->definition . "\n");
			0 ignored issues – show Bug introduced 2018-07-09 09:34 UTC by Report Bug Copy Issue Report Accessing `definition` on the interface `sweelix\oauth2\server\in...ces\ScopeModelInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
98			return ExitCode::OK;
99			} else {
100			$this->stdout('Scope ' . $id . ' cannot be updated' . "\n");
101			return ExitCode::UNSPECIFIED_ERROR;
102			}
103			} else {
104			$this->stdout('Scope ' . $id . ' does not exist' . "\n");
105			return ExitCode::UNSPECIFIED_ERROR;
106			}
107			}
108
109			/**
110			* Delete Oauth Scope
111			* @param $id
112			* @return int
113			* @throws \yii\base\InvalidConfigException
114			* @throws \yii\base\UnknownClassException
115			*/
116			public function actionDelete($id)
117			{
118			$scope = Yii::createObject('sweelix\oauth2\server\interfaces\ScopeModelInterface');
119			$scopeClass = get_class($scope);
120			/* @var \sweelix\oauth2\server\interfaces\ScopeModelInterface $scope */
121			$scope = $scopeClass::findOne($id);
122			if ($scope !== null) {
123			if ($scope->delete() === true) {
124			$this->stdout('Scope ' . $id . ' deleted' . "\n");
125			return ExitCode::OK;
126			} else {
127			$this->stdout('Scope ' . $id . ' cannot be deleted' . "\n");
128			return ExitCode::UNSPECIFIED_ERROR;
129			}
130			} else {
131			$this->stdout('Scope ' . $id . ' does not exist' . "\n");
132			return ExitCode::UNSPECIFIED_ERROR;
133			}
134			}
135			}

mdeschamps-ibitux / yii2-oauth2

Push — feature/mysqlSupport ( 574cbc...a33411 )

ScopeController::actionDelete() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like