StatusAction::executeApiAction() - Code Metrics - Inspection of "113bb8bd1ae298bcc882542aa066edf6bfecd775" - mdaniels5757/waca - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — newinternal (113bb8)

by Michael

created 2020-04-28 14:34 UTC

StatusAction::executeApiAction() A

↳ Parent: StatusAction

Complexity

Conditions	2
Paths	2

Size

Total Lines	62
Code Lines	47

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
eloc	47
c	0
b	0
f	0
dl	0
loc	62
ccs	0
cts	53
cp	0
rs	9.1563
cc	2
nc	2
nop	1
crap	6

How to fix Long Method

<?php
/******************************************************************************
 * Wikipedia Account Creation Assistance tool                                 *
 *                                                                            *
 * All code in this file is released into the public domain by the ACC        *
 * Development Team. Please see team.json for a list of contributors.         *
 ******************************************************************************/

namespace Waca\API\Actions;

use DOMElement;
use Waca\API\IApiAction;
use Waca\Tasks\ApiPageBase;

/**
 * API Count action
 */
class StatusAction extends ApiPageBase implements IApiAction
{
    public function executeApiAction(DOMElement $apiDocument)
    {
        $statusElement = $this->document->createElement("status");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $apiDocument->appendChild($statusElement);

        $query = $this->getDatabase()->prepare(<<<SQL
            SELECT /* Api/StatusAction */ COUNT(*) AS count
            FROM request
            WHERE
                status = :pstatus
                AND emailconfirm = 'Confirmed';
SQL
        );

        $availableRequestStates = $this->getSiteConfiguration()->getRequestStates();

        foreach ($availableRequestStates as $key => $value) {
            $query->bindValue(":pstatus", $key);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $query->execute();
            $sus = $query->fetchColumn();
            $statusElement->setAttribute($value['api'], $sus);
            $query->closeCursor();
        }

        $query = $this->getDatabase()->prepare(<<<SQL
            SELECT /* Api/StatusAction */ COUNT(*) AS count
            FROM ban
            WHERE
                (duration > UNIX_TIMESTAMP() OR duration = -1)
                AND active = 1;
SQL
        );

        $query->execute();
        $sus = $query->fetchColumn();
        $statusElement->setAttribute("bans", $sus);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $query->closeCursor();

        $query = $this->getDatabase()->prepare(<<<SQL
SELECT /* Api/StatusAction */ COUNT(*) AS count
FROM user WHERE status = :ulevel;
SQL
        );
        $query->bindValue(":ulevel", "Admin");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $query->execute();
        $sus = $query->fetchColumn();
        $statusElement->setAttribute("useradmin", $sus);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $query->closeCursor();

        $query->bindValue(":ulevel", "User");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $query->execute();
        $sus = $query->fetchColumn();
        $statusElement->setAttribute("user", $sus);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $query->closeCursor();

        $query->bindValue(":ulevel", "New");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $query->execute();
        $sus = $query->fetchColumn();
        $statusElement->setAttribute("usernew", $sus);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $query->closeCursor();

        return $apiDocument;
    }

}



1			<?php
2			/******************************************************************************
3			* Wikipedia Account Creation Assistance tool *
4			* *
5			* All code in this file is released into the public domain by the ACC *
6			* Development Team. Please see team.json for a list of contributors. *
7			******************************************************************************/
8
9			namespace Waca\API\Actions;
10
11			use DOMElement;
12			use Waca\API\IApiAction;
13			use Waca\Tasks\ApiPageBase;
14
15			/**
16			* API Count action
17			*/
18			class StatusAction extends ApiPageBase implements IApiAction
19			{
20			public function executeApiAction(DOMElement $apiDocument)
21			{
22			$statusElement = $this->document->createElement("status");
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `status` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
23			$apiDocument->appendChild($statusElement);
24
25			$query = $this->getDatabase()->prepare(<<<SQL
26			SELECT /* Api/StatusAction / COUNT() AS count
27			FROM request
28			WHERE
29			status = :pstatus
30			AND emailconfirm = 'Confirmed';
31			SQL
32			);
33
34			$availableRequestStates = $this->getSiteConfiguration()->getRequestStates();
35
36			foreach ($availableRequestStates as $key => $value) {
37			$query->bindValue(":pstatus", $key);
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `:pstatus` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
38			$query->execute();
39			$sus = $query->fetchColumn();
40			$statusElement->setAttribute($value['api'], $sus);
41			$query->closeCursor();
42			}
43
44			$query = $this->getDatabase()->prepare(<<<SQL
45			SELECT /* Api/StatusAction / COUNT() AS count
46			FROM ban
47			WHERE
48			(duration > UNIX_TIMESTAMP() OR duration = -1)
49			AND active = 1;
50			SQL
51			);
52
53			$query->execute();
54			$sus = $query->fetchColumn();
55			$statusElement->setAttribute("bans", $sus);
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `bans` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
56			$query->closeCursor();
57
58			$query = $this->getDatabase()->prepare(<<<SQL
59			SELECT /* Api/StatusAction / COUNT() AS count
60			FROM user WHERE status = :ulevel;
61			SQL
62			);
63			$query->bindValue(":ulevel", "Admin");
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `:ulevel` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `Admin` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
64			$query->execute();
65			$sus = $query->fetchColumn();
66			$statusElement->setAttribute("useradmin", $sus);
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `useradmin` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
67			$query->closeCursor();
68
69			$query->bindValue(":ulevel", "User");
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `:ulevel` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `User` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
70			$query->execute();
71			$sus = $query->fetchColumn();
72			$statusElement->setAttribute("user", $sus);
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `user` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
73			$query->closeCursor();
74
75			$query->bindValue(":ulevel", "New");
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `:ulevel` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `New` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
76			$query->execute();
77			$sus = $query->fetchColumn();
78			$statusElement->setAttribute("usernew", $sus);
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `usernew` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
79			$query->closeCursor();
80
81			return $apiDocument;
82			}
			0 ignored issues – show Coding Style introduced 2020-04-26 01:41 UTC by Report Bug Copy Issue Report Expected //end executeApiAction() Loading history...
83			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end class Loading history...
84

mdaniels5757 / waca

Branch — newinternal (113bb8)

StatusAction::executeApiAction() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like