@@ -91,8 +91,7 @@ discard block |
||
| 91 | 91 | // all over the rest of the code |
| 92 | 92 | if ($this->hasActiveTransaction) { |
| 93 | 93 | return false; |
| 94 | - } |
|
| 95 | - else { |
|
| 94 | + } else { |
|
| 96 | 95 | // set the transaction isolation level for every transaction. |
| 97 | 96 | $this->exec("SET TRANSACTION ISOLATION LEVEL SERIALIZABLE;"); |
| 98 | 97 | |
@@ -146,8 +145,7 @@ discard block |
||
| 146 | 145 | // TODO: yuk. |
| 147 | 146 | if (defined("PUBLICMODE")) { |
| 148 | 147 | BootstrapSkin::displayPublicFooter(); |
| 149 | - } |
|
| 150 | - else { |
|
| 148 | + } else { |
|
| 151 | 149 | BootstrapSkin::displayInternalFooter(); |
| 152 | 150 | } |
| 153 | 151 | |
@@ -31,12 +31,10 @@ discard block |
||
| 31 | 31 | if ($statement->execute()) { |
| 32 | 32 | $this->isNew = false; |
| 33 | 33 | $this->id = $this->dbObject->lastInsertId(); |
| 34 | - } |
|
| 35 | - else { |
|
| 34 | + } else { |
|
| 36 | 35 | throw new Exception($statement->errorInfo()); |
| 37 | 36 | } |
| 38 | - } |
|
| 39 | - else { |
|
| 37 | + } else { |
|
| 40 | 38 | throw new Exception("You shouldn't be doing this..."); |
| 41 | 39 | } |
| 42 | 40 | } |
@@ -250,8 +248,7 @@ discard block |
||
| 250 | 248 | { |
| 251 | 249 | if ($ban->getDuration() == -1) { |
| 252 | 250 | $duration = "indefinitely"; |
| 253 | - } |
|
| 254 | - else { |
|
| 251 | + } else { |
|
| 255 | 252 | $duration = "until " . date("F j, Y, g:i a", $ban->getDuration()); |
| 256 | 253 | } |
| 257 | 254 | |
@@ -154,8 +154,7 @@ discard block |
||
| 154 | 154 | $smarty->display("usermanagement/changelevel-reason.tpl"); |
| 155 | 155 | BootstrapSkin::displayInternalFooter(); |
| 156 | 156 | die(); |
| 157 | - } |
|
| 158 | - else { |
|
| 157 | + } else { |
|
| 159 | 158 | $user->demote($_POST['reason']); |
| 160 | 159 | |
| 161 | 160 | BootstrapSkin::displayAlertBox( |
@@ -198,8 +197,7 @@ discard block |
||
| 198 | 197 | false); |
| 199 | 198 | BootstrapSkin::displayInternalFooter(); |
| 200 | 199 | die(); |
| 201 | - } |
|
| 202 | - elseif (!isset($_POST['reason'])) { |
|
| 200 | + } elseif (!isset($_POST['reason'])) { |
|
| 203 | 201 | global $smarty; |
| 204 | 202 | $smarty->assign("user", $user); |
| 205 | 203 | $smarty->assign("status", "Suspended"); |
@@ -207,8 +205,7 @@ discard block |
||
| 207 | 205 | $smarty->display("usermanagement/changelevel-reason.tpl"); |
| 208 | 206 | BootstrapSkin::displayInternalFooter(); |
| 209 | 207 | die(); |
| 210 | - } |
|
| 211 | - else { |
|
| 208 | + } else { |
|
| 212 | 209 | $user->suspend($_POST['reason']); |
| 213 | 210 | |
| 214 | 211 | Notification::userSuspended($user, $_POST['reason']); |
@@ -301,8 +298,7 @@ discard block |
||
| 301 | 298 | $smarty->display("usermanagement/changelevel-reason.tpl"); |
| 302 | 299 | BootstrapSkin::displayInternalFooter(); |
| 303 | 300 | die(); |
| 304 | - } |
|
| 305 | - else { |
|
| 301 | + } else { |
|
| 306 | 302 | $user->decline($_POST['reason']); |
| 307 | 303 | |
| 308 | 304 | Notification::userDeclined($user, $_POST['reason']); |
@@ -346,8 +342,7 @@ discard block |
||
| 346 | 342 | $smarty->display("usermanagement/renameuser.tpl"); |
| 347 | 343 | BootstrapSkin::displayInternalFooter(); |
| 348 | 344 | die(); |
| 349 | - } |
|
| 350 | - else { |
|
| 345 | + } else { |
|
| 351 | 346 | if (!isset($_POST['newname']) || trim($_POST['newname']) == "") { |
| 352 | 347 | BootstrapSkin::displayAlertBox("The new username cannot be empty.", "alert-error", "Error", true, false); |
| 353 | 348 | BootstrapSkin::displayInternalFooter(); |
@@ -429,8 +424,7 @@ discard block |
||
| 429 | 424 | global $smarty; |
| 430 | 425 | $smarty->assign("user", $user); |
| 431 | 426 | $smarty->display("usermanagement/edituser.tpl"); |
| 432 | - } |
|
| 433 | - else { |
|
| 427 | + } else { |
|
| 434 | 428 | $database = gGetDb(); |
| 435 | 429 | if (!$database->beginTransaction()) { |
| 436 | 430 | BootstrapSkin::displayAlertBox( |
@@ -19,7 +19,7 @@ |
||
| 19 | 19 | $this->e = null; |
| 20 | 20 | } |
| 21 | 21 | |
| 22 | - public function testFormatAsUsername() { |
|
| 22 | + public function testFormatAsUsername() { |
|
| 23 | 23 | // Happy path |
| 24 | 24 | $this->assertEquals($this->e->formatAsUsername("this"), "This"); |
| 25 | 25 | $this->assertEquals($this->e->formatAsUsername("1this"), "1this"); |
@@ -19,7 +19,8 @@ |
||
| 19 | 19 | $this->e = null; |
| 20 | 20 | } |
| 21 | 21 | |
| 22 | - public function testFormatAsUsername() { |
|
| 22 | + public function testFormatAsUsername() |
|
| 23 | + { |
|
| 23 | 24 | // Happy path |
| 24 | 25 | $this->assertEquals($this->e->formatAsUsername("this"), "This"); |
| 25 | 26 | $this->assertEquals($this->e->formatAsUsername("1this"), "1this"); |