RequestValidationHelperTest::testValidateGoodName() - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/master'" - mdaniels5757/waca - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c435d5...c435d5 )

by Michael

created 2020-05-08 15:55 UTC

testValidateGoodName() A

↳ Parent: RequestValidationHelperTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	1
eloc	3
c	2
b	0
f	0
nc	1
nop	0
dl	0
loc	10
rs	10

<?php

use PHPUnit\Framework\TestCase;
filter:
    dependency_paths: ["lib/*"]

class RequestValidationHelperTest extends TestCase
namespace YourVendor;

class YourClass { }
{
	private $request;

	public function setUp(): void
	{
		$this->request = new Request();
		$this->request->setName("TestName");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		$this->request->setEmail("[email protected]");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		$this->request->setIp("1.2.3.4");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}


	public function testValidateGoodName()
	{
		// arrange
		$validationHelper = new RequestValidationHelper(new MockBanHelper(), $this->request, $this->request->getEmail());

		// act
		$result = $validationHelper->validateName();

		// assert
		$this->assertEmpty($result);
	}

}



1			<?php
2
3			use PHPUnit\Framework\TestCase;
			0 ignored issues – show Bug introduced 2020-04-23 22:44 UTC by Report Bug Copy Issue Report The type `PHPUnit\Framework\TestCase` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
4
5			class RequestValidationHelperTest extends TestCase
			0 ignored issues – show Coding Style Compatibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
6			{
7			private $request;
8
9			public function setUp(): void
10			{
11			$this->request = new Request();
12			$this->request->setName("TestName");
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `TestName` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
13			$this->request->setEmail("[email protected]");
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `[email protected]` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
14			$this->request->setIp("1.2.3.4");
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `1.2.3.4` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
15			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end setUp() Loading history...
16
17			public function testValidateGoodName()
18			{
19			// arrange
20			$validationHelper = new RequestValidationHelper(new MockBanHelper(), $this->request, $this->request->getEmail());
21
22			// act
23			$result = $validationHelper->validateName();
24
25			// assert
26			$this->assertEmpty($result);
27			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end testValidateGoodName() Loading history...
28			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end class Loading history...
29

mdaniels5757 / waca

Push — master ( c435d5...c435d5 )

testValidateGoodName() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like