HttpHelper::post() - Code Metrics - Inspection of "fix" - mdaniels5757/waca - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — rbac ( be68b4...52c28b )

by Michael

created 2020-04-26 02:29 UTC

HttpHelper::post() A

↳ Parent: HttpHelper

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
eloc	9
c	0
b	0
f	0
dl	0
loc	18
ccs	0
cts	12
cp	0
rs	9.9666
cc	2
nc	2
nop	3
crap	6

<?php
/******************************************************************************
 * Wikipedia Account Creation Assistance tool                                 *
 *                                                                            *
 * All code in this file is released into the public domain by the ACC        *
 * Development Team. Please see team.json for a list of contributors.         *
 ******************************************************************************/

namespace Waca\Helpers;

use Waca\Exceptions\CurlException;

class HttpHelper
{
    private $curlHandle;

    /**
     * HttpHelper constructor.
     *
     * @param string  $userAgent
     * @param boolean $disableVerifyPeer
     */
    public function __construct($userAgent, $disableVerifyPeer)
    {
        $this->curlHandle = curl_init();

        curl_setopt($this->curlHandle, CURLOPT_RETURNTRANSFER, true);
        curl_setopt(/** @scrutinizer ignore-type */ $this->curlHandle, CURLOPT_RETURNTRANSFER, true);
        curl_setopt($this->curlHandle, CURLOPT_USERAGENT, $userAgent);
        curl_setopt($this->curlHandle, CURLOPT_FAILONERROR, true);

        if ($disableVerifyPeer) {
            curl_setopt($this->curlHandle, CURLOPT_SSL_VERIFYPEER, false);
        }
    }


    public function __destruct()
    {
        curl_close($this->curlHandle);
        curl_close(/** @scrutinizer ignore-type */ $this->curlHandle);
    }


    /**
     * Fetches the content of a URL, with an optional parameter set.
     *
     * @param string     $url        The URL to fetch.
     * @param null|array $parameters Key/value pair of GET parameters to add to the request.
     *                               Null lets you handle it yourself.
     *
     * @param array      $headers
     *
     * @return string
     * @throws CurlException
     */
    public function get($url, $parameters = null, $headers = array())

    {
        if ($parameters !== null && is_array($parameters)) {
            $getString = '?' . http_build_query($parameters);
            $url .= $getString;
        }

        curl_setopt($this->curlHandle, CURLOPT_URL, $url);
        curl_setopt(/** @scrutinizer ignore-type */ $this->curlHandle, CURLOPT_URL, $url);

        // Make sure we're doing a GET
        curl_setopt($this->curlHandle, CURLOPT_POST, false);

        curl_setopt($this->curlHandle, CURLOPT_HTTPHEADER, $headers);

        $result = curl_exec($this->curlHandle);
        $result = curl_exec(/** @scrutinizer ignore-type */ $this->curlHandle);

        if ($result === false) {
            $error = curl_error($this->curlHandle);
            $error = curl_error(/** @scrutinizer ignore-type */ $this->curlHandle);
            throw new CurlException('Remote request failed with error ' . $error);
        }

        return $result;

    }


    /**
     * Posts data to a URL
     *
     * @param string $url        The URL to fetch.
     * @param array  $parameters Key/value pair of POST parameters to add to the request.
     * @param array  $headers
     *
     * @return string
     * @throws CurlException
     */
    public function post($url, $parameters, $headers = array())

    {
        curl_setopt($this->curlHandle, CURLOPT_URL, $url);
        curl_setopt(/** @scrutinizer ignore-type */ $this->curlHandle, CURLOPT_URL, $url);

        // Make sure we're doing a POST
        curl_setopt($this->curlHandle, CURLOPT_POST, true);
        curl_setopt($this->curlHandle, CURLOPT_POSTFIELDS, http_build_query($parameters));

        curl_setopt($this->curlHandle, CURLOPT_HTTPHEADER, $headers);

        $result = curl_exec($this->curlHandle);
        $result = curl_exec(/** @scrutinizer ignore-type */ $this->curlHandle);

        if ($result === false) {
            $error = curl_error($this->curlHandle);
            $error = curl_error(/** @scrutinizer ignore-type */ $this->curlHandle);
            throw new CurlException('Remote request failed with error ' . $error);
        }

        return $result;

    }


    /**
     * @return string
     */
    public function getError()
    {
        return curl_error($this->curlHandle);
        return curl_error(/** @scrutinizer ignore-type */ $this->curlHandle);
    }

}


mdaniels5757 / waca

Push — rbac ( be68b4...52c28b )

HttpHelper::post() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like