CommunityUser::getWelcomeTemplate() - Code Metrics - Inspection of "fix" - mdaniels5757/waca - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — rbac ( be68b4...52c28b )

by Michael

created 2020-04-26 02:29 UTC

CommunityUser::getWelcomeTemplate() A

↳ Parent: CommunityUser

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
eloc	1
c	0
b	0
f	0
dl	0
loc	3
ccs	0
cts	3
cp	0
rs	10
cc	1
nc	1
nop	0
crap	2

<?php
/******************************************************************************
 * Wikipedia Account Creation Assistance tool                                 *
 *                                                                            *
 * All code in this file is released into the public domain by the ACC        *
 * Development Team. Please see team.json for a list of contributors.         *
 ******************************************************************************/

namespace Waca\DataObjects;

use DateTime;
use Waca\IdentificationVerifier;

/**
 * User data object
 */
class CommunityUser extends User
{
    public function getId()
    {
        return -1;
    }


    public function save()
    {
        // Do nothing
    }


    public function authenticate($password)
    {
        // Impossible to log in as this user
        return false;
    }


    #region properties

    /**
     * @return string
     */
    public function getUsername()
    {
        global $communityUsername;
function myFunction($a, $b) {
    // Do something
}

        return $communityUsername;
    }


    public function setUsername($username)
    {
    }


    /**
     * @return string
     */
    public function getEmail()
    {
        global $cDataClearEmail;
function myFunction($a, $b) {
    // Do something
}

        return $cDataClearEmail;
    }


    public function setEmail($email)
    {
    }


    public function setPassword($password)
    {
    }


    public function getStatus()
    {
        return "Community";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }


    public function getOnWikiName()
    {
        return "127.0.0.1";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }


    public function getStoredOnWikiName()
    {
        return $this->getOnWikiName();
    }


    public function setOnWikiName($onWikiName)
    {
    }


    public function getWelcomeSig()
    {
        return null;
    }


    public function setWelcomeSig($welcomeSig)
    {
    }


    public function getLastActive()
    {
        $now = new DateTime();

        return $now->format("Y-m-d H:i:s");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }


    public function getForceLogout()
    {
        return true;
    }


    public function setForceLogout($forceLogout)
    {
    }


    /**
     * @param string $status
     */
    public function setStatus($status)
    {
    }


    public function getWelcomeTemplate()
    {
        return 0;
    }


    public function setWelcomeTemplate($welcomeTemplate)
    {
    }


    public function getAbortPref()
    {
        return 0;
    }


    public function setAbortPref($abortPreference)
    {
    }


    public function getConfirmationDiff()
    {
        return null;
    }


    public function setConfirmationDiff($confirmationDiff)
    {
    }


    public function getEmailSig()
    {
        return null;
    }


    public function setEmailSig($emailSignature)
    {
    }


    #endregion

    #region user access checks

    public function isIdentified(IdentificationVerifier $iv)
    {
        return false;
    }


    public function isSuspended()
    {
        return false;
    }


    public function isNewUser()
    {
        return false;
    }


    public function isDeclined()
    {
        return false;
    }


    public function isCommunityUser()
    {
        return true;
    }


    #endregion 

    #region OAuth

    public function getOAuthIdentity($useCached = false)

    {
        return null;
    }


    public function isOAuthLinked()
    {
        return false;
    }


    public function oauthCanUse()
    {
        return false;
    }


    public function oauthCanEdit()
    {
        return false;
    }


    public function oauthCanCreateAccount()
    {
        return false;
    }


    protected function oauthCanCheckUser()
    {
        return false;
    }


    #endregion

    public function getApprovalDate()
    {
        $data = DateTime::createFromFormat("Y-m-d H:i:s", "1970-01-01 00:00:00");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        return $data;
    }

}



Push — rbac ( be68b4...52c28b )

CommunityUser::getWelcomeTemplate() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/******************************************************************************
3			* Wikipedia Account Creation Assistance tool *
4			* *
5			* All code in this file is released into the public domain by the ACC *
6			* Development Team. Please see team.json for a list of contributors. *
7			******************************************************************************/
8
9			namespace Waca\DataObjects;
10
11			use DateTime;
12			use Waca\IdentificationVerifier;
13
14			/**
15			* User data object
16			*/
17			class CommunityUser extends User
18			{
19			public function getId()
20			{
21			return -1;
22			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end getId() Loading history...
23
24			public function save()
25			{
26			// Do nothing
27			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end save() Loading history...
28
29			public function authenticate($password)
30			{
31			// Impossible to log in as this user
32			return false;
33			}
			0 ignored issues – show Coding Style introduced 2020-04-26 01:41 UTC by Report Bug Copy Issue Report Expected //end authenticate() Loading history...
34
35			#region properties
36
37			/**
38			* @return string
39			*/
40			public function getUsername()
41			{
42			global $communityUsername;
			0 ignored issues – show Compatibility Best Practice introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
43
44			return $communityUsername;
45			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end getUsername() Loading history...
46
47			public function setUsername($username)
48			{
49			}
			0 ignored issues – show Coding Style introduced 2020-04-26 01:41 UTC by Report Bug Copy Issue Report Expected //end setUsername() Loading history...
50
51			/**
52			* @return string
53			*/
54			public function getEmail()
55			{
56			global $cDataClearEmail;
			0 ignored issues – show Compatibility Best Practice introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
57
58			return $cDataClearEmail;
59			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end getEmail() Loading history...
60
61			public function setEmail($email)
62			{
63			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end setEmail() Loading history...
64
65			public function setPassword($password)
66			{
67			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end setPassword() Loading history...
68
69			public function getStatus()
70			{
71			return "Community";
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `Community` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
72			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end getStatus() Loading history...
73
74			public function getOnWikiName()
75			{
76			return "127.0.0.1";
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `127.0.0.1` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
77			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end getOnWikiName() Loading history...
78
79			public function getStoredOnWikiName()
80			{
81			return $this->getOnWikiName();
82			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end getStoredOnWikiName() Loading history...
83
84			public function setOnWikiName($onWikiName)
85			{
86			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end setOnWikiName() Loading history...
87
88			public function getWelcomeSig()
89			{
90			return null;
91			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end getWelcomeSig() Loading history...
92
93			public function setWelcomeSig($welcomeSig)
94			{
95			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end setWelcomeSig() Loading history...
96
97			public function getLastActive()
98			{
99			$now = new DateTime();
100
101			return $now->format("Y-m-d H:i:s");
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `Y-m-d H:i:s` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
102			}
			0 ignored issues – show Coding Style introduced 2020-04-26 01:41 UTC by Report Bug Copy Issue Report Expected //end getLastActive() Loading history...
103
104			public function getForceLogout()
105			{
106			return true;
107			}
			0 ignored issues – show Coding Style introduced 2020-04-26 01:41 UTC by Report Bug Copy Issue Report Expected //end getForceLogout() Loading history...
108
109			public function setForceLogout($forceLogout)
110			{
111			}
			0 ignored issues – show Coding Style introduced 2020-04-26 01:41 UTC by Report Bug Copy Issue Report Expected //end setForceLogout() Loading history...
112
113			/**
114			* @param string $status
115			*/
116			public function setStatus($status)
117			{
118			}
			0 ignored issues – show Coding Style introduced 2020-04-26 01:41 UTC by Report Bug Copy Issue Report Expected //end setStatus() Loading history...
119
120			public function getWelcomeTemplate()
121			{
122			return 0;
123			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end getWelcomeTemplate() Loading history...
124
125			public function setWelcomeTemplate($welcomeTemplate)
126			{
127			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end setWelcomeTemplate() Loading history...
128
129			public function getAbortPref()
130			{
131			return 0;
132			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end getAbortPref() Loading history...
133
134			public function setAbortPref($abortPreference)
135			{
136			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end setAbortPref() Loading history...
137
138			public function getConfirmationDiff()
139			{
140			return null;
141			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end getConfirmationDiff() Loading history...
142
143			public function setConfirmationDiff($confirmationDiff)
144			{
145			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end setConfirmationDiff() Loading history...
146
147			public function getEmailSig()
148			{
149			return null;
150			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end getEmailSig() Loading history...
151
152			public function setEmailSig($emailSignature)
153			{
154			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end setEmailSig() Loading history...
155
156			#endregion
157
158			#region user access checks
159
160			public function isIdentified(IdentificationVerifier $iv)
161			{
162			return false;
163			}
			0 ignored issues – show Coding Style introduced 2020-04-26 01:41 UTC by Report Bug Copy Issue Report Expected //end isIdentified() Loading history...
164
165			public function isSuspended()
166			{
167			return false;
168			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end isSuspended() Loading history...
169
170			public function isNewUser()
171			{
172			return false;
173			}
			0 ignored issues – show Coding Style introduced 2020-04-26 01:41 UTC by Report Bug Copy Issue Report Expected //end isNewUser() Loading history...
174
175			public function isDeclined()
176			{
177			return false;
178			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end isDeclined() Loading history...
179
180			public function isCommunityUser()
181			{
182			return true;
183			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end isCommunityUser() Loading history...
184
185			#endregion
186
187			#region OAuth
188
189			public function getOAuthIdentity($useCached = false)
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Incorrect spacing between argument "$useCached" and equals sign; expected 0 but found 1 Loading history... Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Incorrect spacing between default value and equals sign for argument "$useCached"; expected 0 but found 1 Loading history...
190			{
191			return null;
192			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end getOAuthIdentity() Loading history...
193
194			public function isOAuthLinked()
195			{
196			return false;
197			}
			0 ignored issues – show Coding Style introduced 2020-04-26 01:41 UTC by Report Bug Copy Issue Report Expected //end isOAuthLinked() Loading history...
198
199			public function oauthCanUse()
200			{
201			return false;
202			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end oauthCanUse() Loading history...
203
204			public function oauthCanEdit()
205			{
206			return false;
207			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end oauthCanEdit() Loading history...
208
209			public function oauthCanCreateAccount()
210			{
211			return false;
212			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end oauthCanCreateAccount() Loading history...
213
214			protected function oauthCanCheckUser()
215			{
216			return false;
217			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end oauthCanCheckUser() Loading history...
218
219			#endregion
220
221			public function getApprovalDate()
222			{
223			$data = DateTime::createFromFormat("Y-m-d H:i:s", "1970-01-01 00:00:00");
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `Y-m-d H:i:s` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report The string literal `1970-01-01 00:00:00` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
224
225			return $data;
226			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end getApprovalDate() Loading history...
227			}
			0 ignored issues – show Coding Style introduced 2020-04-23 23:50 UTC by Report Bug Copy Issue Report Expected //end class Loading history...
228

mdaniels5757 / waca

Push — rbac ( be68b4...52c28b )

CommunityUser::getWelcomeTemplate() A

Complexity

Size

Duplication

Code Coverage

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like