Waca\Pages\PageEditComment

Complexity

Total Complexity

9

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	main()	0	57	9

<?php
/******************************************************************************
 * Wikipedia Account Creation Assistance tool                                 *
 *                                                                            *
 * All code in this file is released into the public domain by the ACC        *
 * Development Team. Please see team.json for a list of contributors.         *
 ******************************************************************************/

namespace Waca\Pages;

use Waca\DataObjects\Comment;
use Waca\DataObjects\Request;
use Waca\DataObjects\User;
use Waca\Exceptions\AccessDeniedException;
use Waca\Exceptions\ApplicationLogicException;
use Waca\Helpers\Logger;
use Waca\SessionAlert;
use Waca\Tasks\InternalPageBase;
use Waca\WebRequest;

class PageEditComment extends InternalPageBase
{
    /**
     * Main function for this page, when no specific actions are called.
     * @throws ApplicationLogicException
     */

Expected 2 @throws tag(s) in function comment; 1 found

    protected function main()
    {
        $commentId = WebRequest::getInt('id');
        if ($commentId === null) {
            throw new ApplicationLogicException('Comment ID not specified');
        }

        $database = $this->getDatabase();

        /** @var Comment $comment */
        $comment = Comment::getById($commentId, $database);
        if ($comment === false) {

The condition $comment === false is always false.

            throw new ApplicationLogicException('Comment not found');
        }

        $currentUser = User::getCurrent($database);
        if ($comment->getUser() !== $currentUser->getId() && !$this->barrierTest('editOthers', $currentUser)) {
            throw new AccessDeniedException($this->getSecurityManager());
        }

        /** @var Request $request */
        $request = Request::getById($comment->getRequest(), $database);

        if ($request === false) {

The condition $request === false is always false.

            throw new ApplicationLogicException('Request was not found.');
        }

        if (WebRequest::wasPosted()) {
            $this->validateCSRFToken();
            $newComment = WebRequest::postString('newcomment');
            $visibility = WebRequest::postString('visibility');

            if ($visibility !== 'user' && $visibility !== 'admin') {
                throw new ApplicationLogicException('Comment visibility is not valid');
            }

            // optimisticly lock from the load of the edit comment form
            $updateVersion = WebRequest::postInt('updateversion');
            $comment->setUpdateVersion($updateVersion);

            $comment->setComment($newComment);
            $comment->setVisibility($visibility);

            $comment->save();

            Logger::editComment($database, $comment, $request);
            $this->getNotificationHelper()->commentEdited($comment, $request);
            SessionAlert::success("Comment has been saved successfully");

The string literal Comment has been saved successfully does not require double quotes, as per coding-style, please use single quotes.

            $this->redirect('viewRequest', null, array('id' => $comment->getRequest()));
        }
        else {
            $this->assignCSRFToken();
            $this->assign('comment', $comment);
            $this->assign('request', $request);
            $this->assign('user', User::getById($comment->getUser(), $database));
            $this->setTemplate('edit-comment.tpl');
        }
    }

Expected //end main()

}

Expected //end class