Passed
Pull Request — php8 (#278)
by
unknown
21:46 queued 17:53
created
includes/Fragments/RequestListData.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,8 @@
 block discarded – undo
38 38
         $requestList->requests = $requests;
39 39
 
40 40
         $userIds = array_map(
41
-            function(Request $entry) {
41
+            function(Request $entry)
42
+            {
42 43
                 return $entry->getReserved();
43 44
             },
44 45
             $requests
Please login to merge, or discard this patch.
includes/Validation/RequestValidationHelper.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -260,8 +260,7 @@
 block discarded – undo
260 260
 
261 261
                     $comment->setComment("This request would have been deferred automatically due to a matching rule, but the queue to defer to could not be found.");
262 262
                     $comment->save();
263
-                }
264
-                else {
263
+                } else {
265 264
                     $this->deferRequest($request, $targetQueue, 'Request deferred automatically due to matching rule.');
266 265
                 }
267 266
             }
Please login to merge, or discard this patch.
includes/Pages/PageWelcomeTemplateManagement.php 1 patch
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -166,8 +166,7 @@  discard block
 block discarded – undo
166 166
             SessionAlert::success("Template successfully created.");
167 167
 
168 168
             $this->redirect('welcomeTemplates');
169
-        }
170
-        else {
169
+        } else {
171 170
             $this->assignCSRFToken();
172 171
             $this->assign('template', new WelcomeTemplate());
173 172
             $this->setTemplate("welcome-template/edit.tpl");
@@ -216,8 +215,7 @@  discard block
 block discarded – undo
216 215
             $this->getNotificationHelper()->welcomeTemplateEdited($template);
217 216
 
218 217
             $this->redirect('welcomeTemplates');
219
-        }
220
-        else {
218
+        } else {
221 219
             $this->assignCSRFToken();
222 220
             $this->assign('template', $template);
223 221
             $this->setTemplate('welcome-template/edit.tpl');
Please login to merge, or discard this patch.
includes/Pages/PageErrorLogViewer.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,11 +30,13 @@
 block discarded – undo
30 30
         $files = scandir($errorLogDirectory);
31 31
 
32 32
         // Exclude the files we know should be there
33
-        $filteredFiles = array_filter($files, function($file) {
33
+        $filteredFiles = array_filter($files, function($file)
34
+        {
34 35
             return !in_array($file, ['.', '..', 'README.md']);
35 36
         });
36 37
 
37
-        $exceptionDetails = array_map(function($item) use ($errorLogDirectory) {
38
+        $exceptionDetails = array_map(function($item) use ($errorLogDirectory)
39
+        {
38 40
             $filename = realpath($errorLogDirectory) . DIRECTORY_SEPARATOR . $item;
39 41
 
40 42
             return [
Please login to merge, or discard this patch.
includes/Pages/PageMain.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -187,7 +187,8 @@
 block discarded – undo
187 187
 
188 188
         // FIXME: domains!
189 189
         $requestQueues = RequestQueue::getAllQueues($database);
190
-        $queuesById = array_reduce($requestQueues, function($result, RequestQueue $item) {
190
+        $queuesById = array_reduce($requestQueues, function($result, RequestQueue $item)
191
+        {
191 192
             $result[$item->getId()] = $item;
192 193
             return $result;
193 194
         }, array());
Please login to merge, or discard this patch.
includes/Pages/PageViewRequest.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -136,8 +136,7 @@  discard block
 block discarded – undo
136 136
                 $this->setTemplate('view-request/main-with-checkuser-data.tpl');
137 137
                 $this->setupCheckUserData($request);
138 138
             }
139
-        }
140
-        else {
139
+        } else {
141 140
             $this->setTemplate('view-request/main.tpl');
142 141
         }
143 142
     }
@@ -151,8 +150,7 @@  discard block
 block discarded – undo
151 150
         if ($request->getStatus() === RequestStatus::CLOSED) {
152 151
             if ($request->getWasCreated()) {
153 152
                 $statusSymbol = self::STATUS_SYMBOL_ACCEPTED;
154
-            }
155
-            else {
153
+            } else {
156 154
                 $statusSymbol = self::STATUS_SYMBOL_REJECTED;
157 155
             }
158 156
         }
@@ -304,8 +302,7 @@  discard block
 block discarded – undo
304 302
                         'jobId'    => $job->getId(),
305 303
                         'jobDesc'  => JobQueue::getTaskDescriptions()[$job->getTask()],
306 304
                     );
307
-                }
308
-                else {
305
+                } else {
309 306
                     $requestLogs[] = array(
310 307
                         'type'     => 'log',
311 308
                         'security' => 'user',
Please login to merge, or discard this patch.
includes/Pages/PageFlagComment.php 1 patch
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -70,15 +70,13 @@
 block discarded – undo
70 70
 
71 71
         if ($flagState === 1) {
72 72
             Logger::flaggedComment($database, $comment, $request->getDomain());
73
-        }
74
-        else {
73
+        } else {
75 74
             Logger::unflaggedComment($database, $comment, $request->getDomain());
76 75
         }
77 76
 
78 77
         if (WebRequest::postString('return') == 'list') {
79 78
             $this->redirect('flaggedComments');
80
-        }
81
-        else {
79
+        } else {
82 80
             $this->redirect('viewRequest', null, ['id' => $comment->getRequest()]);
83 81
         }
84 82
     }
Please login to merge, or discard this patch.
includes/Pages/PageLog.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -44,8 +44,7 @@
 block discarded – undo
44 44
             $userObj = User::getByUsername($filterUser, $database);
45 45
             if ($userObj !== false) {
46 46
                 $logSearch->byUser($userObj->getId());
47
-            }
48
-            else {
47
+            } else {
49 48
                 $logSearch->byUser(-1);
50 49
             }
51 50
         }
Please login to merge, or discard this patch.
includes/Pages/PageListFlaggedComments.php 1 patch
Braces   +5 added lines, -10 removed lines patch added patch discarded remove patch
@@ -61,28 +61,23 @@
 block discarded – undo
61 61
 
62 62
                 if ($request->getReserved() === $currentUser->getId()) {
63 63
                     $data['hiddenText'] = false;
64
-                }
65
-                else {
64
+                } else {
66 65
                     $data['hiddenText'] = true;
67 66
                 }
68 67
             }
69 68
 
70 69
             if ($object->getVisibility() == 'requester' || $object->getVisibility() == 'user') {
71 70
                 $data['hidden'] = false;
72
-            }
73
-            elseif ($object->getVisibility() == 'admin') {
71
+            } elseif ($object->getVisibility() == 'admin') {
74 72
                 if ($seeRestrictedComments) {
75 73
                     $data['hidden'] = false;
76
-                }
77
-                else {
74
+                } else {
78 75
                     $data['hidden'] = true;
79 76
                 }
80
-            }
81
-            elseif ($object->getVisibility() == 'checkuser') {
77
+            } elseif ($object->getVisibility() == 'checkuser') {
82 78
                 if ($seeCheckuserComments) {
83 79
                     $data['hidden'] = false;
84
-                }
85
-                else {
80
+                } else {
86 81
                     $data['hidden'] = true;
87 82
                 }
88 83
             }
Please login to merge, or discard this patch.