Items::validate() - Code Metrics - Inspection of "More tests for items" - mcustiel/php-simple-request - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 89d185...a7034a )

by Mariano

created 2016-07-19 16:27 UTC

Items::validate() A

↳ Parent: Items

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3.0416

Importance

Changes	4
Bugs	2	Features	2

Metric	Value
c	4
b	2
f	2
dl	0
loc	14
ccs	5
cts	6
cp	0.8333
rs	9.4285
cc	3
eloc	6
nc	3
nop	1
crap	3.0416

<?php
/**
 * This file is part of php-simple-request.
 *
 * php-simple-request is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * php-simple-request is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with php-simple-request.  If not, see <http://www.gnu.org/licenses/>.
 */
namespace Mcustiel\SimpleRequest\Validator;

use Mcustiel\SimpleRequest\Interfaces\ValidatorInterface;
use Mcustiel\SimpleRequest\Annotation\ValidatorAnnotation;
use Mcustiel\SimpleRequest\Exception\UnspecifiedValidatorException;

/**
 * Checks that each element of an array validates against its corresponding
 * validator in a collection.
 * <a href="http://spacetelescope.github.io/understanding-json-schema/UnderstandingJSONSchema.pdf">Here</a>
 * you can see examples of use for this validator.
 *
 * @author mcustiel
 */
class Items extends AbstractIterableValidator
{
    const ITEMS_INDEX = 'items';
    const ADDITIONAL_ITEMS_INDEX = 'additionalItems';

    /**
     * @var bool|\Mcustiel\SimpleRequest\Interfaces\ValidatorInterface
     */
    private $additionalItems = true;

    /**
     * {@inheritdoc}
     *
     * @see \Mcustiel\SimpleRequest\Validator\AbstractIterableValidator::setSpecification()
     */
    public function setSpecification($specification = null)
    {
        $this->checkSpecificationIsArray($specification);

        $this->initItems($specification);
        $this->initAdditionalItems($specification);
    }

    private function initAdditionalItems($specification)
    {
        if (isset($specification[self::ADDITIONAL_ITEMS_INDEX])) {
            $this->setAdditionalItems($specification[self::ADDITIONAL_ITEMS_INDEX]);
        }
    }

    private function initItems($specification)
    {
        if (isset($specification[self::ITEMS_INDEX])) {
            $this->setItems($specification[self::ITEMS_INDEX]);
        }
    }

    /**
     * {@inheritdoc}
     *
     * @see \Mcustiel\SimpleRequest\Validator\AbstractAnnotationSpecifiedValidator::validate()
     */
    public function validate($value)
    {
        if (!is_array($value)) {
            return false;
        }

        // From json-schema definition: if "items" is not present, or its value is an object,
        // validation of the instance always succeeds, regardless of the value of "additionalItems";
        if (empty($this->items)) {
            return true;
        }

        return $this->executeItemsValidation($value);
    }

    private function executeItemsValidation($value)
    {
        if ($this->items instanceof ValidatorInterface) {
            return $this->validateArray($value, $this->items);
        }
        $valid = $this->validateTuple($value);
        // From json-schema definition: if the value of "additionalItems" is boolean value false and
        // the value of "items" is an array, the instance is valid if its size is less than, or
        // equal to, the size of "items".
        if ($this->additionalItems === false) {
            return $valid && (count($value) <= count($this->items));
        }

        // From json-schema definition: if the value of "additionalItems" is
        // boolean value true or an object, validation of the instance always succeeds;
        return $this->validateRest($value);
    }

    /**
     * Validates each element against its corresponding validator. Then,
     * if additionalItems is a validator, checks the rest again those
     * validators.
     *
     * @param array $list
     *
     * @return bool
     */
    private function validateRest(array $list)
    {
        $count = count($this->items);
        return $this->additionalItems === true ||
            $this->validateArray(
                array_slice($list, $count, count($list) - $count),
                $this->additionalItems
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            );
    }

    /**
     * Validates each one of the elements of the array against
     * its corresponding specified validator.
     *
     * @param array $tuple
     *
     * @return bool
     */
    private function validateTuple(array $tuple)
    {
        $keys = array_keys($tuple);
        $count = count($this->items);
        for ($index = 0; $index < $count; $index++) {
            // In the specification is not clear what to do when instance size
            // is less than items size. I chose to pass null and if null passes
            // the validation, it returns true.
            $value = isset($keys[$index]) ? $tuple[$keys[$index]] : null;
            if (!$this->items[$index]->validate($value)) {
                return false;
            }
        }

        return true;
    }

    /**
     * Checks and sets the specified items values.
     *
     * @param array|\Mcustiel\SimpleRequest\Interfaces\ValidatorInterface $specification
     */
    private function setItems($specification)
    {
        if ($specification instanceof ValidatorAnnotation) {
            $this->items = $this->createValidatorInstanceFromAnnotation(

                $specification
            );
        } else {
            $this->checkSpecificationIsArray($specification);
            $this->items = $this->convertAnnotationsToValidators($specification);

        }
    }

    private function convertAnnotationsToValidators(array $specification)
    {
        $items = [];
        foreach ($specification as $index => $validator) {
            $items[$index] = $this->checkIfAnnotationAndReturnObject($validator);
        }
        return $items;
    }

    /**
     * Checks and sets the specified additionalItems.
     *
     * @param bool|\Mcustiel\SimpleRequest\Interfaces\ValidatorInterface $specification
     */
    private function setAdditionalItems($specification)
    {
        if (is_bool($specification)) {
            $this->additionalItems = $specification;
        } elseif ($specification instanceof ValidatorAnnotation) {
            $this->additionalItems = $this->createValidatorInstanceFromAnnotation(
                $specification
            );
        } else {
            throw new UnspecifiedValidatorException(
                'The validator is being initialized without a valid validator Annotation'
            );
        }
    }

    /**
     * Validates an array against a specific validator.
     *
     * @param array                                                 $array
     * @param \Mcustiel\SimpleRequest\Interfaces\ValidatorInterface $validator
     */
    private function validateArray(array $array, ValidatorInterface $validator)
    {
        foreach ($array as $item) {
            if (!$validator->validate($item)) {
                return false;
            }
        }

        return true;
    }
}


1		<?php
2		/**
3		* This file is part of php-simple-request.
4		*
5		* php-simple-request is free software: you can redistribute it and/or modify
6		* it under the terms of the GNU Lesser General Public License as published by
7		* the Free Software Foundation, either version 3 of the License, or
8		* (at your option) any later version.
9		*
10		* php-simple-request is distributed in the hope that it will be useful,
11		* but WITHOUT ANY WARRANTY; without even the implied warranty of
12		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13		* GNU General Public License for more details.
14		*
15		* You should have received a copy of the GNU General Public License
16		* along with php-simple-request. If not, see <http://www.gnu.org/licenses/>.
17		*/
18		namespace Mcustiel\SimpleRequest\Validator;
19
20		use Mcustiel\SimpleRequest\Interfaces\ValidatorInterface;
21		use Mcustiel\SimpleRequest\Annotation\ValidatorAnnotation;
22		use Mcustiel\SimpleRequest\Exception\UnspecifiedValidatorException;
23
24		/**
25		* Checks that each element of an array validates against its corresponding
26		* validator in a collection.
27		* <a href="http://spacetelescope.github.io/understanding-json-schema/UnderstandingJSONSchema.pdf">Here</a>
28		* you can see examples of use for this validator.
29		*
30		* @author mcustiel
31		*/
32		class Items extends AbstractIterableValidator
33		{
34		const ITEMS_INDEX = 'items';
35		const ADDITIONAL_ITEMS_INDEX = 'additionalItems';
36
37		/**
38		* @var bool\|\Mcustiel\SimpleRequest\Interfaces\ValidatorInterface
39		*/
40		private $additionalItems = true;
41
42		/**
43		* {@inheritdoc}
44		*
45		* @see \Mcustiel\SimpleRequest\Validator\AbstractIterableValidator::setSpecification()
46		*/
47	90	public function setSpecification($specification = null)
48		{
49	90	$this->checkSpecificationIsArray($specification);
50
51	89	$this->initItems($specification);
52	87	$this->initAdditionalItems($specification);
53	86	}
54
55	87	private function initAdditionalItems($specification)
56		{
57	87	if (isset($specification[self::ADDITIONAL_ITEMS_INDEX])) {
58	86	$this->setAdditionalItems($specification[self::ADDITIONAL_ITEMS_INDEX]);
59	85	}
60	86	}
61
62	89	private function initItems($specification)
63		{
64	89	if (isset($specification[self::ITEMS_INDEX])) {
65	88	$this->setItems($specification[self::ITEMS_INDEX]);
66	86	}
67	87	}
68
69		/**
70		* {@inheritdoc}
71		*
72		* @see \Mcustiel\SimpleRequest\Validator\AbstractAnnotationSpecifiedValidator::validate()
73		*/
74	88	public function validate($value)
75		{
76	88	if (!is_array($value)) {
77	1	return false;
78		}
79
80		// From json-schema definition: if "items" is not present, or its value is an object,
81		// validation of the instance always succeeds, regardless of the value of "additionalItems";
82	87	if (empty($this->items)) {
83		return true;
84		}
85
86	87	return $this->executeItemsValidation($value);
87		}
88
89	87	private function executeItemsValidation($value)
90		{
91	87	if ($this->items instanceof ValidatorInterface) {
92	2	return $this->validateArray($value, $this->items);
93		}
94	85	$valid = $this->validateTuple($value);
95		// From json-schema definition: if the value of "additionalItems" is boolean value false and
96		// the value of "items" is an array, the instance is valid if its size is less than, or
97		// equal to, the size of "items".
98	85	if ($this->additionalItems === false) {
99	83	return $valid && (count($value) <= count($this->items));
100		}
101
102		// From json-schema definition: if the value of "additionalItems" is
103		// boolean value true or an object, validation of the instance always succeeds;
104	2	return $this->validateRest($value);
105		}
106
107		/**
108		* Validates each element against its corresponding validator. Then,
109		* if additionalItems is a validator, checks the rest again those
110		* validators.
111		*
112		* @param array $list
113		*
114		* @return bool
115		*/
116	2	private function validateRest(array $list)
117		{
118	2	$count = count($this->items);
119	2	return $this->additionalItems === true \|\|
120	2	$this->validateArray(
121	2	array_slice($list, $count, count($list) - $count),
122	2	$this->additionalItems
		0 ignored issues – show Bug introduced 2016-01-30 17:24 UTC by Report Bug Copy Issue Report It seems like `$this->additionalItems` can also be of type `boolean`; however, `Mcustiel\SimpleRequest\V...\Items::validateArray()` does only seem to accept `object<Mcustiel\SimpleRe...ces\ValidatorInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
123	2	);
124		}
125
126		/**
127		* Validates each one of the elements of the array against
128		* its corresponding specified validator.
129		*
130		* @param array $tuple
131		*
132		* @return bool
133		*/
134	85	private function validateTuple(array $tuple)
135		{
136	85	$keys = array_keys($tuple);
137	85	$count = count($this->items);
138	85	for ($index = 0; $index < $count; $index++) {
139		// In the specification is not clear what to do when instance size
140		// is less than items size. I chose to pass null and if null passes
141		// the validation, it returns true.
142	85	$value = isset($keys[$index]) ? $tuple[$keys[$index]] : null;
143	85	if (!$this->items[$index]->validate($value)) {
144	6	return false;
145		}
146	85	}
147
148	79	return true;
149		}
150
151		/**
152		* Checks and sets the specified items values.
153		*
154		* @param array\|\Mcustiel\SimpleRequest\Interfaces\ValidatorInterface $specification
155		*/
156	88	private function setItems($specification)
157		{
158	88	if ($specification instanceof ValidatorAnnotation) {
159	2	$this->items = $this->createValidatorInstanceFromAnnotation(
		0 ignored issues – show Documentation Bug introduced 2016-07-15 12:42 UTC by Report Bug Copy Issue Report It seems like `$this->createValidatorIn...otation($specification)` of type `object<Mcustiel\SimpleRe...ces\ValidatorInterface>` is incompatible with the declared type `array<integer,object<Mcu...es\ValidatorInterface>>` of property `$items`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
160		$specification
161	2	);
162	2	} else {
163	86	$this->checkSpecificationIsArray($specification);
164	85	$this->items = $this->convertAnnotationsToValidators($specification);
		0 ignored issues – show Bug introduced 2016-07-19 15:46 UTC by Report Bug Copy Issue Report It seems like `$specification` defined by parameter `$specification` on line 156 can also be of type `object<Mcustiel\SimpleRe...ces\ValidatorInterface>`; however, `Mcustiel\SimpleRequest\V...notationsToValidators()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
165		}
166	86	}
167
168	85	private function convertAnnotationsToValidators(array $specification)
169		{
170	85	$items = [];
171	85	foreach ($specification as $index => $validator) {
172	85	$items[$index] = $this->checkIfAnnotationAndReturnObject($validator);
173	84	}
174	84	return $items;
175		}
176
177		/**
178		* Checks and sets the specified additionalItems.
179		*
180		* @param bool\|\Mcustiel\SimpleRequest\Interfaces\ValidatorInterface $specification
181		*/
182	86	private function setAdditionalItems($specification)
183		{
184	86	if (is_bool($specification)) {
185	83	$this->additionalItems = $specification;
186	86	} elseif ($specification instanceof ValidatorAnnotation) {
187	2	$this->additionalItems = $this->createValidatorInstanceFromAnnotation(
188		$specification
189	2	);
190	2	} else {
191	1	throw new UnspecifiedValidatorException(
192		'The validator is being initialized without a valid validator Annotation'
193	1	);
194		}
195	85	}
196
197		/**
198		* Validates an array against a specific validator.
199		*
200		* @param array $array
201		* @param \Mcustiel\SimpleRequest\Interfaces\ValidatorInterface $validator
202		*/
203	4	private function validateArray(array $array, ValidatorInterface $validator)
204		{
205	4	foreach ($array as $item) {
206	4	if (!$validator->validate($item)) {
207	1	return false;
208		}
209	3	}
210
211	3	return true;
212		}
213		}
214

mcustiel / php-simple-request

Push — master ( 89d185...a7034a )

Items::validate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like