Mcustiel\SimpleRequest\Strategies\Annotations\ValidatorAnnotationParser

Complexity

Total Complexity

1

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	1	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	execute()	0	9	1

<?php
namespace Mcustiel\SimpleRequest\Strategies\Annotations;

use Mcustiel\SimpleRequest\Util\ValidatorBuilder;
use Mcustiel\SimpleRequest\Annotation\AnnotationWithAssociatedClass;
use Mcustiel\SimpleRequest\Annotation\RequestAnnotation;
use Mcustiel\SimpleRequest\Strategies\PropertyParserBuilder;

class ValidatorAnnotationParser implements AnnotationParser
{
    /**
     * {@inheritdoc}
     * In this method, annotation param is treated as instance of AnnotationWithAssociatedClass.
     *
     * @see \Mcustiel\SimpleRequest\Strategies\Annotations\AnnotationParser::execute()
     */
    public function execute(RequestAnnotation $annotation, PropertyParserBuilder $propertyParser)
    {
        $propertyParser->addValidator(
            ValidatorBuilder::builder()

It seems like \Mcustiel\SimpleRequest\Util\ValidatorBuilder::builder()->withClass($annotation->getAssociatedClass())->withSpecification($annotation->getValue())->build() targeting Mcustiel\SimpleRequest\Util\AnnotationToImplementationBuilder::build() can also be of type object<Mcustiel\SimpleRequest\Interfaces\FilterInterface>; however, Mcustiel\SimpleRequest\Strategies\PropertyParserBuilder::addValidator() does only seem to accept object<Mcustiel\SimpleRequest\Interfaces\ValidatorInterface>, maybe add an additional type check?

            ->withClass($annotation->getAssociatedClass())

It seems like you code against a specific sub-type and not the parent class Mcustiel\SimpleRequest\Annotation\RequestAnnotation as the method getAssociatedClass() does only exist in the following sub-classes of Mcustiel\SimpleRequest\Annotation\RequestAnnotation: Mcustiel\SimpleRequest\Annotation\AnnotationWithAssociatedClass, Mcustiel\SimpleRequest\Annotation\FilterAnnotation, Mcustiel\SimpleRequest\Annotation\Filter\Capitalize, Mcustiel\SimpleRequest\Annotation\Filter\CustomFilter, Mcustiel\SimpleRequest\Annotation\Filter\DefaultValue, Mcustiel\SimpleRequest\Annotation\Filter\LowerCase, Mcustiel\SimpleRequest\Annotation\Filter\RegexReplace, Mcustiel\SimpleRequest\Annotation\Filter\ReplaceFilterAnnotation, Mcustiel\SimpleRequest\Annotation\Filter\StringReplace, Mcustiel\SimpleRequest\Annotation\Filter\ToFloat, Mcustiel\SimpleRequest\Annotation\Filter\ToInteger, Mcustiel\SimpleRequest\Annotation\Filter\Trim, Mcustiel\SimpleRequest\Annotation\Filter\UpperCase, Mcustiel\SimpleRequest\Annotation\ValidatorAnnotation, Mcustiel\SimpleRequest\Annotation\Validator\AllOf, Mcustiel\SimpleRequest\Annotation\Validator\Alpha, Mcustiel\SimpleRequest\Annotation\Validator\AlphaNumeric, Mcustiel\SimpleRequest\Annotation\Validator\AnyOf, Mcustiel\SimpleRequest\Annotation\Validator\CustomValidator, Mcustiel\SimpleRequest\Annotation\Validator\DateTime, Mcustiel\SimpleRequest\Annotation\Validator\DateTimeFormat, Mcustiel\SimpleRequest\Annotation\Validator\Definition, Mcustiel\SimpleRequest\Annotation\Validator\Email, Mcustiel\SimpleRequest\Annotation\Validator\Enum, Mcustiel\SimpleRequest\Annotation\Validator\ExclusiveMaximum, Mcustiel\SimpleRequest\Annotation\Validator\ExclusiveMinimum, Mcustiel\SimpleRequest\Annotation\Validator\Hexa, Mcustiel\SimpleRequest\Annotation\Validator\HostName, Mcustiel\SimpleRequest\Annotation\Validator\IPV4, Mcustiel\SimpleRequest\Annotation\Validator\IPV6, Mcustiel\SimpleRequest\Annotation\Validator\Items, Mcustiel\SimpleRequest\Annotation\Validator\MacAddress, Mcustiel\SimpleRequest\Annotation\Validator\MaxItems, Mcustiel\SimpleRequest\Annotation\Validator\MaxLength, Mcustiel\SimpleRequest\Annotation\Validator\MaxProperties, Mcustiel\SimpleRequest\Annotation\Validator\Maximum, Mcustiel\SimpleRequest\Annotation\Validator\MinItems, Mcustiel\SimpleRequest\Annotation\Validator\MinLength, Mcustiel\SimpleRequest\Annotation\Validator\MinProperties, Mcustiel\SimpleRequest\Annotation\Validator\Minimum, Mcustiel\SimpleRequest\Annotation\Validator\MultipleOf, Mcustiel\SimpleRequest\Annotation\Validator\Not, Mcustiel\SimpleRequest\Annotation\Validator\NotEmpty, Mcustiel\SimpleRequest\Annotation\Validator\NotNull, Mcustiel\SimpleRequest\Annotation\Validator\OneOf, Mcustiel\SimpleRequest\Annotation\Validator\Pattern, Mcustiel\SimpleRequest\Annotation\Validator\Properties, Mcustiel\SimpleRequest\Annotation\Validator\RegExp, Mcustiel\SimpleRequest\Annotation\Validator\Required, Mcustiel\SimpleRequest\Annotation\Validator\TwitterAccount, Mcustiel\SimpleRequest\Annotation\Validator\Type, Mcustiel\SimpleRequest\Annotation\Validator\TypeFloat, Mcustiel\SimpleRequest\Annotation\Validator\TypeInteger, Mcustiel\SimpleRequest\Annotation\Validator\UniqueItems, Mcustiel\SimpleRequest\Annotation\Validator\Uri. Maybe you want to instanceof check for one of these explicitly?

            ->withSpecification($annotation->getValue())
            ->build()
        );
    }
}