Mcustiel\Phiremock\Common\Utils\ArrayToExpectationConverterLocator

Complexity

Total Complexity

5

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	locate()	0	15	4
A	__construct()	0	4	1

<?php

namespace Mcustiel\Phiremock\Common\Utils;

use Mcustiel\Phiremock\Common\Utils\V1\Factory as FactoryV1;
use Mcustiel\Phiremock\Common\Utils\V2\Factory as FactoryV2;

class ArrayToExpectationConverterLocator
{
    /** @var FactoryV1 */
    private $factoryV1;

    /** @var FactoryV2 */
    private $factoryV2;

    public function __construct(FactoryV1 $factoryV1, FactoryV2 $factoryV2)
    {
        $this->factoryV1 = $factoryV1;
        $this->factoryV2 = $factoryV2;
    }

    public function locate(array $expectationArray): ArrayToExpectationConverter
    {
        if (isset($expectationArray['version'])) {
            switch ($expectationArray['version']) {
                case '1':
                    return $this->factoryV1->createArrayToExpectationConverter();

The expression return $this->factoryV1->createArrayToExpectationConverter() returns the type Mcustiel\Phiremock\Common\Utils\V1\ArrayToExpectationConverter which is incompatible with the type-hinted return Mcustiel\Phiremock\Common\Utils\ArrayToExpectationConverter.

                case '2':
                    return $this->factoryV2->createArrayToExpectationConverter();

The expression return $this->factoryV2->createArrayToExpectationConverter() returns the type Mcustiel\Phiremock\Common\Utils\V2\ArrayToExpectationConverter which is incompatible with the type-hinted return Mcustiel\Phiremock\Common\Utils\ArrayToExpectationConverter.

            }
            throw new \Exception(
                sprintf('Unimplemented configuration version: %s', $expectationArray['version'])
            );
        }

        return $this->factory->createArrayToExpectationConverterV1();

The property factory does not exist on Mcustiel\Phiremock\Common\Utils\ArrayToExpectationConverterLocator. Did you mean factoryV2?

    }
}