ActionFactory::createActionFromConfig() - Code Metrics - Inspection of "Removed unneeded factories from power router const..." - mcustiel/PowerRoute - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — develop (905d13)

by Mariano

created 2016-01-28 20:08 UTC

ActionFactory::createActionFromConfig() A

↳ Parent: ActionFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	7
ccs	5
cts	5
cp	1
rs	9.4285
cc	1
eloc	5
nc	1
nop	2
crap	1

<?php
namespace Mcustiel\PowerRoute\Common\Factories;

use Mcustiel\PowerRoute\Actions\GoToAction;
use Mcustiel\PowerRoute\PowerRoute;

class ActionFactory extends Mapping
{
    public function __construct(array $mapping)
    {
        parent::__construct(array_merge(['goto' => GoToAction::class], $mapping));
    }

    /**
     * @param array $config
     *
     * @return \Mcustiel\PowerRoute\Actions\ActionInterface[]
     */
    public function createFromConfig(array $config, PowerRoute $executor)
    {
        $actions = [];

        foreach ($config as $actionData) {
            $actions[] = $this->createActionFromConfig($actionData, $executor);
        }

        return $actions;
    }

    private function createActionFromConfig($actionData, $executor)
    {
        $action = key($actionData);
        $this->checkMappingIsValid($action);
        $class = $this->mapping[$action];
        return new $class($this->getConstructorArgument($executor, $actionData[$action], $class));
    }

    private function getConstructorArgument($executor, $argument, $class)
    {
        if ($class == GoToAction::class) {
            $classArgument = new \stdClass;
            $classArgument->route = $argument;
            $classArgument->executor = $executor;
        } else {
            $classArgument = $argument;
        }

        return $classArgument;
    }
}


1		<?php
2		namespace Mcustiel\PowerRoute\Common\Factories;
3
4		use Mcustiel\PowerRoute\Actions\GoToAction;
5		use Mcustiel\PowerRoute\PowerRoute;
6
7		class ActionFactory extends Mapping
8		{
9	3	public function __construct(array $mapping)
10		{
11	3	parent::__construct(array_merge(['goto' => GoToAction::class], $mapping));
12	3	}
13
14		/**
15		* @param array $config
16		*
17		* @return \Mcustiel\PowerRoute\Actions\ActionInterface[]
18		*/
19	3	public function createFromConfig(array $config, PowerRoute $executor)
20		{
21	3	$actions = [];
22
23	3	foreach ($config as $actionData) {
24	3	$actions[] = $this->createActionFromConfig($actionData, $executor);
25	3	}
26
27	3	return $actions;
28		}
29
30	3	private function createActionFromConfig($actionData, $executor)
31		{
32	3	$action = key($actionData);
33	3	$this->checkMappingIsValid($action);
34	3	$class = $this->mapping[$action];
35	3	return new $class($this->getConstructorArgument($executor, $actionData[$action], $class));
36		}
37
38	3	private function getConstructorArgument($executor, $argument, $class)
39		{
40	3	if ($class == GoToAction::class) {
41	2	$classArgument = new \stdClass;
42	2	$classArgument->route = $argument;
43	2	$classArgument->executor = $executor;
44	2	} else {
45	3	$classArgument = $argument;
46		}
47
48	3	return $classArgument;
49		}
50		}
51

mcustiel / PowerRoute

Branch — develop (905d13)

ActionFactory::createActionFromConfig() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like