Crummy\Phlack\Common\OptionsResolver

Complexity

Total Complexity

10

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

85%

Importance

Changes	2
Bugs	1	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setDefined()	0	8	2
A	setTypesAllowed()	0	12	3
A	setNormalizers()	0	12	3
A	isLatest()	0	8	2

<?php

namespace Crummy\Phlack\Common;

use Symfony\Component\OptionsResolver\OptionsResolver as BaseOptionsResolver;

class OptionsResolver extends BaseOptionsResolver
{
    private $isLatestVersion;

    /**
     * Set a list of allowed types for the given option.
     *
     * @see Symfony\Component\OptionsResolver\OptionsResolver::setAllowedTypes()
     *
     * @param array $allowedTypes
     *
     * @return $this
     */
    public function setTypesAllowed($allowedTypes = null)
    {
        if (!$this->isLatest()) {
            return $this->setAllowedTypes($allowedTypes);

$allowedTypes is of type array|null, but the function expects a string.

The call to setAllowedTypes() misses a required argument $allowedTypes.

        }

        foreach ($allowedTypes as $option => $typesAllowed) {

The expression $allowedTypes of type array|null is not guaranteed to be traversable. How about adding an additional type check?

            $this->setAllowedTypes($option, $typesAllowed);
        }

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function setDefined($optionNames)
    {
        if (!$this->isLatest()) {
            return $this->setOptional($optionNames);

The method setOptional() does not seem to exist on object<Crummy\Phlack\Common\OptionsResolver>.

        }

        return parent::setDefined($optionNames);
    }

    public function setNormalizers(array $normalizers)
    {
        if (!$this->isLatest()) {
            return parent::setNormalizers($normalizers);

The method setNormalizers() does not exist on Symfony\Component\OptionsResolver\OptionsResolver. Did you maybe mean setNormalizer()?

        }

        foreach ($normalizers as $option => $normalizer) {
            parent::setNormalizer($option, $normalizer);

It seems like you call parent on a different method (setNormalizer() instead of setNormalizers()). Are you sure this is correct? If so, you might want to change this to $this->setNormalizer().

        }

        return $this;
    }

    /**
     * Checks whether or not the OptionsResolver version is up-to-date.
     *
     * @return bool
     */
    private function isLatest()
    {
        if (null === $this->isLatestVersion) {
            $this->isLatestVersion = method_exists(current(class_parents($this)), 'setDefined');
        }

        return $this->isLatestVersion;
    }
}