PhlackClient::__construct() - Code Metrics - Inspection of "Miscellaneous fixes in "Bot\"" - mcrumm/phlack - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#32)

by Michael

created 2016-05-31 18:57 UTC

PhlackClient::__construct() A

↳ Parent: PhlackClient

Complexity

Conditions	4
Paths	2

Size

Total Lines	19
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	4

Importance

Changes	2
Bugs	1	Features	1

Metric	Value
c	2
b	1
f	1
dl	0
loc	19
ccs	12
cts	12
cp	1
rs	9.2
cc	4
eloc	11
nc	2
nop	2
crap	4

<?php

namespace Crummy\Phlack\Bridge\Guzzle;

use Guzzle\Common\Collection;
use Guzzle\Service\Client;
use Guzzle\Service\Description\ServiceDescription;

class PhlackClient extends Client
{
    /** @var array */
    protected $defaultConfig = [
        'request.options' => [
            'exceptions'  => false,
        ],
    ];

    /** @var array */
    protected $legacyRequirements = ['username', 'token'];

    /**
     * @param string     $baseUrl
     * @param array|null $config
     */
    public function __construct($baseUrl = LegacyUrlPlugin::BASE_URL, $config = null)
    {
        $legacyMode = $this->isLegacyUrl($baseUrl);

        $config = Collection::fromConfig(
            $config ?: [],
            $this->defaultConfig,
            $legacyMode ? $this->legacyRequirements : []
        );

        if ($legacyMode) {
            $this->addSubscriber(new LegacyUrlPlugin($config['username'], $config['token']));
            unset($config['username'], $config['token']);
        }

        parent::__construct($baseUrl, $config);

        $this->setDescription(ServiceDescription::factory(__DIR__.'/Resources/slack.json'));
    }

    /**
     * {@inheritdoc}
     */
    public static function factory($config = [])
    {
        if (!is_array($config)) {
            return new self($config);
        }

        return new self(isset($config['url']) ? $config['url'] : null, $config);
    }

    /**
     * @param string $baseUrl
     *
     * @return bool
     */
    private function isLegacyUrl($baseUrl)
    {
        return null === $baseUrl || $baseUrl === LegacyUrlPlugin::BASE_URL;
    }
}


1		<?php
2
3		namespace Crummy\Phlack\Bridge\Guzzle;
4
5		use Guzzle\Common\Collection;
6		use Guzzle\Service\Client;
7		use Guzzle\Service\Description\ServiceDescription;
8
9		class PhlackClient extends Client
10		{
11		/** @var array */
12		protected $defaultConfig = [
13		'request.options' => [
14		'exceptions' => false,
15		],
16		];
17
18		/** @var array */
19		protected $legacyRequirements = ['username', 'token'];
20
21		/**
22		* @param string $baseUrl
23		* @param array\|null $config
24		*/
25	13	public function __construct($baseUrl = LegacyUrlPlugin::BASE_URL, $config = null)
26		{
27	13	$legacyMode = $this->isLegacyUrl($baseUrl);
28
29	13	$config = Collection::fromConfig(
30	13	$config ?: [],
31	13	$this->defaultConfig,
32	13	$legacyMode ? $this->legacyRequirements : []
33		);
34
35	11	if ($legacyMode) {
36	2	$this->addSubscriber(new LegacyUrlPlugin($config['username'], $config['token']));
37	2	unset($config['username'], $config['token']);
38		}
39
40	11	parent::__construct($baseUrl, $config);
41
42	11	$this->setDescription(ServiceDescription::factory(__DIR__.'/Resources/slack.json'));
43	11	}
44
45		/**
46		* {@inheritdoc}
47		*/
48	6	public static function factory($config = [])
49		{
50	6	if (!is_array($config)) {
51	1	return new self($config);
52		}
53
54	5	return new self(isset($config['url']) ? $config['url'] : null, $config);
55		}
56
57		/**
58		* @param string $baseUrl
59		*
60		* @return bool
61		*/
62	13	private function isLegacyUrl($baseUrl)
63		{
64	13	return null === $baseUrl \|\| $baseUrl === LegacyUrlPlugin::BASE_URL;
65		}
66		}
67

mcrumm / phlack

Pull Request — develop (#32)

PhlackClient::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like