JoBindingCreateMapper::mapConfig() - Code Metrics - Inspection of "Merge branch 'master' of github.com:mcorten87/rabb..." - mcorten/rabbitmq_api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (1abd51)

by Mathijs

created 2016-09-28 18:15 UTC

JoBindingCreateMapper::mapConfig() A

↳ Parent: JoBindingCreateMapper

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	12
nc	2
nop	1

<?php

namespace mcorten87\rabbitmq_api\mappers;


use mcorten87\rabbitmq_api\jobs\JobBase;
use mcorten87\rabbitmq_api\jobs\JobBindingCreate;
use mcorten87\rabbitmq_api\objects\Method;
use mcorten87\rabbitmq_api\objects\Url;
use mcorten87\rabbitmq_api\services\MqManagementConfig;

class JoBindingCreateMapper extends BaseMapper
{
    protected function mapMethod(JobBase $job) : Method
    {
        return new Method(Method::METHOD_POST);
    }

    /**
     * @param JobBindingCreate $job
     * @return Url
     */
    protected function mapUrl(JobBase $job) : Url
    {
        return new Url('bindings/'
            .urlencode($job->getVirtualHost()).'/'
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            .urlencode($job->getQueueName()).'/'
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            .urlencode($job->getExchangeName()).'/'
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            .urlencode($job->getBindingName())
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        );
    }

    /**
     * @param JobBindingCreate $job
     * @return array
     */
    protected function mapConfig(JobBase $job) : array {
        $body = [
            'arguments'         => [],
            'destination'       => $job->getQueueName(),    // TODO depends on destination_type
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'destination_type'  => 'q', // TODO add exchange as destination
            'routing_key'       => '',  // TODO
            'source'            => $job->getExchangeName(),
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'vhost'             => $job->getVirtualHost(),
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        ];

        foreach ($job->getArguments() as $argument) {
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $body['arguments'][$argument->getArgumentName()] = $argument->getValue();
        };

        return array_merge(parent::mapConfig($job), [
            'json'      =>  $body,
        ]);
    }
}


Branch — master (1abd51)

JoBindingCreateMapper::mapConfig() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace mcorten87\rabbitmq_api\mappers;
4
5
6			use mcorten87\rabbitmq_api\jobs\JobBase;
7			use mcorten87\rabbitmq_api\jobs\JobBindingCreate;
8			use mcorten87\rabbitmq_api\objects\Method;
9			use mcorten87\rabbitmq_api\objects\Url;
10			use mcorten87\rabbitmq_api\services\MqManagementConfig;
11
12			class JoBindingCreateMapper extends BaseMapper
13			{
14			protected function mapMethod(JobBase $job) : Method
15			{
16			return new Method(Method::METHOD_POST);
17			}
18
19			/**
20			* @param JobBindingCreate $job
21			* @return Url
22			*/
23			protected function mapUrl(JobBase $job) : Url
24			{
25			return new Url('bindings/'
26			.urlencode($job->getVirtualHost()).'/'
			0 ignored issues – show Bug introduced 2016-09-28 18:25 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getVirtualHost()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\jobs\JobBindingCreate`, `mcorten87\rabbitmq_api\jobs\JobExchangeCreate`, `mcorten87\rabbitmq_api\jobs\JobExchangeDelete`, `mcorten87\rabbitmq_api\jobs\JobExchangeList`, `mcorten87\rabbitmq_api\j...ExchangeListVirtualHost`, `mcorten87\rabbitmq_api\jobs\JobPermissionCreate`, `mcorten87\rabbitmq_api\jobs\JobPermissionDelete`, `mcorten87\rabbitmq_api\j...rmissionListVirtualHost`, `mcorten87\rabbitmq_api\jobs\JobQueueCreate`, `mcorten87\rabbitmq_api\jobs\JobQueueDelete`, `mcorten87\rabbitmq_api\jobs\JobQueueList`, `mcorten87\rabbitmq_api\j...JobQueueListVirtualHost`, `mcorten87\rabbitmq_api\jobs\JobVirtualHostCreate`, `mcorten87\rabbitmq_api\jobs\JobVirtualHostDelete`, `mcorten87\rabbitmq_api\jobs\JobVirtualHostList`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
27			.urlencode($job->getQueueName()).'/'
			0 ignored issues – show Bug introduced 2016-09-28 18:25 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getQueueName()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\jobs\JobBindingCreate`, `mcorten87\rabbitmq_api\jobs\JobQueueCreate`, `mcorten87\rabbitmq_api\jobs\JobQueueDelete`, `mcorten87\rabbitmq_api\jobs\JobQueueList`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
28			.urlencode($job->getExchangeName()).'/'
			0 ignored issues – show Bug introduced 2016-09-28 18:25 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getExchangeName()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\jobs\JobBindingCreate`, `mcorten87\rabbitmq_api\jobs\JobExchangeCreate`, `mcorten87\rabbitmq_api\jobs\JobExchangeDelete`, `mcorten87\rabbitmq_api\jobs\JobExchangeList`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
29			.urlencode($job->getBindingName())
			0 ignored issues – show Bug introduced 2016-09-28 18:25 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getBindingName()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\jobs\JobBindingCreate`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
30			);
31			}
32
33			/**
34			* @param JobBindingCreate $job
35			* @return array
36			*/
37			protected function mapConfig(JobBase $job) : array {
38			$body = [
39			'arguments' => [],
40			'destination' => $job->getQueueName(), // TODO depends on destination_type
			0 ignored issues – show Bug introduced 2016-09-28 18:25 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getQueueName()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\jobs\JobBindingCreate`, `mcorten87\rabbitmq_api\jobs\JobQueueCreate`, `mcorten87\rabbitmq_api\jobs\JobQueueDelete`, `mcorten87\rabbitmq_api\jobs\JobQueueList`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
41			'destination_type' => 'q', // TODO add exchange as destination
42			'routing_key' => '', // TODO
43			'source' => $job->getExchangeName(),
			0 ignored issues – show Bug introduced 2016-09-28 18:25 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getExchangeName()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\jobs\JobBindingCreate`, `mcorten87\rabbitmq_api\jobs\JobExchangeCreate`, `mcorten87\rabbitmq_api\jobs\JobExchangeDelete`, `mcorten87\rabbitmq_api\jobs\JobExchangeList`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
44			'vhost' => $job->getVirtualHost(),
			0 ignored issues – show Bug introduced 2016-09-28 18:25 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getVirtualHost()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\jobs\JobBindingCreate`, `mcorten87\rabbitmq_api\jobs\JobExchangeCreate`, `mcorten87\rabbitmq_api\jobs\JobExchangeDelete`, `mcorten87\rabbitmq_api\jobs\JobExchangeList`, `mcorten87\rabbitmq_api\j...ExchangeListVirtualHost`, `mcorten87\rabbitmq_api\jobs\JobPermissionCreate`, `mcorten87\rabbitmq_api\jobs\JobPermissionDelete`, `mcorten87\rabbitmq_api\j...rmissionListVirtualHost`, `mcorten87\rabbitmq_api\jobs\JobQueueCreate`, `mcorten87\rabbitmq_api\jobs\JobQueueDelete`, `mcorten87\rabbitmq_api\jobs\JobQueueList`, `mcorten87\rabbitmq_api\j...JobQueueListVirtualHost`, `mcorten87\rabbitmq_api\jobs\JobVirtualHostCreate`, `mcorten87\rabbitmq_api\jobs\JobVirtualHostDelete`, `mcorten87\rabbitmq_api\jobs\JobVirtualHostList`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
45			];
46
47			foreach ($job->getArguments() as $argument) {
			0 ignored issues – show Bug introduced 2016-09-28 18:25 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getArguments()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\jobs\JobExchangeCreate`, `mcorten87\rabbitmq_api\jobs\JobQueueCreate`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
48			$body['arguments'][$argument->getArgumentName()] = $argument->getValue();
49			};
50
51			return array_merge(parent::mapConfig($job), [
52			'json' => $body,
53			]);
54			}
55			}
56

mcorten / rabbitmq_api

Branch — master (1abd51)

JoBindingCreateMapper::mapConfig() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like