ExchangeArgument::validate() - Code Metrics - Inspection of "scrutenizer does not allow 7.0 as version" - mcorten/rabbitmq_api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (028697)

by Mathijs

created 2016-09-26 18:56 UTC

ExchangeArgument::validate() A

↳ Parent: ExchangeArgument

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	8
nc	3
nop	1

<?php

namespace mcorten87\rabbitmq_api\objects;

class ExchangeArgument extends BaseObject
{
    /**
     * @var integer
     * If messages to this exchange cannot otherwise be routed, send them to the alternate exchange named here.
     */
    const ALTERNATE_EXCHAGE = 'alternate-exchange';


    private $argumentName;

    /**
     * @return String
     */
    public function getArgumentName()
    {
        return $this->argumentName;
    }

    public function __construct(String $argument, string $value)
    {
        $this->argumentName = $argument;

        parent::__construct($value);
    }

    public function validate($value) : bool
    {
        if (empty($this->getArgumentName())) {
            return false;
        }


        switch ($this->argumentName) {
            case self::ALTERNATE_EXCHAGE:
                return true;

            default :
switch ($expr) {
    default : //wrong
        doSomething();
        break;
}

switch ($expr) {
    default: //right
        doSomething();
        break;
}
                throw new \RuntimeException('Argument not supported');
        }
    }
}


1			<?php
2
3			namespace mcorten87\rabbitmq_api\objects;
4
5			class ExchangeArgument extends BaseObject
6			{
7			/**
8			* @var integer
9			* If messages to this exchange cannot otherwise be routed, send them to the alternate exchange named here.
10			*/
11			const ALTERNATE_EXCHAGE = 'alternate-exchange';
12
13
14			private $argumentName;
15
16			/**
17			* @return String
18			*/
19			public function getArgumentName()
20			{
21			return $this->argumentName;
22			}
23
24			public function __construct(String $argument, string $value)
25			{
26			$this->argumentName = $argument;
27
28			parent::__construct($value);
29			}
30
31			public function validate($value) : bool
32			{
33			if (empty($this->getArgumentName())) {
34			return false;
35			}
36
37
38			switch ($this->argumentName) {
39			case self::ALTERNATE_EXCHAGE:
40			return true;
41
42			default :
			0 ignored issues – show Coding Style introduced 2016-09-26 19:05 UTC by Report Bug Copy Issue Report There must be no space before the colon in a DEFAULT statement As per the PSR-2 coding standard, there must not be a space in front of the colon in the default statement. switch ($expr) { default : //wrong doSomething(); break; } switch ($expr) { default: //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
43			throw new \RuntimeException('Argument not supported');
44			}
45			}
46			}
47

mcorten / rabbitmq_api

Branch — master (028697)

ExchangeArgument::validate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like