JobExchangeDeleteMapper - Code Metrics - Inspection of "scrutenizer does not allow 7.0 as version" - mcorten/rabbitmq_api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (028697)

by Mathijs

created 2016-09-26 18:56 UTC

JobExchangeDeleteMapper A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	2
lcom	0
cbo	3
dl	0
loc	22
rs	10
c	1
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	mapMethod()	0	3	1
A	mapUrl()	0	6	1

<?php

namespace mcorten87\rabbitmq_api\mappers;

use mcorten87\rabbitmq_api\jobs\JobBase;
use mcorten87\rabbitmq_api\jobs\JobExchangeList;
use mcorten87\rabbitmq_api\jobs\JobExchangeListVirtualHost;
use mcorten87\rabbitmq_api\jobs\JobUserList;
use mcorten87\rabbitmq_api\objects\Method;
use mcorten87\rabbitmq_api\objects\Url;
use mcorten87\rabbitmq_api\services\MqManagementConfig;

class JobExchangeDeleteMapper  extends BaseMapper

{

    /**
     * @param JobUserList $job
     * @return Method
     */
    protected function mapMethod(JobBase $job) : Method {
        return new Method(Method::METHOD_DELETE);
    }

    /**
     * @param JobExchangeList $job
     * @return Url
     */
    protected function mapUrl(JobBase $job) : Url {
        $url = 'exchanges';
        $url .= '/'.urlencode($job->getVirtualHost());
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $url .= '/'.urlencode($job->getExchangeName());
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        return new Url($url);
    }
}


Branch — master (028697)

JobExchangeDeleteMapper A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Available Fixes

1			<?php
2
3			namespace mcorten87\rabbitmq_api\mappers;
4
5			use mcorten87\rabbitmq_api\jobs\JobBase;
6			use mcorten87\rabbitmq_api\jobs\JobExchangeList;
7			use mcorten87\rabbitmq_api\jobs\JobExchangeListVirtualHost;
8			use mcorten87\rabbitmq_api\jobs\JobUserList;
9			use mcorten87\rabbitmq_api\objects\Method;
10			use mcorten87\rabbitmq_api\objects\Url;
11			use mcorten87\rabbitmq_api\services\MqManagementConfig;
12
13			class JobExchangeDeleteMapper extends BaseMapper
			0 ignored issues – show Coding Style introduced 2016-09-26 19:05 UTC by Report Bug Copy Issue Report Expected 1 space after class name; 2 found Loading history... Coding Style introduced 2016-09-26 19:05 UTC by Report Bug Copy Issue Report Expected 1 space before extends keyword; 2 found Loading history...
14			{
15
16			/**
17			* @param JobUserList $job
18			* @return Method
19			*/
20			protected function mapMethod(JobBase $job) : Method {
21			return new Method(Method::METHOD_DELETE);
22			}
23
24			/**
25			* @param JobExchangeList $job
26			* @return Url
27			*/
28			protected function mapUrl(JobBase $job) : Url {
29			$url = 'exchanges';
30			$url .= '/'.urlencode($job->getVirtualHost());
			0 ignored issues – show Bug introduced 2016-09-26 19:05 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getVirtualHost()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\jobs\JobExchangeCreate`, `mcorten87\rabbitmq_api\jobs\JobExchangeDelete`, `mcorten87\rabbitmq_api\jobs\JobExchangeList`, `mcorten87\rabbitmq_api\j...ExchangeListVirtualHost`, `mcorten87\rabbitmq_api\jobs\JobPermissionCreate`, `mcorten87\rabbitmq_api\jobs\JobPermissionDelete`, `mcorten87\rabbitmq_api\j...rmissionListVirtualHost`, `mcorten87\rabbitmq_api\jobs\JobQueueCreate`, `mcorten87\rabbitmq_api\jobs\JobQueueDelete`, `mcorten87\rabbitmq_api\jobs\JobQueueList`, `mcorten87\rabbitmq_api\j...JobQueueListVirtualHost`, `mcorten87\rabbitmq_api\jobs\JobVirtualHostCreate`, `mcorten87\rabbitmq_api\jobs\JobVirtualHostDelete`, `mcorten87\rabbitmq_api\jobs\JobVirtualHostList`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
31			$url .= '/'.urlencode($job->getExchangeName());
			0 ignored issues – show Bug introduced 2016-09-26 19:05 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getExchangeName()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\jobs\JobExchangeCreate`, `mcorten87\rabbitmq_api\jobs\JobExchangeDelete`, `mcorten87\rabbitmq_api\jobs\JobExchangeList`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
32			return new Url($url);
33			}
34			}
35

mcorten / rabbitmq_api

Branch — master (028697)

JobExchangeDeleteMapper A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like