JobBindingCreateToQueueMapper - Code Metrics - Inspection of "added a way to create a binding from exchange to a..." - mcorten/rabbitmq_api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 936d36...d74745 )

by Mathijs

created 2016-09-28 19:49 UTC

JobBindingCreateToQueueMapper A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
wmc	3
lcom	0
cbo	3
dl	0
loc	41
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	mapMethod()	4	1
A	mapUrl()	10	1
A	mapConfig()	14	1

<?php

namespace mcorten87\rabbitmq_api\mappers;


use mcorten87\rabbitmq_api\jobs\JobBase;
use mcorten87\rabbitmq_api\jobs\JobBindingCreateToQueue;
use mcorten87\rabbitmq_api\objects\Method;
use mcorten87\rabbitmq_api\objects\Url;
use mcorten87\rabbitmq_api\services\MqManagementConfig;

class JobBindingCreateToQueueMapper extends BaseMapper
{
    protected function mapMethod(JobBase $job) : Method
    {
        return new Method(Method::METHOD_POST);
    }

    /**
     * @param JobBindingCreateToQueue $job
     * @return Url
     */
    protected function mapUrl(JobBase $job) : Url
    {
        return new Url('bindings/'
            .urlencode($job->getVirtualHost()).'/'
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            .'e/'
            .urlencode($job->getExchangeName()).'/'
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            .$job->getDestinationType().'/'
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            .urlencode($job->getQueueName())
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        );
    }

    /**
     * @param JobBindingCreateToQueue $job
     * @return array
     */
    protected function mapConfig(JobBase $job) : array {
        $body = [
            'arguments'         => [],
            'destination'       => (string)$job->getQueueName(),
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'destination_type'  => $job->getDestinationType(),
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'routing_key'       => (string)$job->getRoutingKey(),
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'source'            => (string)$job->getExchangeName(),
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'vhost'             => $job->getVirtualHost(),
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        ];

        return array_merge(parent::mapConfig($job), [
            'json'      =>  $body,
        ]);
    }
}


Push — master ( 936d36...d74745 )

JobBindingCreateToQueueMapper A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace mcorten87\rabbitmq_api\mappers;
4
5
6			use mcorten87\rabbitmq_api\jobs\JobBase;
7			use mcorten87\rabbitmq_api\jobs\JobBindingCreateToQueue;
8			use mcorten87\rabbitmq_api\objects\Method;
9			use mcorten87\rabbitmq_api\objects\Url;
10			use mcorten87\rabbitmq_api\services\MqManagementConfig;
11
12			class JobBindingCreateToQueueMapper extends BaseMapper
13			{
14			protected function mapMethod(JobBase $job) : Method
15			{
16			return new Method(Method::METHOD_POST);
17			}
18
19			/**
20			* @param JobBindingCreateToQueue $job
21			* @return Url
22			*/
23			protected function mapUrl(JobBase $job) : Url
24			{
25			return new Url('bindings/'
26			.urlencode($job->getVirtualHost()).'/'
			0 ignored issues – show Bug introduced 2016-09-28 19:51 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getVirtualHost()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\j...JobBindingCreateToQueue`, `mcorten87\rabbitmq_api\jobs\JobExchangeCreate`, `mcorten87\rabbitmq_api\jobs\JobExchangeDelete`, `mcorten87\rabbitmq_api\jobs\JobExchangeList`, `mcorten87\rabbitmq_api\j...ExchangeListVirtualHost`, `mcorten87\rabbitmq_api\jobs\JobPermissionCreate`, `mcorten87\rabbitmq_api\jobs\JobPermissionDelete`, `mcorten87\rabbitmq_api\j...rmissionListVirtualHost`, `mcorten87\rabbitmq_api\jobs\JobQueueCreate`, `mcorten87\rabbitmq_api\jobs\JobQueueDelete`, `mcorten87\rabbitmq_api\jobs\JobQueueList`, `mcorten87\rabbitmq_api\j...JobQueueListVirtualHost`, `mcorten87\rabbitmq_api\jobs\JobVirtualHostCreate`, `mcorten87\rabbitmq_api\jobs\JobVirtualHostDelete`, `mcorten87\rabbitmq_api\jobs\JobVirtualHostList`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
27			.'e/'
28			.urlencode($job->getExchangeName()).'/'
			0 ignored issues – show Bug introduced 2016-09-28 19:51 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getExchangeName()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\j...JobBindingCreateToQueue`, `mcorten87\rabbitmq_api\jobs\JobExchangeCreate`, `mcorten87\rabbitmq_api\jobs\JobExchangeDelete`, `mcorten87\rabbitmq_api\jobs\JobExchangeList`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
29			.$job->getDestinationType().'/'
			0 ignored issues – show Bug introduced 2016-09-28 19:51 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getDestinationType()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\j...JobBindingCreateToQueue`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
30			.urlencode($job->getQueueName())
			0 ignored issues – show Bug introduced 2016-09-28 19:51 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getQueueName()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\j...JobBindingCreateToQueue`, `mcorten87\rabbitmq_api\jobs\JobQueueCreate`, `mcorten87\rabbitmq_api\jobs\JobQueueDelete`, `mcorten87\rabbitmq_api\jobs\JobQueueList`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
31			);
32			}
33
34			/**
35			* @param JobBindingCreateToQueue $job
36			* @return array

mcorten / rabbitmq_api

Push — master ( 936d36...d74745 )

JobBindingCreateToQueueMapper A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like