JobUserCreateMapper - Code Metrics - mcorten/rabbitmq_api - Measure and Improve Code Quality continuously with Scrutinizer

JobUserCreateMapper A
last analyzed 2018-03-02 12:35 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	5
lcom	0
cbo	3
dl	0
loc	40
ccs	14
cts	14
cp	1
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	mapMethod()	4	1
A	mapUrl()	7	1
A	mapConfig()	16	3

<?php
declare(strict_types=1);
namespace mcorten87\rabbitmq_api\mappers;

use mcorten87\rabbitmq_api\jobs\JobBase;
use mcorten87\rabbitmq_api\jobs\JobUserCreate;
use mcorten87\rabbitmq_api\objects\Method;
use mcorten87\rabbitmq_api\objects\Url;

class JobUserCreateMapper extends BaseMapper
{
    protected function mapMethod() : Method
    {
        return new Method(Method::PUT);
    }

    /**
     * @param JobUserCreate $job
     * @return Url
     */
    protected function mapUrl(JobBase $job) : Url
    {
        $url = 'users';
        $url .= '/'.urlencode((string)$job->getUser());
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        return new Url($url);
    }

    /**
     * @param JobUserCreate $job
     * @return array
     */
    protected function mapConfig(JobBase $job) : array
    {
        $body = [
            'tags' => implode($job->getUserTags(), ','),
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        ];

        if ($job->hasPassword()) {
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $body['password'] = $job->getPassword()->getValue();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        } elseif ($job->hasPasswordHash()) {
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $body['password_hash'] = $job->getPasswordHash()->getValue();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }

        return array_merge(parent::mapConfig($job), [
            'json'      =>  $body,
        ]);
    }
}


JobUserCreateMapper A
last analyzed 2018-03-02 12:35 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2		declare(strict_types=1);
3		namespace mcorten87\rabbitmq_api\mappers;
4
5		use mcorten87\rabbitmq_api\jobs\JobBase;
6		use mcorten87\rabbitmq_api\jobs\JobUserCreate;
7		use mcorten87\rabbitmq_api\objects\Method;
8		use mcorten87\rabbitmq_api\objects\Url;
9
10		class JobUserCreateMapper extends BaseMapper
11		{
12	3	protected function mapMethod() : Method
13		{
14	3	return new Method(Method::PUT);
15		}
16
17		/**
18		* @param JobUserCreate $job
19		* @return Url
20		*/
21	3	protected function mapUrl(JobBase $job) : Url
22		{
23	3	$url = 'users';
24	3	$url .= '/'.urlencode((string)$job->getUser());
		0 ignored issues – show Bug introduced 2017-08-26 17:32 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getUser()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\jobs\JobPermissionCreate`, `mcorten87\rabbitmq_api\jobs\JobPermissionDelete`, `mcorten87\rabbitmq_api\jobs\JobPermissionListUser`, `mcorten87\rabbitmq_api\jobs\JobUserCreate`, `mcorten87\rabbitmq_api\jobs\JobUserDelete`, `mcorten87\rabbitmq_api\jobs\JobUserList`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
25
26	3	return new Url($url);
27		}
28
29		/**
30		* @param JobUserCreate $job
31		* @return array
32		*/
33	3	protected function mapConfig(JobBase $job) : array
34		{
35		$body = [
36	3	'tags' => implode($job->getUserTags(), ','),
		0 ignored issues – show Bug introduced 2016-06-10 22:14 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getUserTags()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\jobs\JobUserCreate`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
37		];
38
39	3	if ($job->hasPassword()) {
		0 ignored issues – show Bug introduced 2016-06-10 22:14 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `hasPassword()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\jobs\JobUserCreate`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
40	2	$body['password'] = $job->getPassword()->getValue();
		0 ignored issues – show Bug introduced 2016-07-04 19:16 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getPassword()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\jobs\JobUserCreate`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
41	2	} elseif ($job->hasPasswordHash()) {
		0 ignored issues – show Bug introduced 2016-06-29 19:29 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `hasPasswordHash()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\jobs\JobUserCreate`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
42	2	$body['password_hash'] = $job->getPasswordHash()->getValue();
		0 ignored issues – show Bug introduced 2016-07-04 19:16 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getPasswordHash()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\jobs\JobUserCreate`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
43		}
44
45	3	return array_merge(parent::mapConfig($job), [
46	3	'json' => $body,
47		]);
48		}
49		}
50

mcorten / rabbitmq_api

JobUserCreateMapper A last analyzed 2018-03-02 12:35 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

JobUserCreateMapper A
last analyzed 2018-03-02 12:35 UTC