JobClusterNameUpdateMapper - Code Metrics - mcorten/rabbitmq_api - Measure and Improve Code Quality continuously with Scrutinizer

JobClusterNameUpdateMapper A
last analyzed 2018-03-02 12:35 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	3
lcom	0
cbo	3
dl	0
loc	36
ccs	9
cts	9
cp	1
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	mapMethod()	4	1
A	mapUrl()	5	1
A	mapConfig()	10	1

<?php
declare(strict_types=1);
namespace mcorten87\rabbitmq_api\mappers;

use mcorten87\rabbitmq_api\jobs\JobBase;
use mcorten87\rabbitmq_api\jobs\JobClusterNameUpdate;
use mcorten87\rabbitmq_api\objects\Method;
use mcorten87\rabbitmq_api\objects\Url;

class JobClusterNameUpdateMapper extends BaseMapper
{

    /**
     * @return Method
     */
    protected function mapMethod() : Method
    {
        return new Method(Method::PUT);
    }

    /**
     * @param JobClusterNameUpdate $job
     * @return Url
     */
    protected function mapUrl(JobBase $job) : Url
    {
        $url = 'cluster-name';
        return new Url($url);
    }

    /**
     * @param JobClusterNameUpdate $job
     * @return array
     */
    protected function mapConfig(JobBase $job): array
    {
        $body = [
            'name' => $job->getName(),
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        ];

        return array_merge(parent::mapConfig($job), [
            'json'      =>  $body,
        ]);
    }
}


1		<?php
2		declare(strict_types=1);
3		namespace mcorten87\rabbitmq_api\mappers;
4
5		use mcorten87\rabbitmq_api\jobs\JobBase;
6		use mcorten87\rabbitmq_api\jobs\JobClusterNameUpdate;
7		use mcorten87\rabbitmq_api\objects\Method;
8		use mcorten87\rabbitmq_api\objects\Url;
9
10		class JobClusterNameUpdateMapper extends BaseMapper
11		{
12
13		/**
14		* @return Method
15		*/
16	1	protected function mapMethod() : Method
17		{
18	1	return new Method(Method::PUT);
19		}
20
21		/**
22		* @param JobClusterNameUpdate $job
23		* @return Url
24		*/
25	1	protected function mapUrl(JobBase $job) : Url
26		{
27	1	$url = 'cluster-name';
28	1	return new Url($url);
29		}
30
31		/**
32		* @param JobClusterNameUpdate $job
33		* @return array
34		*/
35	1	protected function mapConfig(JobBase $job): array
36		{
37		$body = [
38	1	'name' => $job->getName(),
		0 ignored issues – show Bug introduced 2017-11-14 19:46 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `mcorten87\rabbitmq_api\jobs\JobBase` as the method `getName()` does only exist in the following sub-classes of `mcorten87\rabbitmq_api\jobs\JobBase`: `mcorten87\rabbitmq_api\jobs\JobClusterNameUpdate`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
39		];
40
41	1	return array_merge(parent::mapConfig($job), [
42	1	'json' => $body,
43		]);
44		}
45		}
46

mcorten / rabbitmq_api

JobClusterNameUpdateMapper A last analyzed 2018-03-02 12:35 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like

JobClusterNameUpdateMapper A
last analyzed 2018-03-02 12:35 UTC