Mcneely\Core\Traits\ArrayAccessTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	offsetExists()	0	7	1
A	offsetUnset()	0	9	1
A	offsetGet()	0	7	1
A	offsetSet()	0	10	1
A	ArrayAccessTrait_unwrap()	0	5	1

<?php

declare(strict_types=1);

namespace Mcneely\Core\Traits;

use ArrayAccess;
use Mcneely\Core\CoreObject;

/**
 * Trait ArrayAccessTrait.
 *
 * @package Mcneely\Core\Traits
 *
 * @method mixed setCoreObject_CoreTrait()
 * @method CoreObject CoreTrait_getCoreObject()
 * @method mixed fireEvents_CoreTrait($eventClassObject, $eventImmediateClass, $eventMethod, $eventTrait)
 */
trait ArrayAccessTrait
{
    public function offsetExists($offset)
    {
        $this->CoreTrait_fireEvents($this, __CLASS__, __METHOD__, __TRAIT__);

It seems like CoreTrait_fireEvents() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $this
            ->ArrayAccessTrait_unwrap()
            ->offsetExists($offset)
            ;
    }

    protected function ArrayAccessTrait_unwrap(): ArrayAccess
    {
        return $this

The expression return $this->CoreTrait_getCoreObject()->unWrap(ArrayAccess::class) could return the type Traversable which is incompatible with the type-hinted return ArrayAccess. Consider adding an additional type-check to rule them out.

            ->CoreTrait_getCoreObject()
            ->unWrap(ArrayAccess::class)
            ;
    }

    public function offsetGet($offset)
    {
        $this->CoreTrait_fireEvents($this, __CLASS__, __METHOD__, __TRAIT__);

        return $this
            ->ArrayAccessTrait_unwrap()
            ->offsetGet($offset)
            ;
    }

    public function offsetSet($offset, $value)
    {
        $this->CoreTrait_fireEvents($this, __CLASS__, __METHOD__, __TRAIT__);

        $this
            ->ArrayAccessTrait_unwrap()
            ->offsetSet($offset, $value)
        ;

        return $this;
    }

    public function offsetUnset($offset)
    {
        $this->CoreTrait_fireEvents($this, __CLASS__, __METHOD__, __TRAIT__);
        $this
            ->ArrayAccessTrait_unwrap()
            ->offsetUnset($offset)
        ;

        return $this;
    }
}