LocaleCookieRedirect - Code Metrics - mcamara/laravel-localization - Measure and Improve Code Quality continuously with Scrutinizer

LocaleCookieRedirect A
last analyzed 2019-03-05 15:43 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
wmc	7
lcom	0
cbo	3
dl	0
loc	34
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	handle()	0	22	7

<?php namespace Mcamara\LaravelLocalization\Middleware;

use Closure;
use Illuminate\Http\RedirectResponse;

class LocaleCookieRedirect extends LaravelLocalizationMiddlewareBase
{

    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  \Closure $next
     *
     * @return mixed
     */
     public function handle($request, Closure $next) {
         // If the URL of the request is in exceptions.
         if ($this->shouldIgnore($request)) {
             return $next($request);
         }

         $params = explode('/', $request->path());
         $locale = $request->cookie('locale', false);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

         if (\count($params) > 0 && app('laravellocalization')->checkLocaleInSupportedLocales($params[0])) {
            return $next($request)->withCookie(cookie()->forever('locale', $params[0]));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
         }

         if ($locale && app('laravellocalization')->checkLocaleInSupportedLocales($locale) && !(app('laravellocalization')->isHiddenDefault($locale))) {
           $redirection = app('laravellocalization')->getLocalizedURL($locale);
           $redirectResponse = new RedirectResponse($redirection, 302, ['Vary' => 'Accept-Language']);

           return $redirectResponse->withCookie(cookie()->forever('locale', $params[0]));
         }

         return $next($request);
     }
}


GitHub Access Token became invalid

LocaleCookieRedirect A
last analyzed 2019-03-05 15:43 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Available Fixes

1			<?php namespace Mcamara\LaravelLocalization\Middleware;
2
3			use Closure;
4			use Illuminate\Http\RedirectResponse;
5
6			class LocaleCookieRedirect extends LaravelLocalizationMiddlewareBase
7			{
8
9			/**
10			* Handle an incoming request.
11			*
12			* @param \Illuminate\Http\Request $request
13			* @param \Closure $next
14			*
15			* @return mixed
16			*/
17			public function handle($request, Closure $next) {
18			// If the URL of the request is in exceptions.
19			if ($this->shouldIgnore($request)) {
20			return $next($request);
21			}
22
23			$params = explode('/', $request->path());
24			$locale = $request->cookie('locale', false);
			0 ignored issues – show Documentation introduced 2015-12-23 19:53 UTC by Report Bug Copy Issue Report `false` is of type `boolean`, but the function expects a `string\|array\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
25
26			if (\count($params) > 0 && app('laravellocalization')->checkLocaleInSupportedLocales($params[0])) {
27			return $next($request)->withCookie(cookie()->forever('locale', $params[0]));
			0 ignored issues – show Bug introduced 2017-10-16 06:10 UTC by Report Bug Copy Issue Report The method `forever` does only exist in `Illuminate\Cookie\CookieJar`, but not in `Symfony\Component\HttpFoundation\Cookie`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
28			}
29
30			if ($locale && app('laravellocalization')->checkLocaleInSupportedLocales($locale) && !(app('laravellocalization')->isHiddenDefault($locale))) {
31			$redirection = app('laravellocalization')->getLocalizedURL($locale);
32			$redirectResponse = new RedirectResponse($redirection, 302, ['Vary' => 'Accept-Language']);
33
34			return $redirectResponse->withCookie(cookie()->forever('locale', $params[0]));
35			}
36
37			return $next($request);
38			}
39			}
40

mcamara / laravel-localization

GitHub Access Token became invalid

LocaleCookieRedirect A last analyzed 2019-03-05 15:43 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Available Fixes

Duplication Side-by-Side

Filter issues like

LocaleCookieRedirect A
last analyzed 2019-03-05 15:43 UTC