tcllib.tclrequest

Complexity

Total Complexity

12

Size/Duplication

Total Lines	103
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	TclRequestMixin.get_salt()	0	5	1
B	TclRequestMixin.do_request()	0	30	3
A	TclRequestMixin.get_vk2()	0	13	3
B	TclRequestMixin.parse_request()	0	17	5

# -*- coding: utf-8 -*-

This module should have a docstring.

import binascii
import hashlib
import random
import time
from math import floor
import zlib
from collections import OrderedDict
from defusedxml import ElementTree

'''
    private HashMap<String, String> buildDownloadUrisParams(UpdatePackageInfo updatePackageInfo) {

This line is too long as per the coding-style (98/80).

        FotaLog.m28v(TAG, "doAfterCheck");
        String salt = FotaUtil.salt();
        HashMap linkedHashMap = new LinkedHashMap();
        linkedHashMap.put("id", this.internalBuilder.getParam("id"));
        linkedHashMap.put("salt", salt);
        linkedHashMap.put("curef", updatePackageInfo.mCuref);
        linkedHashMap.put("fv", updatePackageInfo.mFv);
        linkedHashMap.put("tv", updatePackageInfo.mTv);
        linkedHashMap.put("type", "Firmware");
        linkedHashMap.put("fw_id", updatePackageInfo.mFirmwareId);
        linkedHashMap.put("mode", "2");
        linkedHashMap.put("vk", generateVk2((LinkedHashMap) linkedHashMap.clone()));

This line is too long as per the coding-style (84/80).

        linkedHashMap.put("cltp", "10");
        linkedHashMap.put("cktp", this.internalBuilder.getParam("cktp"));
        linkedHashMap.put("rtd", this.internalBuilder.getParam("rtd"));
        linkedHashMap.put("chnl", this.internalBuilder.getParam("chnl"));
        return linkedHashMap;
    }
'''

This string statement has no effect and could be removed.

class TclRequestMixin:

This class should have a docstring.

The variable __class__ seems to be unused.

    @staticmethod
    def get_salt():

This method should have a docstring.

        millis = floor(time.time() * 1000)
        tail = "{:06d}".format(random.randint(0, 999999))
        return "{}{}".format(str(millis), tail)

    def get_vk2(self, params_dict, cltp):

This method should have a docstring.

        params_dict["cltp"] = cltp
        query = ""
        for k, v in params_dict.items():

The name v does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            if len(query) > 0:

Do not use len(SEQUENCE) as condition value

                query += "&"
            query += k + "=" + str(v)
        vdk = zlib.decompress(binascii.a2b_base64(self.VDKEY))
        query += vdk.decode("utf-8")
        engine = hashlib.sha1()
        engine.update(bytes(query, "utf-8"))
        hexhash = engine.hexdigest()
        return hexhash

    def do_request(self, curef, fv, tv, fw_id):

The name fv does not conform to the argument naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The name tv does not conform to the argument naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

This method should have a docstring.

        url = "https://" + self.g2master + "/download_request.php"
        params = OrderedDict()
        params["id"]    = self.serid

Exactly one space required before assignment

        params["salt"]  = self.get_salt()

Exactly one space required before assignment

        params["curef"] = curef
        params["fv"]    = fv

Exactly one space required before assignment

        params["tv"]    = tv

Exactly one space required before assignment

        params["type"]  = self.ftype

Exactly one space required before assignment

        params["fw_id"] = fw_id
        params["mode"]  = self.mode.value

Exactly one space required before assignment

        params["vk"]    = self.get_vk2(params, self.cltp.value)

Exactly one space required before assignment

        params["cltp"]  = self.cltp.value

Exactly one space required before assignment

        params["cktp"]  = self.cktp.value

Exactly one space required before assignment

        params["rtd"]   = self.rtd.value

Exactly one space required before assignment

        if self.mode == self.MODE.FULL:
            params["foot"]  = 1

Exactly one space required before assignment

        params["chnl"]  = self.chnl.value

Exactly one space required before assignment

        #print(repr(dict(params)))
        req = self.sess.post(url, data=params)
        if req.status_code == 200:
            req.encoding = "utf-8"    # Force encoding as server doesn't give one

This line is too long as per the coding-style (81/80).

            self.write_dump(req.text)
            return req.text
        else:
            print("REQUEST: " + repr(req))
            print(repr(req.headers))
            print(repr(req.text))
            raise SystemExit

    @staticmethod
    def parse_request(xmlstr):

This method should have a docstring.

        root = ElementTree.fromstring(xmlstr)
        file = root.find("FILE_LIST").find("FILE")
        fileid  = file.find("FILE_ID").text

Exactly one space required before assignment

        fileurl = file.find("DOWNLOAD_URL").text
        s3_fileurl_node = file.find("S3_DOWNLOAD_URL")
        s3_fileurl = ""
        if s3_fileurl_node:
            s3_fileurl = s3_fileurl_node.text
        slave_list = root.find("SLAVE_LIST").findall("SLAVE")
        enc_list = root.find("SLAVE_LIST").findall("ENCRYPT_SLAVE")
        s3_slave_list = root.find("SLAVE_LIST").findall("S3_SLAVE")
        slaves = [s.text for s in slave_list]
        encslaves = [s.text for s in enc_list]
        s3_slaves = [s.text for s in s3_slave_list]
        return fileid, fileurl, slaves, encslaves, s3_fileurl, s3_slaves