tcllib.tclcheck

Complexity

Total Complexity

10

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	TclCheckMixin.parse_check()	0	13	1
F	TclCheckMixin.do_check()	0	48	9

# -*- coding: utf-8 -*-

This module should have a docstring.

import time
from collections import OrderedDict
import requests
from defusedxml import ElementTree

class TclCheckMixin:

This class should have a docstring.

The variable __class__ seems to be unused.

    def do_check(self, https=True, timeout=10, max_tries=5):

This method should have a docstring.

        protocol = "https://" if https else "http://"
        url = protocol + self.g2master + "/check.php"
        params = OrderedDict()
        params["id"]    = self.serid

Exactly one space required before assignment

        params["curef"] = self.curef
        params["fv"]    = self.fv

Exactly one space required before assignment

        params["mode"]  = self.mode.value

Exactly one space required before assignment

        params["type"]  = self.ftype

Exactly one space required before assignment

        params["cltp"]  = self.cltp.value

Exactly one space required before assignment

        params["cktp"]  = self.cktp.value

Exactly one space required before assignment

        params["rtd"]   = self.rtd.value

Exactly one space required before assignment

        params["chnl"]  = self.chnl.value

Exactly one space required before assignment

        #params["osvs"]  = self.osvs
        #params["ckot"]  = self.ckot.value

        last_response = None
        for num_try in range(0, max_tries):

The variable num_try seems to be unused.

            try:
                reqtime_start = time.perf_counter()
                req = self.sess.get(url, params=params, timeout=timeout)
                reqtime = time.perf_counter() - reqtime_start
                reqtime_avg = self.check_time_avg()
                self.check_time_add(reqtime)
                last_response = req
                if req.status_code == 200:
                    self.master_server_vote_on_time(reqtime, reqtime_avg)
                    req.encoding = "utf-8"    # Force encoding as server doesn't give one

This line is too long as per the coding-style (89/80).

                    self.write_dump(req.text)
                    return req.text
                elif req.status_code == 204:
                    self.master_server_vote_on_time(reqtime, reqtime_avg)
                    raise requests.exceptions.HTTPError("No update available.", response=req)

This line is too long as per the coding-style (93/80).

                elif req.status_code == 404:
                    self.master_server_vote_on_time(reqtime, reqtime_avg)
                    raise requests.exceptions.HTTPError("No data for requested CUREF/FV combination.", response=req)

This line is too long as per the coding-style (116/80).

                elif req.status_code not in [500, 502, 503]:
                    self.master_server_downvote()
                    req.raise_for_status()
                    raise requests.exceptions.HTTPError("HTTP {}.".format(req.status_code), response=req)

This line is too long as per the coding-style (105/80).

            except requests.exceptions.Timeout:
                pass
            # Something went wrong, try a different server
            self.master_server_downvote()
            self.g2master = self.get_master_server()
            protocol = "https://" if https else "http://"
            url = protocol + self.g2master + "/check.php"
        raise requests.exceptions.RetryError("Max tries ({}) reached.".format(max_tries), response=last_response)

This line is too long as per the coding-style (113/80).

    @staticmethod
    def parse_check(xmlstr):

This method should have a docstring.

        root = ElementTree.fromstring(xmlstr)
        curef = root.find("CUREF").text
        fv = root.find("VERSION").find("FV").text

The name fv does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        tv = root.find("VERSION").find("TV").text

The name tv does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

        fw_id = root.find("FIRMWARE").find("FW_ID").text
        fileinfo = root.find("FIRMWARE").find("FILESET").find("FILE")
        fileid   = fileinfo.find("FILE_ID").text

Exactly one space required before assignment

        filename = fileinfo.find("FILENAME").text
        filesize = fileinfo.find("SIZE").text
        filehash = fileinfo.find("CHECKSUM").text
        return curef, fv, tv, fw_id, fileid, filename, filesize, filehash