tcllib.servervote - Code Metrics - Inspection of "Make pylint happy." - mbirth/tcl_ota_check - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 2f86f7...74d48b )

by Markus

created 2018-02-03 12:46 UTC

tcllib.servervote A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Importance

Changes

Metric	Value
eloc	41
dl	0
loc	51
rs	10
c	0
b	0
f	0
wmc	13

7 Methods

Rating	Name	Size	Complexity
A	ServerVoteMixin.master_server_downvote()	4	2
A	ServerVoteMixin.check_time_add()	3	1
A	ServerVoteMixin.master_server_upvote()	4	2
A	ServerVoteMixin.get_master_server()	8	3
A	ServerVoteMixin.master_server_vote_on_time()	5	3
A	ServerVoteMixin.check_time_avg()	2	1
A	ServerVoteMixin.__init__()	13	1

# -*- coding: utf-8 -*-
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

import numpy

class ServerVoteMixin:
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def __init__(self):
        self.g2master = None
        self.master_servers = [
            "g2master-us-east.tclclouds.com",
            "g2master-us-west.tclclouds.com",
            "g2master-eu-west.tclclouds.com",
            "g2master-ap-south.tclclouds.com",
            "g2master-ap-north.tclclouds.com",
            "g2master-sa-east.tclclouds.com",
        ]
        self.master_servers_weights = [3] * len(self.master_servers)
        self.check_time_sum = 3
        self.check_time_count = 1

    def get_master_server(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        weight_sum = 0
        for i in self.master_servers_weights:
            weight_sum += i
        numpy_weights = []
        for i in self.master_servers_weights:
            numpy_weights.append(i/weight_sum)
        return numpy.random.choice(self.master_servers, p=numpy_weights)

    def master_server_downvote(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        idx = self.master_servers.index(self.g2master)
        if self.master_servers_weights[idx] > 1:
            self.master_servers_weights[idx] -= 1

    def master_server_upvote(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        idx = self.master_servers.index(self.g2master)
        if self.master_servers_weights[idx] < 10:
            self.master_servers_weights[idx] += 1

    def check_time_add(self, duration):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        self.check_time_sum += duration
        self.check_time_count += 1

    def check_time_avg(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        return (self.check_time_sum / self.check_time_count)


    def master_server_vote_on_time(self, last_duration, avg_duration):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        if last_duration < avg_duration - 0.5:
            self.master_server_upvote()
        elif last_duration > avg_duration + 0.5:
            self.master_server_downvote()


1			# -- coding: utf-8 --
			0 ignored issues – show Coding Style introduced 2018-02-03 12:29 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2
3			import numpy
4
5			class ServerVoteMixin:
			0 ignored issues – show Coding Style introduced 2018-02-03 12:29 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-02-03 12:29 UTC by Report Bug Copy Issue Report The variable `__class__` seems to be unused. Loading history...
6			def __init__(self):
7			self.g2master = None
8			self.master_servers = [
9			"g2master-us-east.tclclouds.com",
10			"g2master-us-west.tclclouds.com",
11			"g2master-eu-west.tclclouds.com",
12			"g2master-ap-south.tclclouds.com",
13			"g2master-ap-north.tclclouds.com",
14			"g2master-sa-east.tclclouds.com",
15			]
16			self.master_servers_weights = [3] * len(self.master_servers)
17			self.check_time_sum = 3
18			self.check_time_count = 1
19
20			def get_master_server(self):
			0 ignored issues – show Coding Style introduced 2018-02-03 12:29 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
21			weight_sum = 0
22			for i in self.master_servers_weights:
23			weight_sum += i
24			numpy_weights = []
25			for i in self.master_servers_weights:
26			numpy_weights.append(i/weight_sum)
27			return numpy.random.choice(self.master_servers, p=numpy_weights)
28
29			def master_server_downvote(self):
			0 ignored issues – show Coding Style introduced 2018-02-03 12:29 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
30			idx = self.master_servers.index(self.g2master)
31			if self.master_servers_weights[idx] > 1:
32			self.master_servers_weights[idx] -= 1
33
34			def master_server_upvote(self):
			0 ignored issues – show Coding Style introduced 2018-02-03 12:29 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
35			idx = self.master_servers.index(self.g2master)
36			if self.master_servers_weights[idx] < 10:
37			self.master_servers_weights[idx] += 1
38
39			def check_time_add(self, duration):
			0 ignored issues – show Coding Style introduced 2018-02-03 12:29 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
40			self.check_time_sum += duration
41			self.check_time_count += 1
42
43			def check_time_avg(self):
			0 ignored issues – show Coding Style introduced 2018-02-03 12:29 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
44			return (self.check_time_sum / self.check_time_count)
			0 ignored issues – show Unused Code Coding Style introduced 2018-02-03 12:29 UTC by Report Bug Copy Issue Report There is an unnecessary parenthesis after `return`. Loading history...
45
46			def master_server_vote_on_time(self, last_duration, avg_duration):
			0 ignored issues – show Coding Style introduced 2018-02-03 12:29 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
47			if last_duration < avg_duration - 0.5:
48			self.master_server_upvote()
49			elif last_duration > avg_duration + 0.5:
50			self.master_server_downvote()
51

mbirth / tcl_ota_check

Push — master ( 2f86f7...74d48b )

tcllib.servervote A

Complexity

Size/Duplication

Importance

7 Methods

Duplication Side-by-Side

Filter issues like