tcllib.dumpmgr

Complexity

Total Complexity

10

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	DumpMgrMixin.write_info_if_dumps_found()	0	9	2
A	DumpMgrMixin.__init__()	0	2	1
A	DumpMgrMixin.delete_last_dump()	0	4	2
B	DumpMgrMixin.write_dump()	0	11	5

# -*- coding: utf-8 -*-

This module should have a docstring.

import errno
import glob
import os
from . import ansi

class DumpMgrMixin:

This class should have a docstring.

The variable __class__ seems to be unused.

    def __init__(self):
        self.last_dump_filename = None

    def write_dump(self, data):

This method should have a docstring.

        outfile = os.path.normpath("logs/{}.xml".format(self.get_salt()))
        if not os.path.exists(os.path.dirname(outfile)):
            try:
                os.makedirs(os.path.dirname(outfile))
            except OSError as e:

The name e does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

                if e.errno != errno.EEXIST:
                    raise
        with open(outfile, "w", encoding="utf-8") as f:

The name f does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            f.write(data)
        self.last_dump_filename = outfile

    def delete_last_dump(self):

This method should have a docstring.

        if self.last_dump_filename:
            os.unlink(self.last_dump_filename)
            self.last_dump_filename = None

    @staticmethod
    def write_info_if_dumps_found():

This method should have a docstring.

        # To disable this info, uncomment the following line.
        #return
        files = glob.glob(os.path.normpath("logs/*.xml"))
        if len(files) > 0:

Do not use len(SEQUENCE) as condition value

            print()
            print("{}There are {} logs collected in the logs/ directory.{} Please consider uploading".format(ansi.YELLOW, len(files), ansi.RESET))

This line is too long as per the coding-style (146/80).

            print("them to https://tclota.birth-online.de/ by running {}./upload_logs.py{}.".format(ansi.CYAN, ansi.RESET))

This line is too long as per the coding-style (123/80).