tcllib.devlist

Complexity

Total Complexity

23

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
F	DevListMixin.print_prd_diff()	0	24	13
F	DevListMixin.get_devicelist()	0	27	10

# -*- coding: utf-8 -*-

This module should have a docstring.

import json
import os
import requests
import time

standard import "import time" should be placed before "import requests"

from . import ansi

DEVICELIST_URL = "https://tclota.birth-online.de/json_lastupdates.php"
DEVICELIST_FILE = "prds.json"
DEVICELIST_CACHE_SECONDS = 86400

class DevListMixin:

This class should have a docstring.

The variable __class__ seems to be unused.

    @staticmethod
    def get_devicelist(force=False, output_diff=True):

This method should have a docstring.

        need_download = True

        old_prds = None
        try:
            filestat = os.stat(DEVICELIST_FILE)
            filemtime = filestat.st_mtime
            if filemtime > time.time() - DEVICELIST_CACHE_SECONDS:
                need_download = False
            with open(DEVICELIST_FILE, "rt") as df:

The name df does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

                old_prds = json.load(df)
        except FileNotFoundError:
            pass

        if need_download or force:
            prds_json = requests.get(DEVICELIST_URL).text
            with open(DEVICELIST_FILE, "wt") as df:

The name df does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

                df.write(prds_json)

        with open(DEVICELIST_FILE, "rt") as df:

The name df does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            prds = json.load(df)

        if old_prds and output_diff:
            DevList.print_prd_diff(old_prds, prds)

Undefined variable 'DevList'

The variable DevList does not seem to be defined.

        return prds

    @staticmethod
    def print_prd_diff(old_prds, new_prds):

This method should have a docstring.

        added_prds = [prd for prd in new_prds if prd not in old_prds]
        removed_prds = [prd for prd in old_prds if prd not in new_prds]
        for prd in removed_prds:
            print("> Removed device {} (was at {} / OTA: {}).".format(ansi.RED + prd + ansi.RESET, old_prds[prd]["last_full"], old_prds[prd]["last_ota"]))

This line is too long as per the coding-style (154/80).

        for prd in added_prds:
            print("> New device {} ({} / OTA: {}).".format(ansi.GREEN + prd + ansi.RESET, new_prds[prd]["last_full"], new_prds[prd]["last_ota"]))

This line is too long as per the coding-style (145/80).

        for prd, pdata in new_prds.items():
            if prd in added_prds:
                continue
            odata = old_prds[prd]
            if pdata["last_full"] != odata["last_full"] and pdata["last_ota"] != odata["last_ota"]:

This line is too long as per the coding-style (99/80).

                print("> {}: {} ⇨ {} (OTA: {} ⇨ {})".format(
                    prd,
                    ansi.CYAN_DARK + str(odata["last_full"]) + ansi.RESET,
                    ansi.CYAN + str(pdata["last_full"]) + ansi.RESET,
                    ansi.YELLOW_DARK + str(odata["last_ota"]) + ansi.RESET,
                    ansi.YELLOW + str(pdata["last_ota"]) + ansi.RESET
                ))
            elif pdata["last_full"] != odata["last_full"]:
                print("> {}: {} ⇨ {} (FULL)".format(prd, ansi.CYAN_DARK + str(odata["last_full"]) + ansi.RESET, ansi.CYAN + str(pdata["last_full"]) + ansi.RESET))

This line is too long as per the coding-style (162/80).

            elif pdata["last_ota"] != odata["last_ota"]:
                print("> {}: {} ⇨ {} (OTA)".format(prd, ansi.YELLOW_DARK + str(odata["last_ota"]) + ansi.RESET, ansi.YELLOW + str(pdata["last_ota"]) + ansi.RESET))

This line is too long as per the coding-style (163/80).