tcllib.requests.tclrequest - Code Metrics - Inspection of "Merge branch 'rewrite'" - mbirth/tcl_ota_check - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 2adcb6...75d235 )

by Markus

created 2018-02-11 00:53 UTC

tcllib.requests.tclrequest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Importance

Changes

Metric	Value
wmc	5
eloc	18
dl	0
loc	27
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	TclRequest.get_headers()	2	1
A	TclRequest.is_done()	3	1
A	TclRequest.__init__()	7	1
A	TclRequest.get_params()	2	1
A	TclRequest.get_result()	3	1

# -*- coding: utf-8 -*-
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

from . import tclresult

class TclRequest:
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def __init__(self):
        self.uri = ""
        self.rawmode = False
        self.response = None
        self.result = None
        self.error = None
        self.success = False

    def get_headers(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        return {}

    def get_params(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        return {}

    def is_done(self, http_status: int, contents: str):
class Foo:
    def some_method(self, x, y):
        return x + y;
        """Checks if query is done or needs retry."""
        return False

    def get_result(self) -> tclresult.TclResult:
        """Returns Result object."""
        return self.result


1			# -- coding: utf-8 --
			0 ignored issues – show Coding Style introduced 2018-02-11 00:55 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2
3			from . import tclresult
4
5			class TclRequest:
			0 ignored issues – show Coding Style introduced 2018-02-11 00:55 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-02-11 00:55 UTC by Report Bug Copy Issue Report The variable `__class__` seems to be unused. Loading history...
6			def __init__(self):
7			self.uri = ""
8			self.rawmode = False
9			self.response = None
10			self.result = None
11			self.error = None
12			self.success = False
13
14			def get_headers(self):
			0 ignored issues – show Coding Style introduced 2018-02-11 00:55 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Coding Style introduced 2018-02-11 00:55 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
15			return {}
16
17			def get_params(self):
			0 ignored issues – show Coding Style introduced 2018-02-11 00:55 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Coding Style introduced 2018-02-11 00:55 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
18			return {}
19
20			def is_done(self, http_status: int, contents: str):
			0 ignored issues – show Unused Code introduced 2018-02-11 00:55 UTC by Report Bug Copy Issue Report The argument `http_status` seems to be unused. Loading history... Unused Code introduced 2018-02-11 00:55 UTC by Report Bug Copy Issue Report The argument `contents` seems to be unused. Loading history... Coding Style introduced 2018-02-11 00:55 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
21			"""Checks if query is done or needs retry."""
22			return False
23
24			def get_result(self) -> tclresult.TclResult:
25			"""Returns Result object."""
26			return self.result
27

mbirth / tcl_ota_check

Push — master ( 2adcb6...75d235 )

tcllib.requests.tclrequest A

Complexity

Size/Duplication

Importance

5 Methods

Duplication Side-by-Side

Filter issues like