tcllib.requests.http

Complexity

Total Complexity

6

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	HttpPostRequest.run()	0	7	2
A	HttpRequest.reset_session()	0	4	1
A	HttpRequest.__init__()	0	5	1
A	HttpRequest.run()	0	7	2

# -*- coding: utf-8 -*-

This module should have a docstring.

import requests
from collections import OrderedDict

standard import "from collections import OrderedDict" should be placed before "import requests"

class TimeoutException(Exception):

This class should have a docstring.

    pass

class HttpRequest:

The variable __class__ seems to be unused.

    """Provides all generic features for making HTTP GET requests"""
    def __init__(self, url, timeout=10):
        self.url = url
        self.params = OrderedDict()
        self.timeout = timeout
        self.headers = {}

    def reset_session(self):
        """Reset everything to default."""
        self.sess = requests.Session()

The attribute sess was defined outside __init__.

        self.sess.headers.update(self.headers)

    def run(self):
        """Run query."""
        try:
            req = self.sess.get(self.url, params=self.params, timeout=self.timeout)
        except requests.exceptions.Timeout as e:

The name e does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            raise TimeoutException(e)
        return req

class HttpPostRequest(HttpRequest):

The variable __class__ seems to be unused.

    """Provides all generic features for making HTTP POST requests"""
    def run(self):
        """Run query."""
        try:
            req = self.sess.post(self.url, data=self.params, timeout=self.timeout)
        except requests.exceptions.Timeout as e:

The name e does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

            raise TimeoutException(e)
        return req