tcllib.requests.serverselector.ServerVoteSelector.__init__() - Code Metrics - Inspection of "Merge branch 'rewrite'" - mbirth/tcl_ota_check - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 2adcb6...75d235 )

by Markus

created 2018-02-11 00:53 UTC

ServerVoteSelector.init() A

↳ Parent: tcllib.requests.serverselector

Complexity

Conditions

Size

Total Lines	6
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	5
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	1
nop	2

# -*- coding: utf-8 -*-

# pylint: disable=C0111,C0326,C0103

"""Tools to sort API servers to find the least awful one."""

import numpy
import time



MASTER_SERVERS = [
    "g2master-us-east.tclclouds.com",
    "g2master-us-west.tclclouds.com",
    "g2master-eu-west.tclclouds.com",
    "g2master-ap-south.tclclouds.com",
    "g2master-ap-north.tclclouds.com",
    "g2master-sa-east.tclclouds.com",
]

class ServerSelector:

    """Returns a random server to use."""

    def __init__(self, server_list=None):
        """Init stuff"""
        if server_list:
            self.server_list = server_list
        else:
            self.server_list = MASTER_SERVERS
        self.last_server = None

    def get_master_server(self):
        """Return a random server."""
        while True:
            new_server = numpy.random.choice(self.server_list)
            if new_server != self.last_server:
                break
        self.last_server = new_server
        return new_server

    def hook_prerequest(self):
        """Hook to be called before doing request"""
        pass

    def hook_postrequest(self, successful: bool):
        """Hook to be called after request finished"""
        pass

class ServerVoteSelector(ServerSelector):

    """Tries to return faster servers more often."""

    def __init__(self, server_list=None):
        """Populate server list and weighting variables."""
        super().__init__(server_list)
        self.servers_weights = [3] * len(self.server_list)
        self.check_time_sum = 3
        self.check_time_count = 1

    def get_master_server(self):
        """Return weighted choice from server list."""
        weight_sum = 0
        for i in self.servers_weights:
            weight_sum += i
        numpy_weights = []
        for i in self.servers_weights:
            numpy_weights.append(i/weight_sum)
        self.last_server = numpy.random.choice(self.server_list, p=numpy_weights)
        return self.last_server

    def master_server_downvote(self):
        """Decrease weight of last chosen server."""
        idx = self.server_list.index(self.last_server)
        if self.servers_weights[idx] > 1:
            self.servers_weights[idx] -= 1

    def master_server_upvote(self):
        """Increase weight of last chosen server."""
        idx = self.server_list.index(self.last_server)
        if self.servers_weights[idx] < 10:
            self.servers_weights[idx] += 1

    def check_time_add(self, duration):
        """Record connection time."""
        self.check_time_sum += duration
        self.check_time_count += 1

    def check_time_avg(self):
        """Return average connection time."""
        return self.check_time_sum / self.check_time_count

    def master_server_vote_on_time(self, last_duration):
        """Change weight of a server based on average connection time."""
        avg_duration = self.check_time_avg()
        if last_duration < avg_duration - 0.5:
            self.master_server_upvote()
        elif last_duration > avg_duration + 0.5:
            self.master_server_downvote()

    def hook_prerequest(self):
        """Hook to be called before doing request"""
        self.reqtime_start = time.perf_counter()
class Foo:
    def __init__(self, x=None):
        self.x = x

    def hook_postrequest(self, successful: bool):
        """Hook to be called after request finished"""
        reqtime = time.perf_counter() - self.reqtime_start
        self.check_time_add(reqtime)
        if successful:
            self.master_server_vote_on_time(reqtime)
        else:
            self.master_server_downvote()


1			# -- coding: utf-8 --
2
3			# pylint: disable=C0111,C0326,C0103
4
5			"""Tools to sort API servers to find the least awful one."""
6
7			import numpy
8			import time
			0 ignored issues – show introduced 2018-02-11 00:55 UTC by Report Bug Copy Issue Report standard import "import time" should be placed before "import numpy" Loading history...
9
10
11			MASTER_SERVERS = [
12			"g2master-us-east.tclclouds.com",
13			"g2master-us-west.tclclouds.com",
14			"g2master-eu-west.tclclouds.com",
15			"g2master-ap-south.tclclouds.com",
16			"g2master-ap-north.tclclouds.com",
17			"g2master-sa-east.tclclouds.com",
18			]
19
20			class ServerSelector:
			0 ignored issues – show Unused Code introduced 2018-02-11 00:55 UTC by Report Bug Copy Issue Report The variable `__class__` seems to be unused. Loading history...
21			"""Returns a random server to use."""
22
23			def __init__(self, server_list=None):
24			"""Init stuff"""
25			if server_list:
26			self.server_list = server_list
27			else:
28			self.server_list = MASTER_SERVERS
29			self.last_server = None
30
31			def get_master_server(self):
32			"""Return a random server."""
33			while True:
34			new_server = numpy.random.choice(self.server_list)
35			if new_server != self.last_server:
36			break
37			self.last_server = new_server
38			return new_server
39
40			def hook_prerequest(self):
41			"""Hook to be called before doing request"""
42			pass
43
44			def hook_postrequest(self, successful: bool):
45			"""Hook to be called after request finished"""
46			pass
47
48			class ServerVoteSelector(ServerSelector):
			0 ignored issues – show Unused Code introduced 2018-02-11 00:55 UTC by Report Bug Copy Issue Report The variable `__class__` seems to be unused. Loading history...
49			"""Tries to return faster servers more often."""
50
51			def __init__(self, server_list=None):
52			"""Populate server list and weighting variables."""
53			super().__init__(server_list)
54			self.servers_weights = [3] * len(self.server_list)
55			self.check_time_sum = 3
56			self.check_time_count = 1
57
58			def get_master_server(self):
59			"""Return weighted choice from server list."""
60			weight_sum = 0
61			for i in self.servers_weights:
62			weight_sum += i
63			numpy_weights = []
64			for i in self.servers_weights:
65			numpy_weights.append(i/weight_sum)
66			self.last_server = numpy.random.choice(self.server_list, p=numpy_weights)
67			return self.last_server
68
69			def master_server_downvote(self):
70			"""Decrease weight of last chosen server."""
71			idx = self.server_list.index(self.last_server)
72			if self.servers_weights[idx] > 1:
73			self.servers_weights[idx] -= 1
74
75			def master_server_upvote(self):
76			"""Increase weight of last chosen server."""
77			idx = self.server_list.index(self.last_server)
78			if self.servers_weights[idx] < 10:
79			self.servers_weights[idx] += 1
80
81			def check_time_add(self, duration):
82			"""Record connection time."""
83			self.check_time_sum += duration
84			self.check_time_count += 1
85
86			def check_time_avg(self):
87			"""Return average connection time."""
88			return self.check_time_sum / self.check_time_count
89
90			def master_server_vote_on_time(self, last_duration):
91			"""Change weight of a server based on average connection time."""
92			avg_duration = self.check_time_avg()
93			if last_duration < avg_duration - 0.5:
94			self.master_server_upvote()
95			elif last_duration > avg_duration + 0.5:
96			self.master_server_downvote()
97
98			def hook_prerequest(self):
99			"""Hook to be called before doing request"""
100			self.reqtime_start = time.perf_counter()
			0 ignored issues – show Coding Style introduced 2018-02-11 00:55 UTC by Report Bug Copy Issue Report The attribute `reqtime_start` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
101
102			def hook_postrequest(self, successful: bool):
103			"""Hook to be called after request finished"""
104			reqtime = time.perf_counter() - self.reqtime_start
105			self.check_time_add(reqtime)
106			if successful:
107			self.master_server_vote_on_time(reqtime)
108			else:
109			self.master_server_downvote()
110

mbirth / tcl_ota_check

Push — master ( 2adcb6...75d235 )

ServerVoteSelector.__init__() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ServerVoteSelector.init() A