mbirth / cops

lib/Serie.php

<?php
/**
 * COPS (Calibre OPDS PHP Server) class file
 *
 * @license    GPL 2 (http://www.gnu.org/licenses/gpl.html)
 * @author     Sébastien Lucas <sebastien@slucas.fr>
 */

class Serie

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    const ALL_SERIES_ID = "cops:series";

The string literal cops:series does not require double quotes, as per coding-style, please use single quotes.

    const SERIES_COLUMNS = "series.id as id, series.name as name, series.sort as sort, count(*) as count";

The string literal series.id as id, series.name as name, series.sort as sort, count(*) as count does not require double quotes, as per coding-style, please use single quotes.

    const SQL_ALL_SERIES = "select {0} from series, books_series_link where series.id = series group by series.id, series.name, series.sort order by series.sort";

The string literal select {0} from series, books_series_link where series.id = series group by series.id, series.name, series.sort order by series.sort does not require double quotes, as per coding-style, please use single quotes.

    const SQL_SERIES_FOR_SEARCH = "select {0} from series, books_series_link where series.id = series and upper (series.name) like ? group by series.id, series.name, series.sort order by series.sort";

The string literal select {0} from series, books_series_link where series.id = series and upper (series.name) like ? group by series.id, series.name, series.sort order by series.sort does not require double quotes, as per coding-style, please use single quotes.

    public $id;
    public $name;

    public function __construct($post) {
        $this->id = $post->id;
        $this->name = $post->name;
    }

    public function getUri () {
        return "?page=".Base::PAGE_SERIE_DETAIL."&id=$this->id";

The string literal ?page= does not require double quotes, as per coding-style, please use single quotes.

As per coding-style, please use concatenation or sprintf for the variable $this instead of interpolation.

    }

    public function getEntryId () {
        return self::ALL_SERIES_ID.":".$this->id;

The string literal : does not require double quotes, as per coding-style, please use single quotes.

    }

    public static function getCount() {
        // str_format (localize("series.alphabetical", count(array))

50% of this comment could be valid code. Did you maybe forget this after debugging?

        return Base::getCountGeneric ("series", self::ALL_SERIES_ID, Base::PAGE_ALL_SERIES);

The string literal series does not require double quotes, as per coding-style, please use single quotes.

    }

    public static function getSerieByBookId ($bookId) {

This method seems to be duplicated in your project.

        $result = Base::getDb ()->prepare('select  series.id as id, name
from books_series_link, series
where series.id = series and book = ?');
        $result->execute (array ($bookId));
        if ($post = $result->fetchObject ()) {
            return new Serie ($post);
        }
        return NULL;
    }

    public static function getSerieById ($serieId) {

This method seems to be duplicated in your project.

        $result = Base::getDb ()->prepare('select id, name  from series where id = ?');
        $result->execute (array ($serieId));
        if ($post = $result->fetchObject ()) {
            return new Serie ($post);
        }
        return NULL;
    }

    public static function getAllSeries() {
        return Base::getEntryArrayWithBookNumber (self::SQL_ALL_SERIES, self::SERIES_COLUMNS, array (), "Serie");

The string literal Serie does not require double quotes, as per coding-style, please use single quotes.

    }

    public static function getAllSeriesByQuery($query) {
        return Base::getEntryArrayWithBookNumber (self::SQL_SERIES_FOR_SEARCH, self::SERIES_COLUMNS, array ('%' . $query . '%'), "Serie");

The string literal Serie does not require double quotes, as per coding-style, please use single quotes.

    }
}