mbirth / cops

lib/Publisher.php

<?php
/**
 * COPS (Calibre OPDS PHP Server) class file
 *
 * @license    GPL 2 (http://www.gnu.org/licenses/gpl.html)
 * @author     At Libitum <eljarec@yahoo.com>
 */

class Publisher

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    const ALL_PUBLISHERS_ID = "cops:publishers";

The string literal cops:publishers does not require double quotes, as per coding-style, please use single quotes.

    const PUBLISHERS_COLUMNS = "publishers.id as id, publishers.name as name, count(*) as count";

The string literal publishers.id as id, publishers.name as name, count(*) as count does not require double quotes, as per coding-style, please use single quotes.

    const SQL_ALL_PUBLISHERS = "select {0} from publishers, books_publishers_link where publishers.id = publisher group by publishers.id, publishers.name order by publishers.name";

The string literal select {0} from publishers, books_publishers_link where publishers.id = publisher group by publishers.id, publishers.name order by publishers.name does not require double quotes, as per coding-style, please use single quotes.

    const SQL_PUBLISHERS_FOR_SEARCH = "select {0} from publishers, books_publishers_link where publishers.id = publisher and upper (publishers.name) like ? group by publishers.id, publishers.name order by publishers.name";

The string literal select {0} from publishers, books_publishers_link where publishers.id = publisher and upper (publishers.name) like ? group by publishers.id, publishers.name order by publishers.name does not require double quotes, as per coding-style, please use single quotes.

    public $id;
    public $name;

    public function __construct($post) {
        $this->id = $post->id;
        $this->name = $post->name;
    }

    public function getUri () {
        return "?page=".Base::PAGE_PUBLISHER_DETAIL."&id=$this->id";

The string literal ?page= does not require double quotes, as per coding-style, please use single quotes.

As per coding-style, please use concatenation or sprintf for the variable $this instead of interpolation.

    }

    public function getEntryId () {
        return self::ALL_PUBLISHERS_ID.":".$this->id;

The string literal : does not require double quotes, as per coding-style, please use single quotes.

    }

    public static function getCount() {
        // str_format (localize("publishers.alphabetical", count(array))

50% of this comment could be valid code. Did you maybe forget this after debugging?

        return Base::getCountGeneric ("publishers", self::ALL_PUBLISHERS_ID, Base::PAGE_ALL_PUBLISHERS);

The string literal publishers does not require double quotes, as per coding-style, please use single quotes.

    }

    public static function getPublisherByBookId ($bookId) {

This method seems to be duplicated in your project.

        $result = Base::getDb ()->prepare('select publishers.id as id, name
from books_publishers_link, publishers
where publishers.id = publisher and book = ?');
        $result->execute (array ($bookId));
        if ($post = $result->fetchObject ()) {
            return new Publisher ($post);
        }
        return NULL;
    }

    public static function getPublisherById ($publisherId) {

This method seems to be duplicated in your project.

        $result = Base::getDb ()->prepare('select id, name
from publishers where id = ?');
        $result->execute (array ($publisherId));
        if ($post = $result->fetchObject ()) {
            return new Publisher ($post);
        }
        return NULL;
    }

    public static function getAllPublishers() {
        return Base::getEntryArrayWithBookNumber (self::SQL_ALL_PUBLISHERS, self::PUBLISHERS_COLUMNS, array (), "Publisher");

The string literal Publisher does not require double quotes, as per coding-style, please use single quotes.

    }

    public static function getAllPublishersByQuery($query) {
        return Base::getEntryArrayWithBookNumber (self::SQL_PUBLISHERS_FOR_SEARCH, self::PUBLISHERS_COLUMNS, array ('%' . $query . '%'), "Publisher");

The string literal Publisher does not require double quotes, as per coding-style, please use single quotes.

    }
}