Issues in PageQueryResult.php (master) - Issues in master - mbirth/cops - Measure and Improve Code Quality continuously with Scrutinizer

Issues (982)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/PageQueryResult.php (11 issues)

Labels

Severity

Minor 11

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * COPS (Calibre OPDS PHP Server) class file
 *
 * @license    GPL 2 (http://www.gnu.org/licenses/gpl.html)
 * @author     Sébastien Lucas <[email protected]>
 */

class PageQueryResult extends Page
{
    const SCOPE_TAG = "tag";
    const SCOPE_RATING = "rating";
    const SCOPE_SERIES = "series";
    const SCOPE_AUTHOR = "author";
    const SCOPE_BOOK = "book";
    const SCOPE_PUBLISHER = "publisher";

    private function useTypeahead () {
        return !is_null (getURLParam ("search"));
    }

    private function searchByScope ($scope, $limit = FALSE) {
        $n = $this->n;
        $numberPerPage = NULL;
        $queryNormedAndUp = trim($this->query);
        if (useNormAndUp ()) {
            $queryNormedAndUp = normAndUp ($this->query);
        }
        if ($limit) {
            $n = 1;
            $numberPerPage = 5;
        }
        switch ($scope) {
            case self::SCOPE_BOOK :
                $array = Book::getBooksByStartingLetter ('%' . $queryNormedAndUp, $n, NULL, $numberPerPage);
                break;
            case self::SCOPE_AUTHOR :
                $array = Author::getAuthorsForSearch ('%' . $queryNormedAndUp);
                break;
            case self::SCOPE_SERIES :
                $array = Serie::getAllSeriesByQuery ($queryNormedAndUp);
                break;
            case self::SCOPE_TAG :
                $array = Tag::getAllTagsByQuery ($queryNormedAndUp, $n, NULL, $numberPerPage);
                break;
            case self::SCOPE_PUBLISHER :
                $array = Publisher::getAllPublishersByQuery ($queryNormedAndUp);
                break;
            default:
                $array = Book::getBooksByQuery (
                    array ("all" => "%" . $queryNormedAndUp . "%"), $n);
        }

        return $array;
    }

    public function doSearchByCategory () {
        $database = GetUrlParam (DB);
        $out = array ();
        $pagequery = Base::PAGE_OPENSEARCH_QUERY;
        $dbArray = array ("");
        $d = $database;
        $query = $this->query;
        // Special case when no databases were chosen, we search on all databases
        if (Base::noDatabaseSelected ()) {
            $dbArray = Base::getDbNameList ();
            $d = 0;
        }
        foreach ($dbArray as $key) {
            if (Base::noDatabaseSelected ()) {
                array_push ($this->entryArray, new Entry ($key, DB . ":query:{$d}",
                                        " ", "text",
                                        array ( new LinkNavigation ("?" . DB . "={$d}")), "tt-header"));
                Base::getDb ($d);
            }
            foreach (array (PageQueryResult::SCOPE_BOOK,
                            PageQueryResult::SCOPE_AUTHOR,
                            PageQueryResult::SCOPE_SERIES,
                            PageQueryResult::SCOPE_TAG,
                            PageQueryResult::SCOPE_PUBLISHER) as $key) {
                if (in_array($key, getCurrentOption ('ignored_categories'))) {
                    continue;
                }
                $array = $this->searchByScope ($key, TRUE);

                $i = 0;
                if (count ($array) == 2 && is_array ($array [0])) {
                    $total = $array [1];
                    $array = $array [0];
                } else {
                    $total = count($array);
                }
                if ($total > 0) {
                    // Comment to help the perl i18n script
                    // str_format (localize("bookword", count($array))

                    // str_format (localize("authorword", count($array))

                    // str_format (localize("seriesword", count($array))

                    // str_format (localize("tagword", count($array))

                    // str_format (localize("publisherword", count($array))

                    array_push ($this->entryArray, new Entry (str_format (localize ("search.result.{$key}"), $this->query), DB . ":query:{$d}:{$key}",
                                        str_format (localize("{$key}word", $total), $total), "text",
                                        array ( new LinkNavigation ("?page={$pagequery}&query={$query}&db={$d}&scope={$key}")),
                                        Base::noDatabaseSelected () ? "" : "tt-header", $total));
                }
                if (!Base::noDatabaseSelected () && $this->useTypeahead ()) {
                    foreach ($array as $entry) {
                        array_push ($this->entryArray, $entry);
                        $i++;
                        if ($i > 4) { break; };
                    }
                }
            }
            $d++;
            if (Base::noDatabaseSelected ()) {
                Base::clearDb ();
            }
        }
        return $out;
    }

    public function InitializeContent ()
    {
        $scope = getURLParam ("scope");
        if (empty ($scope)) {
            $this->title = str_format (localize ("search.result"), $this->query);
        } else {
            // Comment to help the perl i18n script
            // str_format (localize ("search.result.author"), $this->query)

            // str_format (localize ("search.result.tag"), $this->query)

            // str_format (localize ("search.result.series"), $this->query)

            // str_format (localize ("search.result.book"), $this->query)

            // str_format (localize ("search.result.publisher"), $this->query)

            $this->title = str_format (localize ("search.result.{$scope}"), $this->query);
        }

        $crit = "%" . $this->query . "%";

        // Special case when we are doing a search and no database is selected
        if (Base::noDatabaseSelected () && !$this->useTypeahead ()) {
            $i = 0;
            foreach (Base::getDbNameList () as $key) {
                Base::clearDb ();
                list ($array, $totalNumber) = Book::getBooksByQuery (array ("all" => $crit), 1, $i, 1);
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
                array_push ($this->entryArray, new Entry ($key, DB . ":query:{$i}",
                                        str_format (localize ("bookword", $totalNumber), $totalNumber), "text",
                                        array ( new LinkNavigation ("?" . DB . "={$i}&page=9&query=" . $this->query)), "", $totalNumber));
                $i++;
            }
            return;
        }
        if (empty ($scope)) {
            $this->doSearchByCategory ();
            return;
        }

        $array = $this->searchByScope ($scope);
        if (count ($array) == 2 && is_array ($array [0])) {
            list ($this->entryArray, $this->totalNumber) = $array;
        } else {
            $this->entryArray = $array;
        }
    }
}


1		<?php
2		/**
3		* COPS (Calibre OPDS PHP Server) class file
4		*
5		* @license GPL 2 (http://www.gnu.org/licenses/gpl.html)
6		* @author Sébastien Lucas <[email protected]>
7		*/
8
9		class PageQueryResult extends Page
10		{
11		const SCOPE_TAG = "tag";
12		const SCOPE_RATING = "rating";
13		const SCOPE_SERIES = "series";
14		const SCOPE_AUTHOR = "author";
15		const SCOPE_BOOK = "book";
16		const SCOPE_PUBLISHER = "publisher";
17
18	24	private function useTypeahead () {
19	24	return !is_null (getURLParam ("search"));
20		}
21
22	29	private function searchByScope ($scope, $limit = FALSE) {
23	29	$n = $this->n;
24	29	$numberPerPage = NULL;
25	29	$queryNormedAndUp = trim($this->query);
26	29	if (useNormAndUp ()) {
27	7	$queryNormedAndUp = normAndUp ($this->query);
28	7	}
29	29	if ($limit) {
30	22	$n = 1;
31	22	$numberPerPage = 5;
32	22	}
33		switch ($scope) {
34	29	case self::SCOPE_BOOK :
35	23	$array = Book::getBooksByStartingLetter ('%' . $queryNormedAndUp, $n, NULL, $numberPerPage);
36	23	break;
37	28	case self::SCOPE_AUTHOR :
38	23	$array = Author::getAuthorsForSearch ('%' . $queryNormedAndUp);
39	23	break;
40	25	case self::SCOPE_SERIES :
41	22	$array = Serie::getAllSeriesByQuery ($queryNormedAndUp);
42	22	break;
43	24	case self::SCOPE_TAG :
44	23	$array = Tag::getAllTagsByQuery ($queryNormedAndUp, $n, NULL, $numberPerPage);
45	23	break;
46	23	case self::SCOPE_PUBLISHER :
47	23	$array = Publisher::getAllPublishersByQuery ($queryNormedAndUp);
48	23	break;
49		default:
50		$array = Book::getBooksByQuery (
51		array ("all" => "%" . $queryNormedAndUp . "%"), $n);
52		}
53
54	29	return $array;
55		}
56
57	22	public function doSearchByCategory () {
58	22	$database = GetUrlParam (DB);
59	22	$out = array ();
60	22	$pagequery = Base::PAGE_OPENSEARCH_QUERY;
61	22	$dbArray = array ("");
62	22	$d = $database;
63	22	$query = $this->query;
64		// Special case when no databases were chosen, we search on all databases
65	22	if (Base::noDatabaseSelected ()) {
66	1	$dbArray = Base::getDbNameList ();
67	1	$d = 0;
68	1	}
69	22	foreach ($dbArray as $key) {
70	22	if (Base::noDatabaseSelected ()) {
71	1	array_push ($this->entryArray, new Entry ($key, DB . ":query:{$d}",
72	1	" ", "text",
73	1	array ( new LinkNavigation ("?" . DB . "={$d}")), "tt-header"));
74	1	Base::getDb ($d);
75	1	}
76	22	foreach (array (PageQueryResult::SCOPE_BOOK,
77	22	PageQueryResult::SCOPE_AUTHOR,
78	22	PageQueryResult::SCOPE_SERIES,
79	22	PageQueryResult::SCOPE_TAG,
80	22	PageQueryResult::SCOPE_PUBLISHER) as $key) {
81	22	if (in_array($key, getCurrentOption ('ignored_categories'))) {
82	3	continue;
83		}
84	22	$array = $this->searchByScope ($key, TRUE);
85
86	22	$i = 0;
87	22	if (count ($array) == 2 && is_array ($array [0])) {
88	22	$total = $array [1];
89	22	$array = $array [0];
90	22	} else {
91	22	$total = count($array);
92		}
93	22	if ($total > 0) {
94		// Comment to help the perl i18n script
95		// str_format (localize("bookword", count($array))
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-29 18:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
96		// str_format (localize("authorword", count($array))
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-29 18:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
97		// str_format (localize("seriesword", count($array))
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-29 18:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
98		// str_format (localize("tagword", count($array))
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-29 18:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
99		// str_format (localize("publisherword", count($array))
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-29 18:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
100	21	array_push ($this->entryArray, new Entry (str_format (localize ("search.result.{$key}"), $this->query), DB . ":query:{$d}:{$key}",
101	21	str_format (localize("{$key}word", $total), $total), "text",
102	21	array ( new LinkNavigation ("?page={$pagequery}&query={$query}&db={$d}&scope={$key}")),
103	21	Base::noDatabaseSelected () ? "" : "tt-header", $total));
104	21	}
105	22	if (!Base::noDatabaseSelected () && $this->useTypeahead ()) {
106	6	foreach ($array as $entry) {
107	6	array_push ($this->entryArray, $entry);
108	6	$i++;
109	6	if ($i > 4) { break; };
110	6	}
111	6	}
112	22	}
113	22	$d++;
114	22	if (Base::noDatabaseSelected ()) {
115	1	Base::clearDb ();
116	1	}
117	22	}
118	22	return $out;
119		}
120
121	31	public function InitializeContent ()
122		{
123	31	$scope = getURLParam ("scope");
124	31	if (empty ($scope)) {
125	24	$this->title = str_format (localize ("search.result"), $this->query);
126	24	} else {
127		// Comment to help the perl i18n script
128		// str_format (localize ("search.result.author"), $this->query)
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-29 18:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `54%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
129		// str_format (localize ("search.result.tag"), $this->query)
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-29 18:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `54%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
130		// str_format (localize ("search.result.series"), $this->query)
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-29 18:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `54%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
131		// str_format (localize ("search.result.book"), $this->query)
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-29 18:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `54%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
132		// str_format (localize ("search.result.publisher"), $this->query)
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-29 18:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this `54%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
133	7	$this->title = str_format (localize ("search.result.{$scope}"), $this->query);
134		}
135
136	31	$crit = "%" . $this->query . "%";
137
138		// Special case when we are doing a search and no database is selected
139	31	if (Base::noDatabaseSelected () && !$this->useTypeahead ()) {
140	2	$i = 0;
141	2	foreach (Base::getDbNameList () as $key) {
142	2	Base::clearDb ();
143	2	list ($array, $totalNumber) = Book::getBooksByQuery (array ("all" => $crit), 1, $i, 1);
		0 ignored issues – show Unused Code introduced 2016-06-29 18:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$array` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
144	2	array_push ($this->entryArray, new Entry ($key, DB . ":query:{$i}",
145	2	str_format (localize ("bookword", $totalNumber), $totalNumber), "text",
146	2	array ( new LinkNavigation ("?" . DB . "={$i}&page=9&query=" . $this->query)), "", $totalNumber));
147	2	$i++;
148	2	}
149	2	return;
150		}
151	29	if (empty ($scope)) {
152	22	$this->doSearchByCategory ();
153	22	return;
154		}
155
156	7	$array = $this->searchByScope ($scope);
157	7	if (count ($array) == 2 && is_array ($array [0])) {
158	2	list ($this->entryArray, $this->totalNumber) = $array;
159	2	} else {
160	5	$this->entryArray = $array;
161		}
162	7	}
163		}
164

mbirth / cops

Issues (982)

Security Analysis not enabled

lib/PageQueryResult.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like