mbirth / cops

lib/CustomColumnTypeBool.php

<?php
/**
 * COPS (Calibre OPDS PHP Server) class file
 *
 * @license    GPL 2 (http://www.gnu.org/licenses/gpl.html)
 * @author     Sébastien Lucas <sebastien@slucas.fr>
 */

class CustomColumnTypeBool extends CustomColumnType

The property $BOOLEAN_NAMES is not named in camelCase.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    // PHP pre 5.6 does not support const arrays
    private $BOOLEAN_NAMES = array(
        -1 => "customcolumn.boolean.unknown", // localize("customcolumn.boolean.unknown")

The string literal customcolumn.boolean.unknown does not require double quotes, as per coding-style, please use single quotes.

        00 => "customcolumn.boolean.no",      // localize("customcolumn.boolean.no")

The string literal customcolumn.boolean.no does not require double quotes, as per coding-style, please use single quotes.

        +1 => "customcolumn.boolean.yes",     // localize("customcolumn.boolean.yes")

The string literal customcolumn.boolean.yes does not require double quotes, as per coding-style, please use single quotes.

    );

    protected function __construct($pcustomId)
    {
        parent::__construct($pcustomId, self::CUSTOM_TYPE_BOOL);
    }

    /**
     * Get the name of the sqlite table for this column
     *
     * @return string|null
     */
    private function getTableName()
    {
        return "custom_column_{$this->customId}";

As per coding-style, please use concatenation or sprintf for the variable $this instead of interpolation.

    }

    public function getQuery($id)
    {
        if ($id == -1) {
            $query = str_format(Book::SQL_BOOKS_BY_CUSTOM_BOOL_NULL, "{0}", "{1}", $this->getTableName());

The string literal {0} does not require double quotes, as per coding-style, please use single quotes.

The string literal {1} does not require double quotes, as per coding-style, please use single quotes.

            return array($query, array());
        } else if ($id == 0) {
            $query = str_format(Book::SQL_BOOKS_BY_CUSTOM_BOOL_FALSE, "{0}", "{1}", $this->getTableName());

The string literal {0} does not require double quotes, as per coding-style, please use single quotes.

The string literal {1} does not require double quotes, as per coding-style, please use single quotes.

            return array($query, array());
        } else if ($id == 1) {
            $query = str_format(Book::SQL_BOOKS_BY_CUSTOM_BOOL_TRUE, "{0}", "{1}", $this->getTableName());

The string literal {0} does not require double quotes, as per coding-style, please use single quotes.

The string literal {1} does not require double quotes, as per coding-style, please use single quotes.

            return array($query, array());
        } else {
            return NULL;
        }
    }

    public function getCustom($id)
    {
        return new CustomColumn($id, localize($this->BOOLEAN_NAMES[$id]), $this);
    }

    protected function getAllCustomValuesFromDatabase()

This method seems to be duplicated in your project.

    {
        $queryFormat = "SELECT coalesce({0}.value, -1) AS id, count(*) AS count FROM books LEFT JOIN {0} ON  books.id = {0}.book GROUP BY {0}.value ORDER BY {0}.value";

The string literal SELECT coalesce({0}.value, -1) AS id, count(*) AS count FROM books LEFT JOIN {0} ON books.id = {0}.book GROUP BY {0}.value ORDER BY {0}.value does not require double quotes, as per coding-style, please use single quotes.

        $query = str_format($queryFormat, $this->getTableName());
        $result = Base::getDb()->query($query);

        $entryArray = array();
        while ($post = $result->fetchObject()) {
            $entryPContent = str_format(localize("bookword", $post->count), $post->count);

The string literal bookword does not require double quotes, as per coding-style, please use single quotes.

            $entryPLinkArray = array(new LinkNavigation ($this->getUri($post->id)));

            $entry = new Entry(localize($this->BOOLEAN_NAMES[$post->id]), $this->getEntryId($post->id), $entryPContent, $this->datatype, $entryPLinkArray, "", $post->count);

The string literal does not require double quotes, as per coding-style, please use single quotes.

            array_push($entryArray, $entry);
        }
        return $entryArray;
    }

    public function getDescription()
    {
        return localize("customcolumn.description.bool");

The string literal customcolumn.description.bool does not require double quotes, as per coding-style, please use single quotes.

    }

    public function getCustomByBook($book)
    {
        $queryFormat = "SELECT {0}.value AS boolvalue FROM {0} WHERE {0}.book = {1}";

The string literal SELECT {0}.value AS boolvalue FROM {0} WHERE {0}.book = {1} does not require double quotes, as per coding-style, please use single quotes.

        $query = str_format($queryFormat, $this->getTableName(), $book->id);

        $result = Base::getDb()->query($query);
        if ($post = $result->fetchObject()) {
            return new CustomColumn($post->boolvalue, localize($this->BOOLEAN_NAMES[$post->boolvalue]), $this);
        } else {
            return new CustomColumn(-1, localize($this->BOOLEAN_NAMES[-1]), $this);
        }
    }

    public function isSearchable()
    {
        return true;
    }
}