Tag

Complexity

Total Complexity

9

Size/Duplication

Total Lines	55
Duplicated Lines	14.55 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

96.67%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getUri()	0	3	1
A	getEntryId()	0	3	1
A	getCount()	0	4	1
A	getTagById()	8	8	2
A	getAllTags()	0	3	1
A	getAllTagsByQuery()	0	14	2

<?php
/**
 * COPS (Calibre OPDS PHP Server) class file
 *
 * @license    GPL 2 (http://www.gnu.org/licenses/gpl.html)
 * @author     Sébastien Lucas <sebastien@slucas.fr>
 */

class Tag

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    const ALL_TAGS_ID = "cops:tags";

The string literal cops:tags does not require double quotes, as per coding-style, please use single quotes.

    const TAG_COLUMNS = "tags.id as id, tags.name as name, count(*) as count";

The string literal tags.id as id, tags.name as name, count(*) as count does not require double quotes, as per coding-style, please use single quotes.

    const SQL_ALL_TAGS = "select {0} from tags, books_tags_link where tags.id = tag group by tags.id, tags.name order by tags.name";

The string literal select {0} from tags, books_tags_link where tags.id = tag group by tags.id, tags.name order by tags.name does not require double quotes, as per coding-style, please use single quotes.

    public $id;
    public $name;

    public function __construct($post) {
        $this->id = $post->id;
        $this->name = $post->name;
    }

    public function getUri () {
        return "?page=".Base::PAGE_TAG_DETAIL."&id=$this->id";

The string literal ?page= does not require double quotes, as per coding-style, please use single quotes.

As per coding-style, please use concatenation or sprintf for the variable $this instead of interpolation.

    }

    public function getEntryId () {
        return self::ALL_TAGS_ID.":".$this->id;

The string literal : does not require double quotes, as per coding-style, please use single quotes.

    }

    public static function getCount() {
        // str_format (localize("tags.alphabetical", count(array))

50% of this comment could be valid code. Did you maybe forget this after debugging?

        return Base::getCountGeneric ("tags", self::ALL_TAGS_ID, Base::PAGE_ALL_TAGS);

The string literal tags does not require double quotes, as per coding-style, please use single quotes.

    }

    public static function getTagById ($tagId) {

This method seems to be duplicated in your project.

        $result = Base::getDb ()->prepare('select id, name  from tags where id = ?');
        $result->execute (array ($tagId));
        if ($post = $result->fetchObject ()) {
            return new Tag ($post);
        }
        return NULL;
    }

    public static function getAllTags() {
        return Base::getEntryArrayWithBookNumber (self::SQL_ALL_TAGS, self::TAG_COLUMNS, array (), "Tag");

The string literal Tag does not require double quotes, as per coding-style, please use single quotes.

    }

    public static function getAllTagsByQuery($query, $n, $database = NULL, $numberPerPage = NULL) {
        $columns  = "tags.id as id, tags.name as name, (select count(*) from books_tags_link where tags.id = tag) as count";

The string literal tags.id as id, tags.name as name, (select count(*) from books_tags_link where tags.id = tag) as count does not require double quotes, as per coding-style, please use single quotes.

        $sql = 'select {0} from tags where upper (tags.name) like ? {1} order by tags.name';
        list ($totalNumber, $result) = Base::executeQuery ($sql, $columns, "", array ('%' . $query . '%'), $n, $database, $numberPerPage);

The string literal does not require double quotes, as per coding-style, please use single quotes.

        $entryArray = array();
        while ($post = $result->fetchObject ())
        {
            $tag = new Tag ($post);
            array_push ($entryArray, new Entry ($tag->name, $tag->getEntryId (),
                str_format (localize("bookword", $post->count), $post->count), "text",

The string literal bookword does not require double quotes, as per coding-style, please use single quotes.

The string literal text does not require double quotes, as per coding-style, please use single quotes.

                array ( new LinkNavigation ($tag->getUri ()))));
        }
        return array ($entryArray, $totalNumber);
    }
}