mazinsw /
nfe-api
Complex classes like Recibo often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Recibo, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 33 | class Recibo extends Retorno |
||
| 34 | { |
||
| 35 | |||
| 36 | const INFO_TAGNAME = 'infRec'; |
||
| 37 | |||
| 38 | private $numero; |
||
| 39 | private $tempo_medio; |
||
| 40 | private $codigo; |
||
| 41 | private $mensagem; |
||
| 42 | private $modelo; |
||
| 43 | |||
| 44 | 1 | public function __construct($recibo = array()) |
|
| 48 | |||
| 49 | /** |
||
| 50 | * Número do Recibo |
||
| 51 | */ |
||
| 52 | public function getNumero($normalize = false) |
||
| 53 | { |
||
| 54 | if (!$normalize) { |
||
| 55 | return $this->numero; |
||
| 56 | } |
||
| 57 | return $this->numero; |
||
| 58 | } |
||
| 59 | |||
| 60 | 1 | public function setNumero($numero) |
|
| 65 | |||
| 66 | /** |
||
| 67 | * Tempo médio de resposta do serviço (em segundos) dos últimos 5 minutos |
||
| 68 | */ |
||
| 69 | public function getTempoMedio($normalize = false) |
||
| 70 | { |
||
| 71 | if (!$normalize) { |
||
| 72 | return $this->tempo_medio; |
||
| 73 | } |
||
| 74 | return $this->tempo_medio; |
||
| 75 | } |
||
| 76 | |||
| 77 | 1 | public function setTempoMedio($tempo_medio) |
|
| 82 | |||
| 83 | /** |
||
| 84 | * Código da Mensagem (v2.0) alterado para tamanho variavel 1-4. |
||
| 85 | * (NT2011/004) |
||
| 86 | */ |
||
| 87 | public function getCodigo($normalize = false) |
||
| 88 | { |
||
| 89 | if (!$normalize) { |
||
| 90 | return $this->codigo; |
||
| 91 | } |
||
| 92 | return $this->codigo; |
||
| 93 | } |
||
| 94 | |||
| 95 | 1 | public function setCodigo($codigo) |
|
| 100 | |||
| 101 | /** |
||
| 102 | * Mensagem da SEFAZ para o emissor. (v2.0) |
||
| 103 | */ |
||
| 104 | public function getMensagem($normalize = false) |
||
| 105 | { |
||
| 106 | if (!$normalize) { |
||
| 107 | return $this->mensagem; |
||
| 108 | } |
||
| 109 | return $this->mensagem; |
||
| 110 | } |
||
| 111 | |||
| 112 | 1 | public function setMensagem($mensagem) |
|
| 117 | |||
| 118 | /** |
||
| 119 | * Código do modelo do Documento Fiscal. 55 = NF-e; 65 = NFC-e. |
||
| 120 | */ |
||
| 121 | public function getModelo($normalize = false) |
||
| 122 | { |
||
| 123 | if (!$normalize) { |
||
| 124 | return $this->modelo; |
||
| 125 | } |
||
| 126 | return $this->modelo; |
||
| 127 | } |
||
| 128 | |||
| 129 | 1 | public function setModelo($modelo) |
|
| 134 | |||
| 135 | public function toArray() |
||
| 136 | { |
||
| 137 | $recibo = parent::toArray(); |
||
| 138 | $recibo['numero'] = $this->getNumero(); |
||
| 139 | $recibo['tempo_medio'] = $this->getTempoMedio(); |
||
| 145 | |||
| 146 | 1 | public function fromArray($recibo = array()) |
|
| 181 | |||
| 182 | public function envia($dom) |
||
| 199 | |||
| 200 | public function consulta($nota = null) |
||
| 214 | |||
| 215 | public function getNode($name = null) |
||
| 229 | |||
| 230 | public function loadNode($element, $name = null) |
||
| 269 | |||
| 270 | /** |
||
| 271 | * Valida o documento após assinar |
||
| 272 | */ |
||
| 273 | public function validar($dom) |
||
| 296 | } |
||
| 297 |
A high number of execution paths generally suggests many nested conditional statements and make the code less readible. This can usually be fixed by splitting the method into several smaller methods.
You can also find more information in the “Code” section of your repository.