Maztech\HttpClients\InstagramCurlHttpClient

Complexity

Total Complexity

11

Size/Duplication

Total Lines	128
Duplicated Lines	0 %

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	openConnection()	0	21	2
A	__construct()	0	3	2
A	send()	0	15	2
A	compileRequestHeaders()	0	9	2
A	closeConnection()	0	3	1
A	extractResponseHeadersAndBody()	0	7	1
A	sendRequest()	0	3	1

<?php

namespace Maztech\HttpClients;

use Maztech\Http\GraphRawResponse;
use Maztech\Exceptions\InstagramSDKException;

/**
 * Class InstagramCurlHttpClient
 *
 * @package Instagram
 */
class InstagramCurlHttpClient implements InstagramHttpClientInterface
{
    /**
     * @var string The client error message
     */
    protected $curlErrorMessage = '';

    /**
     * @var int The curl client error code
     */
    protected $curlErrorCode = 0;

    /**
     * @var string|boolean The raw response from the server
     */
    protected $rawResponse;

    /**
     * @var InstagramCurl Procedural curl as object
     */
    protected $instagramCurl;

    /**
     * @param InstagramCurl|null Procedural curl as object

The type Maztech\HttpClients\Procedural was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    public function __construct(InstagramCurl $instagramCurl = null)
    {
        $this->instagramCurl = $instagramCurl ?: new InstagramCurl();
    }

    /**
     * @inheritdoc
     */
    public function send($url, $method, $body, array $headers, $timeOut)
    {
        $this->openConnection($url, $method, $body, $headers, $timeOut);
        $this->sendRequest();

        if ($curlErrorCode = $this->instagramCurl->errno()) {
            throw new InstagramSDKException($this->instagramCurl->error(), $curlErrorCode);
        }

        // Separate the raw headers from the raw body
        list($rawHeaders, $rawBody) = $this->extractResponseHeadersAndBody();

        $this->closeConnection();

        return new GraphRawResponse($rawHeaders, $rawBody);

The expression return new Maztech\Http\GraphRawResponse($rawHeaders, $rawBody) returns the type Maztech\Http\GraphRawResponse which is incompatible with the return type mandated by Maztech\HttpClients\InstagramHttpClientInterface::send() of Instagram\Http\GraphRawResponse.

    }

    /**
     * Opens a new curl connection.
     *
     * @param string $url     The endpoint to send the request to.
     * @param string $method  The request method.
     * @param string $body    The body of the request.
     * @param array  $headers The request headers.
     * @param int    $timeOut The timeout in seconds for the request.
     */
    public function openConnection($url, $method, $body, array $headers, $timeOut)
    {
        $options = [
            CURLOPT_CUSTOMREQUEST => $method,
            CURLOPT_HTTPHEADER => $this->compileRequestHeaders($headers),
            CURLOPT_URL => $url,
            CURLOPT_CONNECTTIMEOUT => 10,
            CURLOPT_TIMEOUT => $timeOut,
            CURLOPT_RETURNTRANSFER => true, // Return response as string
            CURLOPT_HEADER => true, // Enable header processing
            CURLOPT_SSL_VERIFYHOST => 2,
            CURLOPT_SSL_VERIFYPEER => true,
            CURLOPT_CAINFO => __DIR__ . '/certs/DigiCertHighAssuranceEVRootCA.pem',
        ];

        if ($method !== "GET") {
            $options[CURLOPT_POSTFIELDS] = $body;
        }

        $this->instagramCurl->init();
        $this->instagramCurl->setoptArray($options);
    }

    /**
     * Closes an existing curl connection
     */
    public function closeConnection()
    {
        $this->instagramCurl->close();
    }

    /**
     * Send the request and get the raw response from curl
     */
    public function sendRequest()
    {
        $this->rawResponse = $this->instagramCurl->exec();
    }

    /**
     * Compiles the request headers into a curl-friendly format.
     *
     * @param array $headers The request headers.
     *
     * @return array
     */
    public function compileRequestHeaders(array $headers)
    {
        $return = [];

        foreach ($headers as $key => $value) {
            $return[] = $key . ': ' . $value;
        }

        return $return;
    }

    /**
     * Extracts the headers and the body into a two-part array
     *
     * @return array
     */
    public function extractResponseHeadersAndBody()
    {
        $parts = explode("\r\n\r\n", $this->rawResponse);

It seems like $this->rawResponse can also be of type boolean; however, parameter $string of explode() does only seem to accept string, maybe add an additional type check?

        $rawBody = array_pop($parts);
        $rawHeaders = implode("\r\n\r\n", $parts);

        return [trim($rawHeaders), trim($rawBody)];
    }
}