maxpou / graphql-nodejs-mongodb

tests/queries/beer.queries.test.js

var chai     = require('chai');

This code seems to be duplicated in your project.

var chaiHttp = require('chai-http');
var should   = chai.should();

var server      = require('../../index');
var Beer        = require('../../models/beer.model');
var Brewery     = require('../../models/brewery.model');
var BeerData    = require('../../beers.json');
var BreweryData = require('../../breweries.json');

chai.use(chaiHttp);

describe('GraphQL Beer (queries)', function() {

  beforeEach(function(done){
    BreweryData.forEach(function (aBeer) {
      var newBrewery = new Brewery(aBeer);
      newBrewery.save();
    });
    BeerData.forEach(function (aBeer) {
      var newBeer = new Beer(aBeer);
      newBeer.save();
    });
    done();
  });

  afterEach(function(done){
    Beer.collection.drop();
    Brewery.collection.drop();
    done();
  });

  it('should display all the beers', function(done) {
    var graphqlQuery = `
    {
      beers {
        name
        alcohol
        description
      }
    }`;

    chai.request(server)
      .post('/graphql')
      .send({query: graphqlQuery})
      .end(function(err, res){
        res.should.have.status(200);
        res.should.be.a.json;

The result of the property access to res.should.be.a.json is not used.

        res.body['data']['beers'].should.be.an('array');
        res.body['data']['beers'][0].should.have.property('name');
        res.body['data']['beers'][0].should.have.property('alcohol');
        done();
      });
  });

  it('should display only beers from Duvel Brewery', function(done) {
    var graphqlQuery = `
    {
      beers(brewery: "duvel") {
        name
        alcohol
        brewery {
          name
        }
      }
    }`;

    chai.request(server)
      .post('/graphql')
      .send({query: graphqlQuery})
      .end(function(err, res){
        res.should.have.status(200);
        res.should.be.a.json;

The result of the property access to res.should.be.a.json is not used.

        for (var beer of res.body['data']['beers']) {
          beer.brewery.name.should.equal('Duvel Moortgat');
        }
        done();
      });
  });

  it('should display beers ordered by alcohol', function(done) {
    var graphqlQuery = `
    {
      beers(orderBy: ALCOHOL) {
        name
        alcohol
      }
    }`;

    chai.request(server)
      .post('/graphql')
      .send({query: graphqlQuery})
      .end(function(err, res){
        res.should.have.status(200);
        res.should.be.a.json;

The result of the property access to res.should.be.a.json is not used.

        var previousAlcohol = 1;
        for (var beer of res.body['data']['beers']) {
          beer.alcohol.should.be.at.least(previousAlcohol);
          previousAlcohol = beer.alcohol;
        }
        done();
      });
  });

  it('should display only beers from Duvel Brewery and ordered by alcohol', function(done) {
    var graphqlQuery = `
    {
      beers(brewery: "Duvel", orderBy: ALCOHOL) {
        name
        brewery {
          name
        }
        alcohol
      }
    }`;

    chai.request(server)
      .post('/graphql')
      .send({query: graphqlQuery})
      .end(function(err, res){
        res.should.have.status(200);
        res.should.be.a.json;

The result of the property access to res.should.be.a.json is not used.

        var previousAlcohol = 1;
        for (var beer of res.body['data']['beers']) {
          beer.brewery.name.should.equal('Duvel Moortgat');
          beer.alcohol.should.be.at.least(previousAlcohol);
          previousAlcohol = beer.alcohol;
        }
        done();
      });
  });

  it('should display a SINGLE beer', function(done) {
    var newBeer = new Beer({
      name: 'Custom Beer',
      brewery: 'Custom Brewery',
      alcohol: 9.5,
      description: 'miam miam'
    });

    newBeer.save(function(err, data) {

      var graphqlQuery = `
      {
        beer(id: "${data._id}") {
          name
        }
      }`;

      chai.request(server)
        .post('/graphql')
        .send({query: graphqlQuery})
        .end(function(err, res){
          res.should.have.status(200);
          res.should.be.a.json;

The result of the property access to res.should.be.a.json is not used.

          res.body.should.be.an('object');
          res.body['data']['beer']['name'].should.equal('Custom Beer');
          done();
        });
    });
  });
});