maxpou / graphql-nodejs-mongodb

tests/mutations/beer.mutations.test.js

var chai     = require('chai');

This code seems to be duplicated in your project.

var chaiHttp = require('chai-http');
var should   = chai.should();

var server      = require('../../index');
var Beer        = require('../../models/beer.model');
var Brewery     = require('../../models/brewery.model');
var BeerData    = require('../../beers.json');
var BreweryData = require('../../breweries.json');

chai.use(chaiHttp);

describe('GraphQL Beer (mutations)', function() {

  beforeEach(function(done){
    BreweryData.forEach(function (aBeer) {
      var newBrewery = new Brewery(aBeer);
      newBrewery.save();
    });
    BeerData.forEach(function (aBeer) {
      var newBeer = new Beer(aBeer);
      newBeer.save();
    });
    done();
  });

  afterEach(function(done){
    Beer.collection.drop();
    Brewery.collection.drop();
    done();
  });

  it('should add a new beer', function(done) {

    var newBrewery = new Brewery({
      _id: 'test_brewery',
      name: 'Test Brewery',
      location: 'Beerland'
    });

    newBrewery.save();

    var graphqlQuery = `
      mutation {
        addBeer(data: {name: "Beer Test Triple", brewery: "test_brewery", alcohol: 8.5})
      }
    `;

    chai.request(server)
      .post('/graphql')
      .send({query: graphqlQuery})
      .end(function(err, res){
        res.should.have.status(200);
        res.should.be.json;

The result of the property access to res.should.be.json is not used.

        res.body.data.addBeer.should.be.true;

The result of the property access to res.body.data.addBeer.should.be.true is not used.

      });

    // find this new beer
    var graphqlQuery = `

The variable graphqlQuery already seems to be declared on line 43. Consider using another variable name or omitting the var keyword.

    {
      beers(brewery: "test_brewery") {
        name
        brewery {
          name
        }
        alcohol
      }
    }`;

    chai.request(server)
      .post('/graphql')
      .send({query: graphqlQuery})
      .end(function(err, res){
        res.should.have.status(200);
        res.body['data']['beers'][0]['name'].should.equal('Beer Test Triple');
        res.body['data']['beers'][0]['brewery'].name.should.equal('Test Brewery');
        res.body['data']['beers'][0]['alcohol'].should.equal(8.5);
        done();
      });
  });

  it('should delete a SINGLE beer', function(done) {
    var newBeer = new Beer({
      name: 'Custom Beer',
      brewery: 'Custom Brewery',
      alcohol: 9.5,
      description: 'hummmmmmm'
    });

    newBeer.save(function(err, data) {

      var graphqlQuery = `
      mutation {
        removeBeer(_id: "${data._id}") {
          name
        }
      }`;

      chai.request(server)
        .post('/graphql')
        .send({query: graphqlQuery})
        .end(function(err, res){
          res.should.have.status(200);
          res.should.be.json;

The result of the property access to res.should.be.json is not used.

          res.body.should.be.an('object');
          res.body.data.removeBeer.name.should.equal('Custom Beer');
          done();
        });

      // try to retrieve the deleted beer
      var graphqlQuery = `

The variable graphqlQuery already seems to be declared on line 92. Consider using another variable name or omitting the var keyword.

      {
        beer(id: "${data._id}") {
          name
        }
      }`;

      chai.request(server)
        .post('/graphql')
        .send({query: graphqlQuery})
        .end(function(err, res){
          res.should.have.status(200);
          res.should.be.json;

The result of the property access to res.should.be.json is not used.

          res.body.should.be.an('object');
          res.body.data.beer.should.be.null;

The result of the property access to res.body.data.beer.should.be.null is not used.

          done();
        });
    });
  });

  it('should delete all beers', function(done) {

    var graphqlQuery = `
      mutation {
        removeAllBeers
      }
    `;

    chai.request(server)
      .post('/graphql')
      .send({query: graphqlQuery})
      .end(function(err, res){
        res.should.have.status(200);
        res.should.be.json;

The result of the property access to res.should.be.json is not used.

        res.body.data.removeAllBeers.should.be.true;

The result of the property access to res.body.data.removeAllBeers.should.be.true is not used.

      });

    // retrieve all beers
    var graphqlQuery = `

The variable graphqlQuery already seems to be declared on line 133. Consider using another variable name or omitting the var keyword.

    {
      beers {
        name
      }
    }`;

    chai.request(server)
      .post('/graphql')
      .send({query: graphqlQuery})
      .end(function(err, res){
        res.should.have.status(200);
        res.body.data.beers.should.be.an('array');
        res.body.data.beers.should.have.lengthOf(0);
        done();
      });
  });

});