SimpleTest - Code Metrics - Inspection of "Merge branch 'dev'" - maxistua/easy-dictionary - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 3bddf7...37f0e3 )

by Max

created 2019-02-18 08:40 UTC

SimpleTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	288
Duplicated Lines	24.31 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
wmc	16
lcom	1
cbo	5
dl	70
loc	288
rs	10
c	0
b	0
f	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	testClassExistence()	0	4	1
A	testGetDataWithDataProvider()	0	11	1
A	testGetDataWithoutDataProvider()	0	5	1
A	testSaveDataToCache()	17	17	1
A	testSaveDataToCacheThrowError()	19	19	1
A	testDataCount()	0	13	1
A	testDataIteratorWithoutView()	17	17	2
A	testDataIteratorWithGoodView()	0	22	3
A	testDataIteratorWithBadView()	17	17	2
A	testDataIteratorSearchInFlatData()	0	17	2
A	testDataIteratorSearchInArrayData()	0	16	1

How to fix Duplicated Code

<?php


namespace EasyDictionary\Dictionary;

use EasyDictionary\Interfaces\DataProviderInterface;
use PHPUnit\Framework\TestCase;
use Psr\SimpleCache\CacheInterface;
use Psr\SimpleCache\InvalidArgumentException;

/**

 * @coversDefaultClass \EasyDictionary\Dictionary\Simple
 */

class SimpleTest extends TestCase
{
    /**

     * @covers \EasyDictionary\Dictionary\Simple
     */

    public function testClassExistence()
    {
        self::assertTrue(class_exists('\EasyDictionary\Dictionary\Simple'));
    }

    /**

     * @covers ::__construct
     * @covers ::setName
     * @covers ::setDataProvider
     * @covers ::getDataProvider
     * @covers ::getCache
     * @covers ::getData
     * @covers ::loadData
     */

    public function testGetDataWithDataProvider()
    {
        $data = [0, 1, 2, 3];
        $dataProviderMock = self::createMock(DataProviderInterface::class);
        $dataProviderMock->method('getData')->willReturn($data);
        $dataProviderMock->expects(self::once())->method('getData');

        $dictionary = new Simple();
        $dictionary->setDataProvider($dataProviderMock);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        self::assertEquals($data, $dictionary->getData());
    }

    /**

     * @covers ::__construct
     * @covers ::setName
     * @covers ::getDataProvider
     * @covers ::getCache
     * @covers ::getData
     * @covers ::loadData
     */

    public function testGetDataWithoutDataProvider()
    {
        $dictionary = new Simple();
        self::assertEquals([], $dictionary->getData());
    }

    /**

     * @covers ::__construct
     * @covers ::setName
     * @covers ::getName
     * @covers ::setCache
     * @covers ::setDataProvider
     * @covers ::getDataProvider
     * @covers ::getCache
     * @covers ::getData
     * @covers ::loadData
     */

    public function testSaveDataToCache()

    {
        $data = [0, 1, 2, 3];
        $dataProviderMock = self::createMock(DataProviderInterface::class);
        $dataProviderMock->method('getData')->willReturn($data);
        $dataProviderMock->expects(self::once())->method('getData');

        $cacheMock = self::createMock(CacheInterface::class);
        $cacheMock->expects(self::once())->method('get');
        $cacheMock->expects(self::once())->method('set')->with(Simple::class . '_test', $data, 3600);

        $dictionary = new Simple('test');
        $dictionary->setDataProvider($dataProviderMock);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $dictionary->setCache($cacheMock);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        self::assertEquals($data, $dictionary->getData());
    }

    /**

     * @covers ::__construct
     * @covers ::setName
     * @covers ::getName
     * @covers ::setCache
     * @covers ::setDataProvider
     * @covers ::getDataProvider
     * @covers ::getCache
     * @covers ::getData
     * @covers ::loadData
     */

    public function testSaveDataToCacheThrowError()

    {
        $data = [0, 1, 2, 3];
        $dataProviderMock = self::createMock(DataProviderInterface::class);
        $dataProviderMock->method('getData')->willReturn($data);
        $dataProviderMock->expects(self::once())->method('getData');

        $cacheMock = self::createMock(CacheInterface::class);
        $cacheMock->expects(self::once())->method('get');
        $cacheMock->expects(self::once())->method('set')
            ->with(Simple::class . '_test', $data, 3600)
            ->willThrowException(new InvalidArgException);

        $dictionary = new Simple('test');
        $dictionary->setDataProvider($dataProviderMock);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $dictionary->setCache($cacheMock);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        self::assertEquals([], $dictionary->getData());
    }

    /**

     * @covers ::__construct
     * @covers ::setName
     * @covers ::count
     * @covers ::setDataProvider
     * @covers ::getDataProvider
     * @covers ::getCache
     * @covers ::getData
     * @covers ::loadData
     */

    public function testDataCount()
    {
        $data = [0, 1, 2, 3];
        $dataProviderMock = self::createMock(DataProviderInterface::class);
        $dataProviderMock->method('getData')->willReturn($data);
        $dataProviderMock->expects(self::once())->method('getData');

        $dictionary = new Simple('test');
        $dictionary->setDataProvider($dataProviderMock);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        self::assertTrue($dictionary instanceof \Countable);
        self::assertEquals(4, count($dictionary));
    }

    /**

     * @covers ::__construct
     * @covers ::setName
     * @covers ::getCache
     * @covers ::getData
     * @covers ::getDataProvider
     * @covers ::getDefaultView
     * @covers ::getIterator
     * @covers ::setDataProvider
     * @covers ::loadData
     */

    public function testDataIteratorWithoutView()

    {
        $data = ['a' => 0, 'b' => 1, 'c' => 2];
        $dataProviderMock = self::createMock(DataProviderInterface::class);
        $dataProviderMock->method('getData')->willReturn($data);
        $dataProviderMock->expects(self::once())->method('getData');

        $dictionary = new Simple('test');
        $dictionary->setDataProvider($dataProviderMock);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $loadedData = [];
        foreach ($dictionary as $key => $value) {
            $loadedData[$key] = $value;
        }

        self::assertEquals($data, $loadedData);
    }

    /**

     * @covers ::__construct
     * @covers ::setName
     * @covers ::getCache
     * @covers ::getData
     * @covers ::getDataProvider
     * @covers ::setDataProvider
     * @covers ::getDefaultView
     * @covers ::setDefaultView
     * @covers ::getIterator
     * @covers ::loadData
     * @covers ::withView
     */

    public function testDataIteratorWithGoodView()
    {
        $data = ['a' => 0, 'b' => 1, 'c' => 2];
        $dataProviderMock = self::createMock(DataProviderInterface::class);
        $dataProviderMock->method('getData')->willReturn($data);
        $dataProviderMock->expects(self::once())->method('getData');

        $dictionary = new Simple('test');
        $dictionary->setDataProvider($dataProviderMock);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $dictionary->setDefaultView(function ($rows) {

            foreach ($rows as $key => $row) {
                yield $key . ' ' . $row;
            }
        });
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.

        $loadedData = [];
        foreach ($dictionary as $value) {
            $loadedData[] = $value;
        }

        self::assertEquals(['a 0', 'b 1', 'c 2'], $loadedData);
    }

    /**

     * @covers ::__construct
     * @covers ::setName
     * @covers ::getCache
     * @covers ::getData
     * @covers ::getDataProvider
     * @covers ::setDataProvider
     * @covers ::getDefaultView
     * @covers ::getIterator
     * @covers ::loadData
     * @covers ::withView
     */

    public function testDataIteratorWithBadView()

    {
        $data = ['a' => 0, 'b' => 1, 'c' => 2];
        $dataProviderMock = self::createMock(DataProviderInterface::class);
        $dataProviderMock->method('getData')->willReturn($data);
        $dataProviderMock->expects(self::once())->method('getData');

        $dictionary = new Simple('test');
        $dictionary->setDataProvider($dataProviderMock);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $loadedData = [];
        foreach ($dictionary->withView(null) as $key => $value) {
            $loadedData[$key] = $value;
        }

        self::assertEquals($data, $loadedData);
    }

    /**

     * @covers ::__construct
     * @covers ::setName
     * @covers ::getCache
     * @covers ::getData
     * @covers ::getDataProvider
     * @covers ::setDataProvider
     * @covers ::getDefaultView
     * @covers ::getIterator
     * @covers ::loadData
     * @covers ::setSearchFields
     * @covers ::search
     * @covers ::getSearchFields
     */

    public function testDataIteratorSearchInFlatData()
    {
        $data = ['a' => 0, 'b' => 1, 'c' => 2];
        $dataProviderMock = self::createMock(DataProviderInterface::class);
        $dataProviderMock->method('getData')->willReturn($data);
        $dataProviderMock->expects(self::once())->method('getData');

        $dictionary = new Simple('test');
        $dictionary->setDataProvider($dataProviderMock);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $loadedData = [];
        foreach ($dictionary->search('/a|c/') as $key => $value) {
            $loadedData[$key] = $value;
        }

        self::assertEquals(['a' => 0, 'c' => 2], $loadedData);
    }

    /**

     * @covers ::__construct
     * @covers ::setName
     * @covers ::getCache
     * @covers ::getData
     * @covers ::getDataProvider
     * @covers ::setDataProvider
     * @covers ::getDefaultView
     * @covers ::getIterator
     * @covers ::loadData
     * @covers ::setSearchFields
     * @covers ::search
     * @covers ::setSearchFields
     * @covers ::getSearchFields
     */

    public function testDataIteratorSearchInArrayData()
    {
        $data = ['a' => ['code' => 33, 'code2' => 44], 'b' => ['code' => 44]];
        $dataProviderMock = self::createMock(DataProviderInterface::class);
        $dataProviderMock->method('getData')->willReturn($data);
        $dataProviderMock->expects(self::once())->method('getData');

        $dictionary = new Simple('test');
        $dictionary->setDataProvider($dataProviderMock);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $dictionary->setSearchFields([

            'code' => 1,
            'code2' => 0
        ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.

        self::assertEquals(['b' => ['code' => 44]], $dictionary->search('/44/'));
    }
}

class InvalidArgException extends \Exception implements InvalidArgumentException

{

}


1			<?php
2
			0 ignored issues – show Coding Style introduced 2018-08-20 16:11 UTC by Report Bug Copy Issue Report Missing file doc comment Loading history...
3			namespace EasyDictionary\Dictionary;
4
5			use EasyDictionary\Interfaces\DataProviderInterface;
6			use PHPUnit\Framework\TestCase;
7			use Psr\SimpleCache\CacheInterface;
8			use Psr\SimpleCache\InvalidArgumentException;
9
10			/**
			0 ignored issues – show Coding Style introduced 2019-02-18 08:47 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
11			* @coversDefaultClass \EasyDictionary\Dictionary\Simple
12			*/
			0 ignored issues – show Coding Style introduced 2018-08-20 20:18 UTC by Report Bug Copy Issue Report Missing @category tag in class comment Loading history... Coding Style introduced 2018-08-20 20:18 UTC by Report Bug Copy Issue Report Missing @package tag in class comment Loading history... Coding Style introduced 2018-08-20 20:18 UTC by Report Bug Copy Issue Report Missing @author tag in class comment Loading history... Coding Style introduced 2018-08-20 20:18 UTC by Report Bug Copy Issue Report Missing @license tag in class comment Loading history... Coding Style introduced 2018-08-20 20:18 UTC by Report Bug Copy Issue Report Missing @link tag in class comment Loading history...
13			class SimpleTest extends TestCase
14			{
15			/**
			0 ignored issues – show Coding Style introduced 2019-02-18 08:47 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
16			* @covers \EasyDictionary\Dictionary\Simple
17			*/
			0 ignored issues – show Coding Style introduced 2019-02-18 08:47 UTC by Report Bug Copy Issue Report Missing @return tag in function comment Loading history...
18			public function testClassExistence()
19			{
20			self::assertTrue(class_exists('\EasyDictionary\Dictionary\Simple'));
21			}
22
23			/**
			0 ignored issues – show Coding Style introduced 2019-02-18 08:47 UTC by Report Bug Copy Issue Report Missing short description in doc comment Loading history...
24			* @covers ::__construct
25			* @covers ::setName
26			* @covers ::setDataProvider
27			* @covers ::getDataProvider
28			* @covers ::getCache
29			* @covers ::getData
30			* @covers ::loadData
31			*/
			0 ignored issues – show Coding Style introduced 2019-02-18 08:47 UTC by Report Bug Copy Issue Report Missing @return tag in function comment Loading history...
32			public function testGetDataWithDataProvider()
33			{

maxistua / easy-dictionary

Push — master ( 3bddf7...37f0e3 )

SimpleTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

11 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like