Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
21 | class Details extends Query |
||
22 | { |
||
23 | /** |
||
24 | * Constructor. |
||
25 | * |
||
26 | * @param array $query Default value for this query |
||
27 | */ |
||
28 | public function __construct(array &$query = []) |
||
37 | |||
38 | /** |
||
39 | * Place information by placeId. |
||
40 | * |
||
41 | * @return Details |
||
42 | */ |
||
43 | public function placeId(int $placeId): self |
||
49 | |||
50 | /** |
||
51 | * Place information by osmtype and osmid. |
||
52 | * |
||
53 | * @throws InvalidParameterException |
||
54 | * |
||
55 | * @return Details |
||
56 | */ |
||
57 | View Code Duplication | public function osmId(string $osmType, int $osmId): self |
|
68 | } |
||
69 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.