AlexaSkillEventRequest::setTime() - Code Metrics - Inspection of "Merge 1.8.0" - maxbeckers/amazon-alexa-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#83)

by Maximilian

created 2020-04-15 11:58 UTC

AlexaSkillEventRequest::setTime() A

↳ Parent: AlexaSkillEventRequest

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	4
c	1
b	0
f	0
dl	0
loc	7
rs	10
cc	2
nc	2
nop	2

<?php

namespace MaxBeckers\AmazonAlexa\Request\Request\AlexaSkillEvent;

use MaxBeckers\AmazonAlexa\Request\Request\AbstractRequest;

/**
 * @author Maximilian Beckers <[email protected]>
 */
abstract class AlexaSkillEventRequest extends AbstractRequest
{
    /**
     * @var string
     */
    public $eventCreationTime;

    /**
     * @var string
     */
    public $eventPublishingTime;

    /**
     * @var string
     */
    public $requestId;

    /**
     * @param array $amazonRequest
     */
    protected function setRequestData(array $amazonRequest)
    {
        $this->requestId = $amazonRequest['requestId'];

        $this->setTime('timestamp', $amazonRequest['timeStamp']);
        $this->setTime('eventCreationTime', $amazonRequest['eventCreationTime']);
        $this->setTime('eventPublishingTime', $amazonRequest['eventPublishingTime']);

        $this->locale = $amazonRequest['locale'];

    }

    private function setTime($attribute, $value)
    {
        //Workaround for amazon developer console sending unix timestamp
        try {
            $this->{$attribute} = new \DateTime($value);
        } catch (\Exception $e) {
            $this->{$attribute} = (new \DateTime())->setTimestamp(intval($value / 1000));
        }
    }
}


1			<?php
2
3			namespace MaxBeckers\AmazonAlexa\Request\Request\AlexaSkillEvent;
4
5			use MaxBeckers\AmazonAlexa\Request\Request\AbstractRequest;
6
7			/**
8			* @author Maximilian Beckers <[email protected]>
9			*/
10			abstract class AlexaSkillEventRequest extends AbstractRequest
11			{
12			/**
13			* @var string
14			*/
15			public $eventCreationTime;
16
17			/**
18			* @var string
19			*/
20			public $eventPublishingTime;
21
22			/**
23			* @var string
24			*/
25			public $requestId;
26
27			/**
28			* @param array $amazonRequest
29			*/
30			protected function setRequestData(array $amazonRequest)
31			{
32			$this->requestId = $amazonRequest['requestId'];
33
34			$this->setTime('timestamp', $amazonRequest['timeStamp']);
35			$this->setTime('eventCreationTime', $amazonRequest['eventCreationTime']);
36			$this->setTime('eventPublishingTime', $amazonRequest['eventPublishingTime']);
37
38			$this->locale = $amazonRequest['locale'];
			0 ignored issues – show Bug Best Practice introduced 2020-04-15 12:04 UTC by Report Bug Copy Issue Report The property `locale` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
39			}
40
41			private function setTime($attribute, $value)
42			{
43			//Workaround for amazon developer console sending unix timestamp
44			try {
45			$this->{$attribute} = new \DateTime($value);
46			} catch (\Exception $e) {
47			$this->{$attribute} = (new \DateTime())->setTimestamp(intval($value / 1000));
48			}
49			}
50			}
51

maxbeckers / amazon-alexa-php

Pull Request — master (#83)

AlexaSkillEventRequest::setTime() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like