VisibilityChangeHandler::jsonSerialize() - Code Metrics - Inspection of "add APL support" - maxbeckers/amazon-alexa-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#97)

by Maximilian

created 2025-10-06 13:37 UTC

VisibilityChangeHandler::jsonSerialize() A

↳ Parent: VisibilityChangeHandler

Complexity

Conditions	6
Paths	8

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	6
eloc	8
nc	8
nop	0
dl	0
loc	14
ccs	9
cts	9
cp	1
crap	6
rs	9.2222
c	1
b	0
f	1

<?php

declare(strict_types=1);

namespace MaxBeckers\AmazonAlexa\Response\Directives\APL\Document;

use MaxBeckers\AmazonAlexa\Response\Directives\APL\StandardCommand\AbstractStandardCommand;

class VisibilityChangeHandler implements \JsonSerializable
{
    /**
     * @param AbstractStandardCommand[] $commands list of commands to run (evaluated in order)
     * @param string|null $when APL boolean expression controlling whether this handler is considered. If null, treated as 'true'.
     * @param string|null $description optional description of this handler
     */
    public function __construct(
        public array $commands = [],
        public ?string $when = null,
        public ?string $description = null,
    ) {
        // Filter and ensure valid commands
        $this->commands = array_values(array_filter(
            $this->commands,
            static fn ($c) => $c instanceof AbstractStandardCommand
        ));
    }

    public function jsonSerialize(): array
    {
        $data = [];
        if ($this->commands !== []) {
            $data['commands'] = $this->commands;
        }
        if ($this->description !== null && $this->description !== '') {
            $data['description'] = $this->description;
        }
        if ($this->when !== null && $this->when !== '') {
            $data['when'] = $this->when;
        }

        return $data;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace MaxBeckers\AmazonAlexa\Response\Directives\APL\Document;
6
7		use MaxBeckers\AmazonAlexa\Response\Directives\APL\StandardCommand\AbstractStandardCommand;
8
9		class VisibilityChangeHandler implements \JsonSerializable
10		{
11		/**
12		* @param AbstractStandardCommand[] $commands list of commands to run (evaluated in order)
13		* @param string\|null $when APL boolean expression controlling whether this handler is considered. If null, treated as 'true'.
14		* @param string\|null $description optional description of this handler
15		*/
16	19	public function __construct(
17		public array $commands = [],
18		public ?string $when = null,
19		public ?string $description = null,
20		) {
21		// Filter and ensure valid commands
22	19	$this->commands = array_values(array_filter(
23	19	$this->commands,
24	19	static fn ($c) => $c instanceof AbstractStandardCommand
25	19	));
26		}
27
28	12	public function jsonSerialize(): array
29		{
30	12	$data = [];
31	12	if ($this->commands !== []) {
32	6	$data['commands'] = $this->commands;
33		}
34	12	if ($this->description !== null && $this->description !== '') {
35	6	$data['description'] = $this->description;
36		}
37	12	if ($this->when !== null && $this->when !== '') {
38	6	$data['when'] = $this->when;
39		}
40
41	12	return $data;
42		}
43		}
44

maxbeckers / amazon-alexa-php

Pull Request — master (#97)

VisibilityChangeHandler::jsonSerialize() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like